drivers/spi/spi-pxa2xx-dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
The function pump_transfers() was split into
pxa2xx_spi_transfer_one(), pxa2xx_spi_handle_err() and
pxa2xx_spi_set_cs() in commit d5898e19c0d7 ("spi: pxa2xx: Use
core message processing loop"). The comment in
pxa2xx_spi_dma_transfer_complete() still warns about concurrent
calls to pump_transfers(), but the actual operation protected by
dma_running is now spi_finalize_current_transfer(). Update the
reference.
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
drivers/spi/spi-pxa2xx-dma.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/spi/spi-pxa2xx-dma.c b/drivers/spi/spi-pxa2xx-dma.c
index 08cb6e96ac94..c94d1d192e74 100644
--- a/drivers/spi/spi-pxa2xx-dma.c
+++ b/drivers/spi/spi-pxa2xx-dma.c
@@ -29,9 +29,9 @@ static void pxa2xx_spi_dma_transfer_complete(struct driver_data *drv_data,
/*
* It is possible that one CPU is handling ROR interrupt and other
- * just gets DMA completion. Calling pump_transfers() twice for the
- * same transfer leads to problems thus we prevent concurrent calls
- * by using dma_running.
+ * just gets DMA completion. Calling spi_finalize_current_transfer()
+ * twice for the same transfer leads to problems thus we prevent
+ * concurrent calls by using dma_running.
*/
if (atomic_dec_and_test(&drv_data->dma_running)) {
/*
--
2.25.1
On Sat, 21 Mar 2026 18:59:45 +0800, Kexin Sun wrote:
> spi: pxa2xx: update outdated reference to pump_transfers()
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.1
Thanks!
[1/1] spi: pxa2xx: update outdated reference to pump_transfers()
https://git.kernel.org/broonie/spi/c/762a3847a05c
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
© 2016 - 2026 Red Hat, Inc.