[PATCH] scsi: lpfc: update outdated comment for renamed lpfc_freenode()

Kexin Sun posted 1 patch 1 week, 6 days ago
drivers/scsi/lpfc/lpfc_hbadisc.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
[PATCH] scsi: lpfc: update outdated comment for renamed lpfc_freenode()
Posted by Kexin Sun 1 week, 6 days ago
The function lpfc_freenode() was renamed to
lpfc_cleanup_node() by commit 685f0bf7afe0 ("[SCSI] lpfc
8.1.12 : Collapse discovery lists to a single node list"),
and commit a70e63eee1c1 ("scsi: lpfc: Fix NPIV Fabric Node
reference counting") later removed the lpfc_unreg_rpi() call
from lpfc_cleanup_node().  Remove the now-inaccurate
"called from lpfc_freenode()" sentence and reflow the
remaining comment text for lpfc_unreg_rpi().

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/scsi/lpfc/lpfc_hbadisc.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c
index 8aaf05d7bb0a..ac2a0b5b0034 100644
--- a/drivers/scsi/lpfc/lpfc_hbadisc.c
+++ b/drivers/scsi/lpfc/lpfc_hbadisc.c
@@ -5228,12 +5228,11 @@ lpfc_set_unreg_login_mbx_cmpl(struct lpfc_hba *phba, struct lpfc_vport *vport,
 
 /*
  * Free rpi associated with LPFC_NODELIST entry.
- * This routine is called from lpfc_freenode(), when we are removing
- * a LPFC_NODELIST entry. It is also called if the driver initiates a
- * LOGO that completes successfully, and we are waiting to PLOGI back
- * to the remote NPort. In addition, it is called after we receive
- * and unsolicated ELS cmd, send back a rsp, the rsp completes and
- * we are waiting to PLOGI back to the remote NPort.
+ * This routine is called if the driver initiates a LOGO that completes
+ * successfully, and we are waiting to PLOGI back to the remote NPort.
+ * In addition, it is called after we receive and unsolicated ELS cmd,
+ * send back a rsp, the rsp completes and we are waiting to PLOGI back
+ * to the remote NPort.
  */
 int
 lpfc_unreg_rpi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp)
-- 
2.25.1
Re: [PATCH] scsi: lpfc: update outdated comment for renamed lpfc_freenode()
Posted by Martin K. Petersen 22 hours ago
On Sat, 21 Mar 2026 18:59:09 +0800, Kexin Sun wrote:

> The function lpfc_freenode() was renamed to
> lpfc_cleanup_node() by commit 685f0bf7afe0 ("[SCSI] lpfc
> 8.1.12 : Collapse discovery lists to a single node list"),
> and commit a70e63eee1c1 ("scsi: lpfc: Fix NPIV Fabric Node
> reference counting") later removed the lpfc_unreg_rpi() call
> from lpfc_cleanup_node().  Remove the now-inaccurate
> "called from lpfc_freenode()" sentence and reflow the
> remaining comment text for lpfc_unreg_rpi().
> 
> [...]

Applied to 7.1/scsi-queue, thanks!

[1/1] scsi: lpfc: update outdated comment for renamed lpfc_freenode()
      https://git.kernel.org/mkp/scsi/c/3d1a36afa49d

-- 
Martin K. Petersen