[PATCH] scsi: iscsi_tcp: update outdated comment for renamed iscsi_conn_set_callbacks()

Kexin Sun posted 1 patch 1 week, 6 days ago
drivers/scsi/iscsi_tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] scsi: iscsi_tcp: update outdated comment for renamed iscsi_conn_set_callbacks()
Posted by Kexin Sun 1 week, 6 days ago
The function iscsi_conn_set_callbacks() was renamed to
iscsi_sw_tcp_conn_set_callbacks() by commit 38e1a8f5479d
("[SCSI] iscsi_tcp: hook iscsi_tcp into new libiscsi_tcp
module").  Update the stale reference in
iscsi_sw_tcp_conn_restore_callbacks().

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/scsi/iscsi_tcp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 7b4fe0e6afb2..9260b1c9b0e0 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -267,7 +267,7 @@ iscsi_sw_tcp_conn_restore_callbacks(struct iscsi_conn *conn)
 	struct iscsi_sw_tcp_conn *tcp_sw_conn = tcp_conn->dd_data;
 	struct sock *sk = tcp_sw_conn->sock->sk;
 
-	/* restore socket callbacks, see also: iscsi_conn_set_callbacks() */
+	/* restore socket callbacks, see also: iscsi_sw_tcp_conn_set_callbacks() */
 	write_lock_bh(&sk->sk_callback_lock);
 	sk->sk_user_data    = NULL;
 	sk->sk_data_ready   = tcp_sw_conn->old_data_ready;
-- 
2.25.1
Re: [PATCH] scsi: iscsi_tcp: update outdated comment for renamed iscsi_conn_set_callbacks()
Posted by Martin K. Petersen 22 hours ago
On Sat, 21 Mar 2026 18:59:04 +0800, Kexin Sun wrote:

> The function iscsi_conn_set_callbacks() was renamed to
> iscsi_sw_tcp_conn_set_callbacks() by commit 38e1a8f5479d
> ("[SCSI] iscsi_tcp: hook iscsi_tcp into new libiscsi_tcp
> module").  Update the stale reference in
> iscsi_sw_tcp_conn_restore_callbacks().
> 
> 
> [...]

Applied to 7.1/scsi-queue, thanks!

[1/1] scsi: iscsi_tcp: update outdated comment for renamed iscsi_conn_set_callbacks()
      https://git.kernel.org/mkp/scsi/c/5b44c3757ca3

-- 
Martin K. Petersen