drivers/infiniband/core/rdma_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
The function remove_commit_idr_uobject() was split into
destroy_hw_idr_uobject() and remove_handle_idr_uobject() by
commit 0f50d88a6e9a ("IB/uverbs: Allow all DESTROY commands
to succeed after disassociate"). The kref put that the
comment refers to now lives in remove_handle_idr_uobject().
Update the stale reference.
Also update "allocated this IDR with a NULL object" to
"allocated this XArray entry with a NULL pointer" to match
the actual data structure (xa_store) and the wording already
used two lines below ("transfers our kref on uobj to the
XArray").
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
drivers/infiniband/core/rdma_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/core/rdma_core.c b/drivers/infiniband/core/rdma_core.c
index 3e0a8b9cd288..5018ec837056 100644
--- a/drivers/infiniband/core/rdma_core.c
+++ b/drivers/infiniband/core/rdma_core.c
@@ -590,11 +590,11 @@ static void alloc_commit_idr_uobject(struct ib_uobject *uobj)
void *old;
/*
- * We already allocated this IDR with a NULL object, so
+ * We already allocated this XArray entry with a NULL pointer, so
* this shouldn't fail.
*
* NOTE: Storing the uobj transfers our kref on uobj to the XArray.
- * It will be put by remove_commit_idr_uobject()
+ * It will be put by remove_handle_idr_uobject()
*/
old = xa_store(&ufile->idr, uobj->id, uobj, GFP_KERNEL);
WARN_ON(old != NULL);
--
2.25.1
On Sat, 21 Mar 2026 18:58:59 +0800, Kexin Sun wrote:
> The function remove_commit_idr_uobject() was split into
> destroy_hw_idr_uobject() and remove_handle_idr_uobject() by
> commit 0f50d88a6e9a ("IB/uverbs: Allow all DESTROY commands
> to succeed after disassociate"). The kref put that the
> comment refers to now lives in remove_handle_idr_uobject().
> Update the stale reference.
>
> [...]
Applied, thanks!
[1/1] RDMA/uverbs: update outdated reference to remove_commit_idr_uobject()
https://git.kernel.org/rdma/rdma/c/3909d195fe68eb
Best regards,
--
Leon Romanovsky <leon@kernel.org>
© 2016 - 2026 Red Hat, Inc.