drivers/base/memory: fix stale reference to memory_block_add_nid()

[PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid()

Posted by Kexin Sun 1 week, 6 days ago

The function memory_block_add_nid() was renamed to
memory_block_add_nid_early() by commit 0a947c14e48c
("drivers/base: move memory_block_add_nid() into the
caller").  Update the stale reference in add_memory_block().

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 drivers/base/memory.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index a3091924918b..0d6ccc7cdf05 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -815,7 +815,7 @@ static int add_memory_block(unsigned long block_id, int nid, unsigned long state
 		/*
 		 * MEM_ONLINE at this point implies early memory. With NUMA,
 		 * we'll determine the zone when setting the node id via
-		 * memory_block_add_nid(). Memory hotplug updated the zone
+		 * memory_block_add_nid_early(). Memory hotplug updated the zone
 		 * manually when memory onlining/offlining succeeds.
 		 */
 		mem->zone = early_node_zone_for_memory_block(mem, NUMA_NO_NODE);
-- 
2.25.1

Re: [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid()

Posted by Donet Tom 1 week, 4 days ago

On 3/21/26 4:27 PM, Kexin Sun wrote:
> The function memory_block_add_nid() was renamed to
> memory_block_add_nid_early() by commit 0a947c14e48c
> ("drivers/base: move memory_block_add_nid() into the
> caller").  Update the stale reference in add_memory_block().
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> ---
>   drivers/base/memory.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index a3091924918b..0d6ccc7cdf05 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -815,7 +815,7 @@ static int add_memory_block(unsigned long block_id, int nid, unsigned long state
>   		/*
>   		 * MEM_ONLINE at this point implies early memory. With NUMA,
>   		 * we'll determine the zone when setting the node id via
> -		 * memory_block_add_nid(). Memory hotplug updated the zone
> +		 * memory_block_add_nid_early(). Memory hotplug updated the zone
>   		 * manually when memory onlining/offlining succeeds.
>   		 */
>   		mem->zone = early_node_zone_for_memory_block(mem, NUMA_NO_NODE);


LGTM

Reviewed by: Donet Tom <donettom@linux.ibm.com>

Re: [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid()

Posted by David Hildenbrand (Arm) 1 week, 4 days ago

On 3/21/26 11:57, Kexin Sun wrote:
> The function memory_block_add_nid() was renamed to
> memory_block_add_nid_early() by commit 0a947c14e48c
> ("drivers/base: move memory_block_add_nid() into the
> caller").  Update the stale reference in add_memory_block().
> 
> Assisted-by: unnamed:deepseek-v3.2 coccinelle

I'm sure that patch was impossible to craft without an LLM. ;)

> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> ---

Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>

-- 
Cheers,

David