[PATCH v6 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI

Oleksij Rempel posted 7 patches 1 week, 6 days ago
There is a newer version of this series
.../bindings/pinctrl/nxp,mc33978.yaml         | 153 +++
drivers/gpio/gpiolib.c                        |  24 +-
drivers/hwmon/Kconfig                         |  10 +
drivers/hwmon/Makefile                        |   1 +
drivers/hwmon/mc33978-hwmon.c                 | 550 +++++++++++
drivers/mfd/Kconfig                           |  15 +
drivers/mfd/Makefile                          |   2 +
drivers/mfd/mc33978.c                         | 912 ++++++++++++++++++
drivers/mux/Kconfig                           |  14 +
drivers/mux/Makefile                          |   2 +
drivers/mux/mc33978-mux.c                     | 131 +++
drivers/pinctrl/Kconfig                       |  14 +
drivers/pinctrl/Makefile                      |   1 +
drivers/pinctrl/core.c                        |  41 +-
drivers/pinctrl/pinconf.c                     |   9 +-
drivers/pinctrl/pinctrl-mc33978.c             | 747 ++++++++++++++
include/linux/mfd/mc33978.h                   |  92 ++
17 files changed, 2699 insertions(+), 19 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pinctrl/nxp,mc33978.yaml
create mode 100644 drivers/hwmon/mc33978-hwmon.c
create mode 100644 drivers/mfd/mc33978.c
create mode 100644 drivers/mux/mc33978-mux.c
create mode 100644 drivers/pinctrl/pinctrl-mc33978.c
create mode 100644 include/linux/mfd/mc33978.h
[PATCH v6 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI
Posted by Oleksij Rempel 1 week, 6 days ago
This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
Interface (MSDI) via the MFD framework.

Architecture overview:
* mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
  linear irq_domain. Harvests status bits from SPI MISO MSB.
* pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
  the MFD domain.
* hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
  fault alarms.
* mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
  temperature, VBATP) to an external ADC.

Initial pinctrl implementation by David Jander, reworked into this MFD
architecture.

Best regards,
Oleksij

David Jander (1):
  pinctrl: add NXP MC33978/MC34978 pinctrl driver

Oleksij Rempel (6):
  dt-bindings: pinctrl: add NXP MC33978/MC34978 MSDI
  mfd: add NXP MC33978/MC34978 core driver
  pinctrl: core: Make pin group callbacks optional for pin-only drivers
  gpio: gpiolib: split child IRQ setup in hierarchical alloc
  hwmon: add NXP MC33978/MC34978 driver
  mux: add NXP MC33978/MC34978 AMUX driver

 .../bindings/pinctrl/nxp,mc33978.yaml         | 153 +++
 drivers/gpio/gpiolib.c                        |  24 +-
 drivers/hwmon/Kconfig                         |  10 +
 drivers/hwmon/Makefile                        |   1 +
 drivers/hwmon/mc33978-hwmon.c                 | 550 +++++++++++
 drivers/mfd/Kconfig                           |  15 +
 drivers/mfd/Makefile                          |   2 +
 drivers/mfd/mc33978.c                         | 912 ++++++++++++++++++
 drivers/mux/Kconfig                           |  14 +
 drivers/mux/Makefile                          |   2 +
 drivers/mux/mc33978-mux.c                     | 131 +++
 drivers/pinctrl/Kconfig                       |  14 +
 drivers/pinctrl/Makefile                      |   1 +
 drivers/pinctrl/core.c                        |  41 +-
 drivers/pinctrl/pinconf.c                     |   9 +-
 drivers/pinctrl/pinctrl-mc33978.c             | 747 ++++++++++++++
 include/linux/mfd/mc33978.h                   |  92 ++
 17 files changed, 2699 insertions(+), 19 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nxp,mc33978.yaml
 create mode 100644 drivers/hwmon/mc33978-hwmon.c
 create mode 100644 drivers/mfd/mc33978.c
 create mode 100644 drivers/mux/mc33978-mux.c
 create mode 100644 drivers/pinctrl/pinctrl-mc33978.c
 create mode 100644 include/linux/mfd/mc33978.h

--
2.47.3
Re: [PATCH v6 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI
Posted by Guenter Roeck 1 week, 5 days ago
Hi,

On 3/20/26 23:51, Oleksij Rempel wrote:
> This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
> Interface (MSDI) via the MFD framework.
> 
> Architecture overview:
> * mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
>    linear irq_domain. Harvests status bits from SPI MISO MSB.
> * pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
>    the MFD domain.
> * hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
>    fault alarms.
> * mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
>    temperature, VBATP) to an external ADC.
> 
Sashiko has a number of concerns with this series. See

https://sashiko.dev/#/patchset/20260321065146.3918882-1-o.rempel%40pengutronix.de

for details. I did not check the non-hwmon code, but the concerns raised with
the hwmon patch seem real. Please address.

Thanks,
Guenter