drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Replace 3 sysfs functions in the Intel Qat Driver
to use sysfs_emit() instead of scnprintf().
- erros_correctable_show(): Replace scnprint() with sysfs_emit()
- errors_nonfatal_show(): Replace scnprint() with sysfs_emit()
- errors_fatal_show(): Replace scnprint() with sysfs_emit()
This change is in accordance with Documentation/filesystems/sysfs.rst,
which recommends using sysfs_emit/sysfs_emit_at in all sysfs show()
callbacks for buffer safety, clarity, and consistency.
Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
---
Changes in v2:
- Update the Subject according to the suggestion in v1
- Link to v1: https://lore.kernel.org/r/20260320-sysfs-v1-1-91fd5ef42dea@gmail.com
---
drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c b/drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c
index e97c67c87b3c..2ca757e13c72 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c
+++ b/drivers/crypto/intel/qat/qat_common/adf_sysfs_ras_counters.c
@@ -20,7 +20,7 @@ static ssize_t errors_correctable_show(struct device *dev,
return -EINVAL;
counter = ADF_RAS_ERR_CTR_READ(accel_dev->ras_errors, ADF_RAS_CORR);
- return scnprintf(buf, PAGE_SIZE, "%ld\n", counter);
+ return sysfs_emit(buf, "%ld\n", counter);
}
static ssize_t errors_nonfatal_show(struct device *dev,
@@ -35,7 +35,7 @@ static ssize_t errors_nonfatal_show(struct device *dev,
return -EINVAL;
counter = ADF_RAS_ERR_CTR_READ(accel_dev->ras_errors, ADF_RAS_UNCORR);
- return scnprintf(buf, PAGE_SIZE, "%ld\n", counter);
+ return sysfs_emit(buf, "%ld\n", counter);
}
static ssize_t errors_fatal_show(struct device *dev,
@@ -50,7 +50,7 @@ static ssize_t errors_fatal_show(struct device *dev,
return -EINVAL;
counter = ADF_RAS_ERR_CTR_READ(accel_dev->ras_errors, ADF_RAS_FATAL);
- return scnprintf(buf, PAGE_SIZE, "%ld\n", counter);
+ return sysfs_emit(buf, "%ld\n", counter);
}
static ssize_t reset_error_counters_store(struct device *dev,
---
base-commit: 8a30aeb0d1b4e4aaf7f7bae72f20f2ae75385ccb
change-id: 20260320-sysfs-7e19eeb06586
Best regards,
--
Atharv Dubey <atharvd440@gmail.com>
On Sat, Mar 21, 2026 at 10:17:45AM +0530, Atharv Dubey wrote: > Replace 3 sysfs functions in the Intel Qat Driver > to use sysfs_emit() instead of scnprintf(). > > - erros_correctable_show(): Replace scnprint() with sysfs_emit() /s/erros/errors /s/scnprint/scnprintf/g > - errors_nonfatal_show(): Replace scnprint() with sysfs_emit() > - errors_fatal_show(): Replace scnprint() with sysfs_emit() ... > static ssize_t errors_fatal_show(struct device *dev, > @@ -50,7 +50,7 @@ static ssize_t errors_fatal_show(struct device *dev, > return -EINVAL; > > counter = ADF_RAS_ERR_CTR_READ(accel_dev->ras_errors, ADF_RAS_FATAL); > - return scnprintf(buf, PAGE_SIZE, "%ld\n", counter); > + return sysfs_emit(buf, "%ld\n", counter); Remove spurious double space after "buf,". Anyway, I just noticed that counter is declared as `unsigned long` and scnprintf() is using %d. As ADF_RAS_ERR_CTR_READ() expands to atomic_read() which returns an int, I'm going to convert `unsigned long counter` in an interger. I'm going to send a fix for the above and your patch on top (with fixes) in a small series. No action required for you. :-) Thanks, -- Giovanni
© 2016 - 2026 Red Hat, Inc.