From: Lei wang <quic_leiwan@quicinc.com>

Add unique ID for Qualcomm SA8650P SoC.

Signed-off-by: Lei Wang <quic_leiwan@quicinc.com>
Signed-off-by: Radu Rendec <rrendec@redhat.com>
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 8776844e0eeb3..85282029d80cf 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -260,6 +260,7 @@
 #define QCOM_ID_SM8475			530
 #define QCOM_ID_SM8475P			531
 #define QCOM_ID_SA8255P			532
+#define QCOM_ID_SA8650P			533
 #define QCOM_ID_SA8775P			534
 #define QCOM_ID_QRU1000			539
 #define QCOM_ID_SM8475_2		540
-- 
2.53.0

On 20/03/2026 21:59, Radu Rendec wrote:
> From: Lei wang <quic_leiwan@quicinc.com>
> 
> Add unique ID for Qualcomm SA8650P SoC.
> 
> Signed-off-by: Lei Wang <quic_leiwan@quicinc.com>

Please keep consistent spelling of identities. Not sure where the
mistake was done - either by Lei or you added his SoB?

> Signed-off-by: Radu Rendec <rrendec@redhat.com>
> ---
>  include/dt-bindings/arm/qcom,ids.h | 1 +
>  1 file changed, 1 insertion(+)
> 


Best regards,
Krzysztof

On Sat, 2026-03-21 at 11:03 +0100, Krzysztof Kozlowski wrote:
> On 20/03/2026 21:59, Radu Rendec wrote:
> > From: Lei wang <quic_leiwan@quicinc.com>
> > 
> > Add unique ID for Qualcomm SA8650P SoC.
> > 
> > Signed-off-by: Lei Wang <quic_leiwan@quicinc.com>
> 
> Please keep consistent spelling of identities. Not sure where the
> mistake was done - either by Lei or you added his SoB?

Yes, sorry, my bad! By the time I realized what I did, I had already
sent it. I'll send out v2 shortly.

> > Signed-off-by: Radu Rendec <rrendec@redhat.com>
> > ---
> >  include/dt-bindings/arm/qcom,ids.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 

On 21/03/2026 16:12, Radu Rendec wrote:
> On Sat, 2026-03-21 at 11:03 +0100, Krzysztof Kozlowski wrote:
>> On 20/03/2026 21:59, Radu Rendec wrote:
>>> From: Lei wang <quic_leiwan@quicinc.com>
>>>
>>> Add unique ID for Qualcomm SA8650P SoC.
>>>
>>> Signed-off-by: Lei Wang <quic_leiwan@quicinc.com>
>>
>> Please keep consistent spelling of identities. Not sure where the
>> mistake was done - either by Lei or you added his SoB?
> 
> Yes, sorry, my bad! By the time I realized what I did, I had already
> sent it. I'll send out v2 shortly.

Does that mean there was no original Signed-off-by? If so, you should
not add it, because you cannot certify for someone else.

Please explain the origins of this patch.

Best regards,
Krzysztof

On Sat, 2026-03-21 at 20:32 +0100, Krzysztof Kozlowski wrote:
> On 21/03/2026 16:12, Radu Rendec wrote:
> > On Sat, 2026-03-21 at 11:03 +0100, Krzysztof Kozlowski wrote:
> > > On 20/03/2026 21:59, Radu Rendec wrote:
> > > > From: Lei wang <quic_leiwan@quicinc.com>
> > > > 
> > > > Add unique ID for Qualcomm SA8650P SoC.
> > > > 
> > > > Signed-off-by: Lei Wang <quic_leiwan@quicinc.com>
> > > 
> > > Please keep consistent spelling of identities. Not sure where the
> > > mistake was done - either by Lei or you added his SoB?
> > 
> > Yes, sorry, my bad! By the time I realized what I did, I had already
> > sent it. I'll send out v2 shortly.
> 
> Does that mean there was no original Signed-off-by? If so, you should
> not add it, because you cannot certify for someone else.

It did have an original Signed-off-by tag, which I modified
accidentally. 

> Please explain the origins of this patch.

This is the origin of the patch:
https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/cecaf4e3bec17fe4fb63c52e51a02065e60c87d0

And FWIW, the origin of patch 2 is this:
https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/8050aeaebdcb3ab120d847658d831f20bd475315

Please let me know if there's anything else missing or unclear. Thanks!

-- 
Best regards,
Radu

On Fri, Mar 20, 2026 at 04:59:32PM -0400, Radu Rendec wrote:
> From: Lei wang <quic_leiwan@quicinc.com>
> 
> Add unique ID for Qualcomm SA8650P SoC.
> 
> Signed-off-by: Lei Wang <quic_leiwan@quicinc.com>
> Signed-off-by: Radu Rendec <rrendec@redhat.com>
> ---
>  include/dt-bindings/arm/qcom,ids.h | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry