[PATCH 6.12.y 1/7] timer/migration: Fix kernel-doc warnings for union tmigr_state

Ionut Nechita posted 7 patches 2 weeks, 2 days ago
[PATCH 6.12.y 1/7] timer/migration: Fix kernel-doc warnings for union tmigr_state
Posted by Ionut Nechita 2 weeks, 2 days ago
From: Randy Dunlap <rdunlap@infradead.org>

Use the correct kernel-doc notation for nested structs/unions to
eliminate warnings:

timer_migration.h:119: warning: Incorrect use of kernel-doc format:          * struct - split state of tmigr_group
timer_migration.h:134: warning: Function parameter or struct member 'active' not described in 'tmigr_state'
timer_migration.h:134: warning: Function parameter or struct member 'migrator' not described in 'tmigr_state'
timer_migration.h:134: warning: Function parameter or struct member 'seq' not described in 'tmigr_state'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250111063156.910903-1-rdunlap@infradead.org
---
 kernel/time/timer_migration.h | 21 +++++++++------------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/kernel/time/timer_migration.h b/kernel/time/timer_migration.h
index 154accc7a543c..ae19f70f8170f 100644
--- a/kernel/time/timer_migration.h
+++ b/kernel/time/timer_migration.h
@@ -110,22 +110,19 @@ struct tmigr_cpu {
  * union tmigr_state - state of tmigr_group
  * @state:	Combined version of the state - only used for atomic
  *		read/cmpxchg function
- * @struct:	Split version of the state - only use the struct members to
+ * &anon struct: Split version of the state - only use the struct members to
  *		update information to stay independent of endianness
+ * @active:	Contains each mask bit of the active children
+ * @migrator:	Contains mask of the child which is migrator
+ * @seq:	Sequence counter needs to be increased when an update
+ *		to the tmigr_state is done. It prevents a race when
+ *		updates in the child groups are propagated in changed
+ *		order. Detailed information about the scenario is
+ *		given in the documentation at the begin of
+ *		timer_migration.c.
  */
 union tmigr_state {
 	u32 state;
-	/**
-	 * struct - split state of tmigr_group
-	 * @active:	Contains each mask bit of the active children
-	 * @migrator:	Contains mask of the child which is migrator
-	 * @seq:	Sequence counter needs to be increased when an update
-	 *		to the tmigr_state is done. It prevents a race when
-	 *		updates in the child groups are propagated in changed
-	 *		order. Detailed information about the scenario is
-	 *		given in the documentation at the begin of
-	 *		timer_migration.c.
-	 */
 	struct {
 		u8	active;
 		u8	migrator;
-- 
2.53.0
Re: [PATCH 6.12.y 1/7] timer/migration: Fix kernel-doc warnings for union tmigr_state
Posted by Greg KH 2 weeks, 2 days ago
On Fri, Mar 20, 2026 at 10:44:36PM +0200, Ionut Nechita wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Use the correct kernel-doc notation for nested structs/unions to
> eliminate warnings:
> 
> timer_migration.h:119: warning: Incorrect use of kernel-doc format:          * struct - split state of tmigr_group
> timer_migration.h:134: warning: Function parameter or struct member 'active' not described in 'tmigr_state'
> timer_migration.h:134: warning: Function parameter or struct member 'migrator' not described in 'tmigr_state'
> timer_migration.h:134: warning: Function parameter or struct member 'seq' not described in 'tmigr_state'
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Link: https://lore.kernel.org/all/20250111063156.910903-1-rdunlap@infradead.org
> ---
>  kernel/time/timer_migration.h | 21 +++++++++------------
>  1 file changed, 9 insertions(+), 12 deletions(-)

You did not provide the upstream git id for any of these :(

Please resend the series with that added.

thanks,

greg k-h