[PATCH v4 5/5] nfsd: remove obsolete __maybe_unused from variables

Sean Chang posted 5 patches 2 weeks ago
There is a newer version of this series
[PATCH v4 5/5] nfsd: remove obsolete __maybe_unused from variables
Posted by Sean Chang 2 weeks ago
Now that dprintk() has been refactored to use no_printk(), variables
used only for debugging are properly referenced by the compiler even
when CONFIG_SUNRPC_DEBUG is disabled.

Therefore, the __maybe_unused attributes added in commit ebae102897e7
("nfsd: Mark variable __maybe_unused to avoid W=1 build break") are
no longer necessary. This patch removes them to clean up the code.

Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Sean Chang <seanwascoding@gmail.com>
---
 fs/nfsd/export.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index 8fdbba7cad96..8116e5bcbe00 100644
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -1025,7 +1025,7 @@ exp_rootfh(struct net *net, struct auth_domain *clp, char *name,
 {
 	struct svc_export	*exp;
 	struct path		path;
-	struct inode		*inode __maybe_unused;
+	struct inode		*inode;
 	struct svc_fh		fh;
 	int			err;
 	struct nfsd_net		*nn = net_generic(net, nfsd_net_id);
-- 
2.34.1
Re: [PATCH v4 5/5] nfsd: remove obsolete __maybe_unused from variables
Posted by Andy Shevchenko 2 weeks ago
On Sat, Mar 21, 2026 at 02:09:55AM +0800, Sean Chang wrote:
> Now that dprintk() has been refactored to use no_printk(), variables
> used only for debugging are properly referenced by the compiler even
> when CONFIG_SUNRPC_DEBUG is disabled.
> 
> Therefore, the __maybe_unused attributes added in commit ebae102897e7
> ("nfsd: Mark variable __maybe_unused to avoid W=1 build break") are
> no longer necessary. This patch removes them to clean up the code.

Just make it a revert: proper Subject like 'Revert: "..."' and
the Git added line "This reverts ...".

-- 
With Best Regards,
Andy Shevchenko