[v2] pinctrl: abx500: Fix type of 'argument' variable

[PATCH v2] pinctrl: abx500: Fix type of 'argument' variable

Posted by Yu-Chun Lin 2 weeks ago

The argument variable is assigned the return value of
pinconf_to_config_argument(), which returns a u32. Change its type from
enum pin_config_param to unsigned int to correctly store the configuration
argument.

Fixes: 03b054e9696c ("pinctrl: Pass all configs to driver on pin_config_set()")
Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>
---
Changes in v2:
- Rebased on the latest mainline to fix the recipient list.
- Updated the variable type to match the commit message.
---
 drivers/pinctrl/nomadik/pinctrl-abx500.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/nomadik/pinctrl-abx500.c b/drivers/pinctrl/nomadik/pinctrl-abx500.c
index fc7ebeda8440..858fbaebcf8e 100644
--- a/drivers/pinctrl/nomadik/pinctrl-abx500.c
+++ b/drivers/pinctrl/nomadik/pinctrl-abx500.c
@@ -852,7 +852,7 @@ static int abx500_pin_config_set(struct pinctrl_dev *pctldev,
 	int ret = -EINVAL;
 	int i;
 	enum pin_config_param param;
-	enum pin_config_param argument;
+	unsigned int argument;
 
 	for (i = 0; i < num_configs; i++) {
 		param = pinconf_to_config_param(configs[i]);
-- 
2.34.1

Re: [PATCH v2] pinctrl: abx500: Fix type of 'argument' variable

Posted by Linus Walleij 1 week, 4 days ago

On Fri, Mar 20, 2026 at 4:15 PM Yu-Chun Lin <eleanor15x@gmail.com> wrote:

> The argument variable is assigned the return value of
> pinconf_to_config_argument(), which returns a u32. Change its type from
> enum pin_config_param to unsigned int to correctly store the configuration
> argument.
>
> Fixes: 03b054e9696c ("pinctrl: Pass all configs to driver on pin_config_set()")
> Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com>

Patch applied as nonurgent fix, thanks!

Yours,
Linus Walleij