[PATCH] staging: axis-fifo: remove redundant comments for mutex fields

Zile Xiong posted 1 patch 2 weeks, 1 day ago
drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] staging: axis-fifo: remove redundant comments for mutex fields
Posted by Zile Xiong 2 weeks, 1 day ago
Remove redundant comments for read_lock and write_lock, as the
field names already clearly describe their purpose.

Signed-off-by: Zile Xiong <xiongzile99@gmail.com>
---
 drivers/staging/axis-fifo/axis-fifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 3aa2aa870ea9..ad98d5eb7751 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -75,9 +75,9 @@ struct axis_fifo {
 	u32 has_tx_fifo;
 
 	wait_queue_head_t read_queue;
-	struct mutex read_lock; /* lock for reading */
+	struct mutex read_lock;
 	wait_queue_head_t write_queue;
-	struct mutex write_lock; /* lock for writing */
+	struct mutex write_lock;
 
 	struct device *dt_device;
 	struct miscdevice miscdev;
-- 
2.39.5
Re: [PATCH] staging: axis-fifo: remove redundant comments for mutex fields
Posted by Dan Carpenter 2 weeks ago
On Fri, Mar 20, 2026 at 12:40:40PM +0800, Zile Xiong wrote:
> Remove redundant comments for read_lock and write_lock, as the
> field names already clearly describe their purpose.
> 
> Signed-off-by: Zile Xiong <xiongzile99@gmail.com>

You're not wrong, but this introduces a checkpatch warning so we
can't accept it either.

regards,
dan carpenter