[PATCH 1/4] kbuild: vdso_install: split out the readelf invocation

Thomas Weißschuh posted 4 patches 2 weeks ago
There is a newer version of this series
[PATCH 1/4] kbuild: vdso_install: split out the readelf invocation
Posted by Thomas Weißschuh 2 weeks ago
Some upcoming changes to the readelf invocation would create a
very long line otherwise.

Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 scripts/Makefile.vdsoinst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/Makefile.vdsoinst b/scripts/Makefile.vdsoinst
index ac85f9a4a569..214c561651cf 100644
--- a/scripts/Makefile.vdsoinst
+++ b/scripts/Makefile.vdsoinst
@@ -21,7 +21,8 @@ $$(dest): $(1) FORCE
 
 # Some architectures create .build-id symlinks
 ifneq ($(filter arm s390 sparc x86, $(SRCARCH)),)
-link := $(install-dir)/.build-id/$$(shell $(READELF) -n $(1) | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p').debug
+build-id-file := $$(shell $(READELF) -n $(1) | sed -n 's@^.*Build ID: \(..\)\(.*\)@\1/\2@p')
+link := $(install-dir)/.build-id/$$(build-id-file).debug
 
 __default: $$(link)
 $$(link): $$(dest) FORCE

-- 
2.53.0

Re: [PATCH 1/4] kbuild: vdso_install: split out the readelf invocation
Posted by Nicolas Schier 3 days, 13 hours ago
On Fri, 20 Mar 2026 17:36:53 +0100, Thomas Weißschuh <linux@weissschuh.net> wrote:
> Some upcoming changes to the readelf invocation would create a
> very long line otherwise.

(I get confused frequently if commit description is not self-contained
but only completing the subject.)

Reviewed-by: Nicolas Schier <nsc@kernel.org>

-- 
Nicolas