[PATCH 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock

David Heidelberg via B4 Relay posted 3 patches 2 weeks ago
There is a newer version of this series
[PATCH 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock
Posted by David Heidelberg via B4 Relay 2 weeks ago
From: Casey Connolly <casey.connolly@linaro.org>

Sets a higher rate than the default for good responsiveness of
touchscreen.

Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
index 1f21da310b762..8d4bf858b238b 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
@@ -432,6 +432,8 @@ &gpu_zap_shader {
 };
 
 &i2c5 {
+	clock-frequency = <400000>;
+
 	status = "okay";
 
 	touchscreen@38 {

-- 
2.53.0
Re: [PATCH 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock
Posted by Konrad Dybcio 1 week, 4 days ago
On 3/20/26 5:29 PM, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
> 
> Sets a higher rate than the default for good responsiveness of
> touchscreen.
> 
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---

I assume this is in line with downstream (i.e. you're not trying to make
the panel IC work too hard?)

Konrad
Re: [PATCH 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock
Posted by David Heidelberg 1 week, 4 days ago

On 23/03/2026 10:56, Konrad Dybcio wrote:
> On 3/20/26 5:29 PM, David Heidelberg via B4 Relay wrote:
>> From: Casey Connolly <casey.connolly@linaro.org>
>>
>> Sets a higher rate than the default for good responsiveness of
>> touchscreen.
>>
>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
> 
> I assume this is in line with downstream (i.e. you're not trying to make
> the panel IC work too hard?)

When bus frequency is not specified in DTS (which isn't in this case), 
downstream set i2c bus to 400 kHz.

See
https://github.com/SHIFTPHONES/android_kernel_shift_sdm845/blob/lineage/lineage-20/drivers/i2c/busses/i2c-qcom-geni.c#L894

David

> 
> Konrad

-- 
David Heidelberg
Re: [PATCH 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock
Posted by Konrad Dybcio 1 week, 3 days ago
On 3/24/26 12:15 AM, David Heidelberg wrote:
> 
> 
> On 23/03/2026 10:56, Konrad Dybcio wrote:
>> On 3/20/26 5:29 PM, David Heidelberg via B4 Relay wrote:
>>> From: Casey Connolly <casey.connolly@linaro.org>
>>>
>>> Sets a higher rate than the default for good responsiveness of
>>> touchscreen.
>>>
>>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>
>> I assume this is in line with downstream (i.e. you're not trying to make
>> the panel IC work too hard?)
> 
> When bus frequency is not specified in DTS (which isn't in this case), downstream set i2c bus to 400 kHz.
> 
> See
> https://github.com/SHIFTPHONES/android_kernel_shift_sdm845/blob/lineage/lineage-20/drivers/i2c/busses/i2c-qcom-geni.c#L894

OK

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad
Re: [PATCH 2/3] arm64: dts: qcom: sdm845-shift-axolotl: Set higher touchscreen i2c clock
Posted by Dmitry Baryshkov 1 week, 6 days ago
On Fri, Mar 20, 2026 at 05:29:06PM +0100, David Heidelberg via B4 Relay wrote:
> From: Casey Connolly <casey.connolly@linaro.org>
> 
> Sets a higher rate than the default for good responsiveness of
> touchscreen.
> 
> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry