[v3] selftests: drivers: bash support for remote traffic generators

[PATCH net-next v3 6/9] selftests: drivers: hw: test rmon counters only on first interface

Posted by Ioana Ciornei 2 weeks, 3 days ago

The selftests in drivers/net are slowly transitioning to being able to
be used on systems with a single network interface. The first step for the
ethtool_rmon.sh test is to only validate that the rmon counters are
properly exported on the first interface supplied as an argument.

Remove the rmon_histogram calls which intend to test also the rmon
counters on the 2nd interface. This also removes the need for the remote
system, which should be used only to inject traffic, to also support
rmon counters.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
---
Changes in v3:
- none
Changes in v2:
- patch is new

 tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh b/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh
index 417627e7a592..636429018b6b 100755
--- a/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh
+++ b/tools/testing/selftests/drivers/net/hw/ethtool_rmon.sh
@@ -106,13 +106,11 @@ rmon_histogram()
 rmon_rx_histogram()
 {
 	rmon_histogram "$h1" "$h2" rx
-	rmon_histogram "$h2" "$h1" rx
 }
 
 rmon_tx_histogram()
 {
 	rmon_histogram "$h1" "$h2" tx
-	rmon_histogram "$h2" "$h1" tx
 }
 
 setup_prepare()
-- 
2.25.1

Re: [PATCH net-next v3 6/9] selftests: drivers: hw: test rmon counters only on first interface

Posted by Petr Machata 2 weeks, 2 days ago

Ioana Ciornei <ioana.ciornei@nxp.com> writes:

> The selftests in drivers/net are slowly transitioning to being able to
> be used on systems with a single network interface. The first step for the
> ethtool_rmon.sh test is to only validate that the rmon counters are
> properly exported on the first interface supplied as an argument.
>
> Remove the rmon_histogram calls which intend to test also the rmon
> counters on the 2nd interface. This also removes the need for the remote
> system, which should be used only to inject traffic, to also support
> rmon counters.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Reviewed-by: Petr Machata <petrm@nvidia.com>