[PATCH v3 3/3] arm64: dts: cix: add DT nodes for DMA

Jun Guo posted 3 patches 2 weeks, 4 days ago
There is a newer version of this series
[PATCH v3 3/3] arm64: dts: cix: add DT nodes for DMA
Posted by Jun Guo 2 weeks, 4 days ago
Add the device tree node for the dma controller of the CIX SKY1 SoC.

Signed-off-by: Jun Guo <jun.guo@cixtech.com>
Link: https://lore.kernel.org/r/20251216123026.3519923-4-jun.guo@cixtech.com
---
 arch/arm64/boot/dts/cix/sky1.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/cix/sky1.dtsi b/arch/arm64/boot/dts/cix/sky1.dtsi
index 210739beac6d..1185c99d8d9d 100644
--- a/arch/arm64/boot/dts/cix/sky1.dtsi
+++ b/arch/arm64/boot/dts/cix/sky1.dtsi
@@ -480,6 +480,13 @@ iomuxc: pinctrl@4170000 {
 			reg = <0x0 0x04170000 0x0 0x1000>;
 		};
 
+		fch_dmac: dma-controller@4190000 {
+			compatible = "cix,sky1-dma-350", "arm,dma-350";
+			reg = <0x0 0x4190000 0x0 0x10000>;
+			interrupts = <GIC_SPI 303 IRQ_TYPE_LEVEL_HIGH 0>;
+			#dma-cells = <1>;
+		};
+
 		mbox_ap2se: mailbox@5060000 {
 			compatible = "cix,sky1-mbox";
 			reg = <0x0 0x05060000 0x0 0x10000>;
-- 
2.34.1
Re: [PATCH v3 3/3] arm64: dts: cix: add DT nodes for DMA
Posted by Krzysztof Kozlowski 2 weeks, 3 days ago
On Thu, Mar 19, 2026 at 06:17:23PM +0800, Jun Guo wrote:
> Add the device tree node for the dma controller of the CIX SKY1 SoC.
> 
> Signed-off-by: Jun Guo <jun.guo@cixtech.com>
> Link: https://lore.kernel.org/r/20251216123026.3519923-4-jun.guo@cixtech.com

How useful is this link? It points to exactly same code, so what does it
tell?

Drop all Links from your patches and read the docs how they are used.

Best regards,
Krzysztof
Re: [PATCH v3 3/3] arm64: dts: cix: add DT nodes for DMA
Posted by Jun Guo 2 weeks, 3 days ago

On 3/20/2026 5:13 PM, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL
> 
> On Thu, Mar 19, 2026 at 06:17:23PM +0800, Jun Guo wrote:
>> Add the device tree node for the dma controller of the CIX SKY1 SoC.
>>
>> Signed-off-by: Jun Guo <jun.guo@cixtech.com>
>> Link: https://lore.kernel.org/r/20251216123026.3519923-4-jun.guo@cixtech.com
> 
> How useful is this link? It points to exactly same code, so what does it
> tell?
> 
> Drop all Links from your patches and read the docs how they are used.
> 
Thank you for the reminder. I will fix these links in the next version
of the patch.
> Best regards,
> Krzysztof
> 

Best regards,
Jun