[v1] staging: media: av7110: remove dead code in av7110.c

[PATCH] staging: media: av7110: remove dead code in av7110.c

Posted by Tomasz Unger 2 weeks, 3 days ago

Remove two commented-out lines of dead code that serve no purpose.

Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
Checked with scripts/checkpatch.pl - no errors, no warnings.
---
 drivers/staging/media/av7110/av7110.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
index 607992100baf..490963c0ccce 100644
--- a/drivers/staging/media/av7110/av7110.c
+++ b/drivers/staging/media/av7110/av7110.c
@@ -314,7 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len,
 	}
 }
 
-//#define DEBUG_TIMING
 static inline void print_time(char *s)
 {
 #ifdef DEBUG_TIMING
@@ -762,7 +761,6 @@ static int StartHWFilter(struct dvb_demux_filter *dvbdmxfilter)
 	u16 buf[20];
 	int ret, i;
 	u16 handle;
-//	u16 mode = 0x0320;
 	u16 mode = 0xb96a;
 
 	dprintk(4, "%p\n", av7110);

---
base-commit: f3f5d52d6bcdf190891601a11910cdd596963c1e
change-id: 20260319-av7110-dead-code-ef974a5d7faf

Best regards,
-- 
Tomasz Unger <tomasz.unger@yahoo.pl>

Re: [PATCH] staging: media: av7110: remove dead code in av7110.c

Posted by Dan Carpenter 2 weeks, 3 days ago

On Thu, Mar 19, 2026 at 11:16:37AM +0100, Tomasz Unger wrote:
> Remove two commented-out lines of dead code that serve no purpose.
> 
> Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
> ---
> Checked with scripts/checkpatch.pl - no errors, no warnings.
> ---
>  drivers/staging/media/av7110/av7110.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c
> index 607992100baf..490963c0ccce 100644
> --- a/drivers/staging/media/av7110/av7110.c
> +++ b/drivers/staging/media/av7110/av7110.c
> @@ -314,7 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len,
>  	}
>  }
>  
> -//#define DEBUG_TIMING
>  static inline void print_time(char *s)
>  {
>  #ifdef DEBUG_TIMING
   ^^^^^^^^^^^^^^^^^^^
Get rid of this stuff too.

> @@ -762,7 +761,6 @@ static int StartHWFilter(struct dvb_demux_filter *dvbdmxfilter)
>  	u16 buf[20];
>  	int ret, i;
>  	u16 handle;
> -//	u16 mode = 0x0320;

At that point, you'll probably want to split it into two patches.

regards,
dan carpenter

>  	u16 mode = 0xb96a;
>  
>  	dprintk(4, "%p\n", av7110);
>