media: hdmirx: snps, rk: Fix HPD hold time

[PATCH v1] media: hdmirx: snps, rk: Fix HPD hold time

Posted by Dmitry Osipenko 2 weeks, 4 days ago

Increase time of holding HPD pin low by 50ms. This fixes EDID change not
detected by sink/display side.

Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
Reported-by: Ross Cawston <ross@r-sc.ca>
Closes: https://lore.kernel.org/linux-rockchip/20260209061654.54757-1-ross@r-sc.ca/
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
 drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
index 61ad20b18b8d..4c8957505a50 100644
--- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
+++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
@@ -506,9 +506,9 @@ static void hdmirx_hpd_ctrl(struct snps_hdmirx_dev *hdmirx_dev, bool en)
 	hdmirx_writel(hdmirx_dev, CORE_CONFIG,
 		      hdmirx_dev->hpd_trigger_level_high ? en : !en);
 
-	/* 100ms delay as per HDMI spec */
+	/* 100ms delay as per HDMI spec + extra 50ms to cover internal delay */
 	if (!en)
-		msleep(100);
+		msleep(100 + 50);
 }
 
 static void hdmirx_write_edid_data(struct snps_hdmirx_dev *hdmirx_dev,
-- 
2.52.0

Re: [PATCH v1] media: hdmirx: snps, rk: Fix HPD hold time

Posted by Sebastian Reichel 2 weeks, 3 days ago

Hi,

On Wed, Mar 18, 2026 at 10:26:19PM +0300, Dmitry Osipenko wrote:
> Increase time of holding HPD pin low by 50ms. This fixes EDID change not
> detected by sink/display side.
> 
> Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
> Reported-by: Ross Cawston <ross@r-sc.ca>
> Closes: https://lore.kernel.org/linux-rockchip/20260209061654.54757-1-ross@r-sc.ca/
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> ---

The prefix in the patch subject should probably be
'media: platform: synopsys: hdmirx:' or 'media: synopsys: hdmirx:'.

Greetings,

-- Sebastian

>  drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> index 61ad20b18b8d..4c8957505a50 100644
> --- a/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> +++ b/drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c
> @@ -506,9 +506,9 @@ static void hdmirx_hpd_ctrl(struct snps_hdmirx_dev *hdmirx_dev, bool en)
>  	hdmirx_writel(hdmirx_dev, CORE_CONFIG,
>  		      hdmirx_dev->hpd_trigger_level_high ? en : !en);
>  
> -	/* 100ms delay as per HDMI spec */
> +	/* 100ms delay as per HDMI spec + extra 50ms to cover internal delay */
>  	if (!en)
> -		msleep(100);
> +		msleep(100 + 50);
>  }
>  
>  static void hdmirx_write_edid_data(struct snps_hdmirx_dev *hdmirx_dev,
> -- 
> 2.52.0
>

Re: [PATCH v1] media: hdmirx: snps, rk: Fix HPD hold time

Posted by Dmitry Osipenko 1 week, 5 days ago

On 3/19/26 23:45, Sebastian Reichel wrote:
> Hi,
> 
> On Wed, Mar 18, 2026 at 10:26:19PM +0300, Dmitry Osipenko wrote:
>> Increase time of holding HPD pin low by 50ms. This fixes EDID change not
>> detected by sink/display side.
>>
>> Fixes: 7b59b132ad43 ("media: platform: synopsys: Add support for HDMI input driver")
>> Reported-by: Ross Cawston <ross@r-sc.ca>
>> Closes: https://lore.kernel.org/linux-rockchip/20260209061654.54757-1-ross@r-sc.ca/
>> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> ---
> 
> The prefix in the patch subject should probably be
> 'media: platform: synopsys: hdmirx:' or 'media: synopsys: hdmirx:'.

Good catch

-- 
Best regards,
Dmitry