[v3] dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

[PATCH v3] dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

Posted by phucduc.bui@gmail.com 2 weeks, 5 days ago

From: bui duc phuc <phucduc.bui@gmail.com>

Document the "wakeup-source" property for the ti,tsc2005 touchscreen
controllers to allow the device to wake the system from suspend.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---

changes:
v3: Remove blank lines
v2: Revise the commit content and remove patch1 related to I2C and SPI 
wakeup handling

 .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml    | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
index 7187c390b2f5..a9842509c1fe 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
@@ -55,6 +55,9 @@ properties:
   touchscreen-size-x: true
   touchscreen-size-y: true
 
+  wakeup-source:
+    type: boolean
+
 allOf:
   - $ref: touchscreen.yaml#
   - if:
@@ -97,6 +100,7 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
   - |
@@ -124,5 +128,6 @@ examples:
 
             ti,x-plate-ohms = <280>;
             ti,esd-recovery-timeout-ms = <8000>;
+            wakeup-source;
         };
     };
-- 
2.43.0

Re: [PATCH v3] dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

Posted by Rob Herring 1 week, 4 days ago

On Wed, Mar 18, 2026 at 03:31:24PM +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Document the "wakeup-source" property for the ti,tsc2005 touchscreen
> controllers to allow the device to wake the system from suspend.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
> 
> changes:
> v3: Remove blank lines
> v2: Revise the commit content and remove patch1 related to I2C and SPI 
> wakeup handling
> 
>  .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml    | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> index 7187c390b2f5..a9842509c1fe 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> @@ -55,6 +55,9 @@ properties:
>    touchscreen-size-x: true
>    touchscreen-size-y: true
>  
> +  wakeup-source:
> +    type: boolean

wakeup-source already has a defined type.

wakeup-source: true

> +
>  allOf:
>    - $ref: touchscreen.yaml#
>    - if:
> @@ -97,6 +100,7 @@ examples:
>  
>              ti,x-plate-ohms = <280>;
>              ti,esd-recovery-timeout-ms = <8000>;
> +            wakeup-source;
>          };
>      };
>    - |
> @@ -124,5 +128,6 @@ examples:
>  
>              ti,x-plate-ohms = <280>;
>              ti,esd-recovery-timeout-ms = <8000>;
> +            wakeup-source;
>          };
>      };
> -- 
> 2.43.0
>

Re: [PATCH v3] dt-bindings: input: touchscreen: ti,tsc2005: Add wakeup-source

Posted by Bui Duc Phuc 3 days, 13 hours ago

Hi Rob, Krzysztof, Conor,

Thanks for the discussion.

The core schema already defines "wakeup-source" as a common property
(using oneOf for boolean or phandle-array), so defining the type here is
redundant.

https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/wakeup-source.yaml

I'll update it to "wakeup-source: true" in v4.

Best regards,
Phuc

On Thu, Mar 26, 2026 at 9:15 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Mar 18, 2026 at 03:31:24PM +0700, phucduc.bui@gmail.com wrote:
> > From: bui duc phuc <phucduc.bui@gmail.com>
> >
> > Document the "wakeup-source" property for the ti,tsc2005 touchscreen
> > controllers to allow the device to wake the system from suspend.
> >
> > Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> > ---
> >
> > changes:
> > v3: Remove blank lines
> > v2: Revise the commit content and remove patch1 related to I2C and SPI
> > wakeup handling
> >
> >  .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml    | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> > index 7187c390b2f5..a9842509c1fe 100644
> > --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> > +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
> > @@ -55,6 +55,9 @@ properties:
> >    touchscreen-size-x: true
> >    touchscreen-size-y: true
> >
> > +  wakeup-source:
> > +    type: boolean
>
> wakeup-source already has a defined type.
>
> wakeup-source: true
>
> > +
> >  allOf:
> >    - $ref: touchscreen.yaml#
> >    - if:
> > @@ -97,6 +100,7 @@ examples:
> >
> >              ti,x-plate-ohms = <280>;
> >              ti,esd-recovery-timeout-ms = <8000>;
> > +            wakeup-source;
> >          };
> >      };
> >    - |
> > @@ -124,5 +128,6 @@ examples:
> >
> >              ti,x-plate-ohms = <280>;
> >              ti,esd-recovery-timeout-ms = <8000>;
> > +            wakeup-source;
> >          };
> >      };
> > --
> > 2.43.0
> >