[PATCH v2] tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move

Ke Zhao posted 1 patch 2 weeks, 5 days ago
tools/sched_ext/scx_flatcg.bpf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move
Posted by Ke Zhao 2 weeks, 5 days ago
The function scx_ops_error() was droped, but the
comment here is left pointing to the old name.
Update to be consistent with current API.

Signed-off-by: Ke Zhao <ke.zhao.kernel@gmail.com>
---
v2:
 - Corrected the new function name to scx_bpf_error instead of scx_error.


 tools/sched_ext/scx_flatcg.bpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/sched_ext/scx_flatcg.bpf.c b/tools/sched_ext/scx_flatcg.bpf.c
index 0e785cff0f24..c0574ff416c7 100644
--- a/tools/sched_ext/scx_flatcg.bpf.c
+++ b/tools/sched_ext/scx_flatcg.bpf.c
@@ -919,7 +919,7 @@ void BPF_STRUCT_OPS(fcg_cgroup_move, struct task_struct *p,
 	struct fcg_cgrp_ctx *from_cgc, *to_cgc;
 	s64 delta;
 
-	/* find_cgrp_ctx() triggers scx_ops_error() on lookup failures */
+	/* find_cgrp_ctx() triggers scx_bpf_error() on lookup failures */
 	if (!(from_cgc = find_cgrp_ctx(from)) || !(to_cgc = find_cgrp_ctx(to)))
 		return;
 
-- 
2.43.0
Re: [PATCH v2] tools/sched_ext: Update stale scx_ops_error comment in fcg_cgroup_move
Posted by Cheng-Yang Chou 2 weeks, 5 days ago
Hi Ke,

On Wed, Mar 18, 2026 at 02:14:57PM +0800, Ke Zhao wrote:
> The function scx_ops_error() was droped, but the

Nit:
- s/droped/dropped/
- Use scx_ops_error() and fcg_cgroup_move() (with parentheses) in the
  subject to denote functions.

-- 
Thanks,
Cheng-Yang