Add the binding for the USB3.2 Genesys Logic GL3590 hub.
GL3590 hub requires 1.2V and 3.3V supplies for operation.

Signed-off-by: Swati Agarwal <swati.agarwal@oss.qualcomm.com>
---
 .../devicetree/bindings/usb/genesys,gl850g.yaml  | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
index 9a94b2a74a1e..d8ca9fe5a593 100644
--- a/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
+++ b/Documentation/devicetree/bindings/usb/genesys,gl850g.yaml
@@ -15,6 +15,7 @@ properties:
       - usb5e3,608
       - usb5e3,610
       - usb5e3,620
+      - usb5e3,625
       - usb5e3,626
 
   reg: true
@@ -26,6 +27,10 @@ properties:
     description:
       The regulator that provides 3.3V or 5.0V core power to the hub.
 
+  vdd12-supply:
+    description:
+      The regulator that provides 1.2V power to the hub.
+
   peer-hub: true
 
   ports:
@@ -69,6 +74,17 @@ allOf:
         peer-hub: true
         vdd-supply: true
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - usb5e3,625
+    then:
+      properties:
+        peer-hub: true
+        vdd-supply: true
+
 unevaluatedProperties: false
 
 examples:
-- 
2.34.1

On Wed, Mar 18, 2026 at 09:36:41AM +0530, Swati Agarwal wrote:

A nit, subject: drop second/last, redundant "binding fir". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

>    reg: true
> @@ -26,6 +27,10 @@ properties:
>      description:
>        The regulator that provides 3.3V or 5.0V core power to the hub.
>  
> +  vdd12-supply:
> +    description:
> +      The regulator that provides 1.2V power to the hub.
> +
>    peer-hub: true
>  
>    ports:
> @@ -69,6 +74,17 @@ allOf:
>          peer-hub: true
>          vdd-supply: true

Here and in other cases you forgot to forbid new property (: false).

Best regards,
Krzysztof

On Wed, Mar 18, 2026 at 12:31 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, Mar 18, 2026 at 09:36:41AM +0530, Swati Agarwal wrote:
>
> A nit, subject: drop second/last, redundant "binding fir". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> >    reg: true
> > @@ -26,6 +27,10 @@ properties:
> >      description:
> >        The regulator that provides 3.3V or 5.0V core power to the hub.
> >
> > +  vdd12-supply:
> > +    description:
> > +      The regulator that provides 1.2V power to the hub.
> > +
> >    peer-hub: true
> >
> >    ports:
> > @@ -69,6 +74,17 @@ allOf:
> >          peer-hub: true
> >          vdd-supply: true
>
> Here and in other cases you forgot to forbid new property (: false).
Hi Krysztof,
My v5 patch series address this thing as follows:-
https://lore.kernel.org/all/20260122092852.887624-2-swati.agarwal@oss.qualcomm.com/

But as per feedback from Rob on v4 and v5 series, i address it as per
his comment.

https://lore.kernel.org/all/20260122170651.GA2632938-robh@kernel.org/#t
https://lore.kernel.org/all/20260121022449.GA1804139-robh@kernel.org/#t

Let me know how we should proceed further on this @Rob Herring
@Krzysztof Kozlowski .

Regards,
Swati

On 26/03/2026 11:07, Swati Agarwal wrote:
> https://lore.kernel.org/all/20260121022449.GA1804139-robh@kernel.org/#t

Exactly this comment is not implemented. v5 repeated it. I repeated now.

Best regards,
Krzysztof

On Thu, Mar 26, 2026 at 3:39 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 26/03/2026 11:07, Swati Agarwal wrote:
> > https://lore.kernel.org/all/20260121022449.GA1804139-robh@kernel.org/#t
>
> Exactly this comment is not implemented. v5 repeated it. I repeated now.
Hi Krysztof,
Are you trying to say, i should mark vdd12-supply false wherever
applicable but dont mark it as true and it should be by default
considered as true? Correct me if my understanding is wrong.

Regards,
Swati