.../bindings/usb/genesys,gl850g.yaml | 16 ++ arch/arm64/boot/dts/qcom/lemans-evk.dts | 216 +++++++++++++++++- drivers/usb/misc/onboard_usb_dev.c | 1 + drivers/usb/misc/onboard_usb_dev.h | 8 + 4 files changed, 237 insertions(+), 4 deletions(-)
Enable secondary USB controller in host mode.
This patch depends on:
https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/
Changes in v6:
- Removed vdd12-supply property status for all hubs.
- Added connections between genesys hub, HD3 port controller and type-C
connector as follows.
GL3590 USB HD3SS3220 Type‑C USB TYPE‑C
HUB Port Controller Connector
HS HUB HS con
|------------------------------------|
SS HUB HD3-out SBU con
|--------------------|
HD3-in SS con
|---------------------|
Changes in v5:
Updated comment description in DT.
Updated vdd-supply status for other hubs in bindings.
Changes in v4:
Updated power supply property for hub.
Updated details for all 4 ports of hub.
Changes in v3:
Updated binding properties for genesys hub.
Changes in v2:
Add Genesys Logic GL3590 hub support.
Rename hd3ss3220_ instance for primary port controller.
Link to v5:
https://lore.kernel.org/all/20260122092852.887624-1-swati.agarwal@oss.qualcomm.com/
Link to v4:
https://lore.kernel.org/all/20260120103312.2174727-1-swati.agarwal@oss.qualcomm.com/
Link to v3:
https://lore.kernel.org/all/20251220063537.3639535-1-swati.agarwal@oss.qualcomm.com/
Link to v2:
https://lore.kernel.org/all/20251216120749.94007-1-swati.agarwal@oss.qualcomm.com/
Link to v1:
https://lore.kernel.org/all/20251203-swati-v1-1-250efcb4e6a7@oss.qualcomm.com/
Swati Agarwal (4):
dt-bindings: usb: Add binding for Genesys Logic GL3590 hub
usb: misc: onboard_usb_hub: Add Genesys Logic GL3590 hub support
arm64: dts: qcom: lemans-evk: Rename hd3ss3220_ instance for primary
port controller
arm64: dts: qcom: lemans-evk: Enable secondary USB controller in host
mode
.../bindings/usb/genesys,gl850g.yaml | 16 ++
arch/arm64/boot/dts/qcom/lemans-evk.dts | 216 +++++++++++++++++-
drivers/usb/misc/onboard_usb_dev.c | 1 +
drivers/usb/misc/onboard_usb_dev.h | 8 +
4 files changed, 237 insertions(+), 4 deletions(-)
--
2.34.1
On Wed, Mar 18, 2026 at 09:36:40AM +0530, Swati Agarwal wrote: > Enable secondary USB controller in host mode. > > This patch depends on: > https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ Honestly? No. Drivers cannot depend on DTS. Also, combining here USB is a no-go. Do not combine independent patchsets into one patchset. I also do not see how you addressed my comments from previous version. You never bothered to respond and I do not see them implemented. Best regards, Krzysztof
On Wed, Mar 18, 2026 at 12:33 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Wed, Mar 18, 2026 at 09:36:40AM +0530, Swati Agarwal wrote: > > Enable secondary USB controller in host mode. > > > > This patch depends on: > > https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ > > Honestly? No. Drivers cannot depend on DTS. Hi Krysztof, Here what i meant by dependency is that I have rebase this patch series over below patch series. Below patch series is related to USB2 micro USB controller support on lemans EVK. https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ There is no dependency of drivers on DT. > > Also, combining here USB is a no-go. Do not combine independent > patchsets into one patchset. > > I also do not see how you addressed my comments from previous version. > You never bothered to respond and I do not see them implemented. Apologies if i missed replying any comments. Regarding your comment on v3 series below:- GL3590 hub used in lemans EVK requires only 1.2V and 3.3V supplies for operation, confirmes the same from our internal HW team and update the same in thereafter patch sets. https://lore.kernel.org/all/20251220-economic-gay-firefly-1873a9@quoll/ Regards, Swati
On 23/03/2026 08:36, Swati Agarwal wrote: > On Wed, Mar 18, 2026 at 12:33 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On Wed, Mar 18, 2026 at 09:36:40AM +0530, Swati Agarwal wrote: >>> Enable secondary USB controller in host mode. >>> >>> This patch depends on: >>> https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ >> >> Honestly? No. Drivers cannot depend on DTS. > Hi Krysztof, > > Here what i meant by dependency is that I have rebase this patch > series over below patch series. Below patch series is related to USB2 And you should not. Drivers cannot be based on DTS branch. > micro USB controller support on lemans EVK. > https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ > > There is no dependency of drivers on DT. > >> >> Also, combining here USB is a no-go. Do not combine independent >> patchsets into one patchset. >> >> I also do not see how you addressed my comments from previous version. >> You never bothered to respond and I do not see them implemented. > > Apologies if i missed replying any comments. > Regarding your comment on v3 series below:- GL3590 hub used in lemans > EVK requires only 1.2V and 3.3V supplies for operation, confirmes the > same from our internal HW team and update the same in thereafter patch > sets. > https://lore.kernel.org/all/20251220-economic-gay-firefly-1873a9@quoll/ This does not address the feedback. I did not talk about Lemans EVK. I don't even have its datasheet. We speak here about GL3590. I found at least three supplies in datasheet. Your binding has only two. Best regards, Krzysztof
On Mon, Mar 23, 2026 at 1:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 23/03/2026 08:36, Swati Agarwal wrote: > > On Wed, Mar 18, 2026 at 12:33 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On Wed, Mar 18, 2026 at 09:36:40AM +0530, Swati Agarwal wrote: > >>> Enable secondary USB controller in host mode. > >>> > >>> This patch depends on: > >>> https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ > >> > >> Honestly? No. Drivers cannot depend on DTS. > > Hi Krysztof, > > > > Here what i meant by dependency is that I have rebase this patch > > series over below patch series. Below patch series is related to USB2 > > And you should not. Drivers cannot be based on DTS branch. > > > micro USB controller support on lemans EVK. > > https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ > > > > There is no dependency of drivers on DT. Hi Krysztof, Sure, i will send a separate series for driver and DT. Regards, Swati > > > >> > >> Also, combining here USB is a no-go. Do not combine independent > >> patchsets into one patchset. > >> > >> I also do not see how you addressed my comments from previous version. > >> You never bothered to respond and I do not see them implemented. > > > > Apologies if i missed replying any comments. > > Regarding your comment on v3 series below:- GL3590 hub used in lemans > > EVK requires only 1.2V and 3.3V supplies for operation, confirmes the > > same from our internal HW team and update the same in thereafter patch > > sets. > > https://lore.kernel.org/all/20251220-economic-gay-firefly-1873a9@quoll/ > > This does not address the feedback. I did not talk about Lemans EVK. I > don't even have its datasheet. We speak here about GL3590. I found at > least three supplies in datasheet. Your binding has only two. > > Best regards, > Krzysztof
On Mon, Mar 23, 2026 at 1:12 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 23/03/2026 08:36, Swati Agarwal wrote: > > On Wed, Mar 18, 2026 at 12:33 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On Wed, Mar 18, 2026 at 09:36:40AM +0530, Swati Agarwal wrote: > >>> Enable secondary USB controller in host mode. > >>> > >>> This patch depends on: > >>> https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ > >> > >> Honestly? No. Drivers cannot depend on DTS. > > Hi Krysztof, > > > > Here what i meant by dependency is that I have rebase this patch > > series over below patch series. Below patch series is related to USB2 > > And you should not. Drivers cannot be based on DTS branch. > > > micro USB controller support on lemans EVK. > > https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ > > > > There is no dependency of drivers on DT. > > > >> > >> Also, combining here USB is a no-go. Do not combine independent > >> patchsets into one patchset. > >> > >> I also do not see how you addressed my comments from previous version. > >> You never bothered to respond and I do not see them implemented. > > > > Apologies if i missed replying any comments. > > Regarding your comment on v3 series below:- GL3590 hub used in lemans > > EVK requires only 1.2V and 3.3V supplies for operation, confirmes the > > same from our internal HW team and update the same in thereafter patch > > sets. > > https://lore.kernel.org/all/20251220-economic-gay-firefly-1873a9@quoll/ > > This does not address the feedback. I did not talk about Lemans EVK. I > don't even have its datasheet. We speak here about GL3590. I found at > least three supplies in datasheet. Your binding has only two. Hi Krysztof, For HUB GL3590, there are three supplies which are VP10, VP33 and VP12. I have already used VP12 and VP33 in bindings. VP10 i have not mentioned since its internal supply and other two are external supplies to hub. VP10 is internal regulator and its pins just loop back. Regarding AVDD10 and AVDD33, so AVDD10 is internal power hub which is routed to several pins for different functions such as the PLL and AVDD33 is external power hub where the external 3.3V gets connected for multiple devices. Regards, Swati
On 26/03/2026 08:04, Swati Agarwal wrote: >>> micro USB controller support on lemans EVK. >>> https://lore.kernel.org/all/20260306091355.1178333-1-swati.agarwal@oss.qualcomm.com/ >>> >>> There is no dependency of drivers on DT. >>> >>>> >>>> Also, combining here USB is a no-go. Do not combine independent >>>> patchsets into one patchset. >>>> >>>> I also do not see how you addressed my comments from previous version. >>>> You never bothered to respond and I do not see them implemented. >>> >>> Apologies if i missed replying any comments. >>> Regarding your comment on v3 series below:- GL3590 hub used in lemans >>> EVK requires only 1.2V and 3.3V supplies for operation, confirmes the >>> same from our internal HW team and update the same in thereafter patch >>> sets. >>> https://lore.kernel.org/all/20251220-economic-gay-firefly-1873a9@quoll/ >> >> This does not address the feedback. I did not talk about Lemans EVK. I >> don't even have its datasheet. We speak here about GL3590. I found at >> least three supplies in datasheet. Your binding has only two. > > Hi Krysztof, > For HUB GL3590, there are three supplies which are VP10, VP33 and > VP12. I have already used VP12 and VP33 in bindings. VP10 i have not > mentioned since its internal supply and other two are external > supplies to hub. VP10 is internal regulator and its pins just loop > back. Regarding AVDD10 and AVDD33, so AVDD10 is internal power hub > which is routed to several pins for different functions such as the > PLL and AVDD33 is external power hub where the external 3.3V gets > connected for multiple devices. OK, I understand. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.