[PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943

Dawei Liu posted 3 patches 2 weeks, 5 days ago
There is a newer version of this series
[PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943
Posted by Dawei Liu 2 weeks, 5 days ago
Both RAA228942 and RAA228943 are digital dual-output 16-Phase
(X+Y <= 16) PWM controllers. They are PMBus command compatible
with the RAA228228/RAA228244/RAA228246 family and use the same
2-rail non-TC driver configuration.

Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
---
 Documentation/hwmon/isl68137.rst | 20 ++++++++++++++++++++
 drivers/hwmon/pmbus/isl68137.c   |  4 ++++
 2 files changed, 24 insertions(+)

diff --git a/Documentation/hwmon/isl68137.rst b/Documentation/hwmon/isl68137.rst
index e77f582c2..0ce20d091 100644
--- a/Documentation/hwmon/isl68137.rst
+++ b/Documentation/hwmon/isl68137.rst
@@ -394,6 +394,26 @@ Supported chips:
 
       Provided by Renesas upon request and NDA
 
+  * Renesas RAA228942
+
+    Prefix: 'raa228942'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Provided by Renesas upon request and NDA
+
+  * Renesas RAA228943
+
+    Prefix: 'raa228943'
+
+    Addresses scanned: -
+
+    Datasheet:
+
+      Provided by Renesas upon request and NDA
+
   * Renesas RAA229001
 
     Prefix: 'raa229001'
diff --git a/drivers/hwmon/pmbus/isl68137.c b/drivers/hwmon/pmbus/isl68137.c
index 3346afdf3..e9bb24a2a 100644
--- a/drivers/hwmon/pmbus/isl68137.c
+++ b/drivers/hwmon/pmbus/isl68137.c
@@ -432,6 +432,8 @@ static const struct i2c_device_id raa_dmpvr_id[] = {
 	{"raa228228", raa_dmpvr2_2rail_nontc},
 	{"raa228244", raa_dmpvr2_2rail_nontc},
 	{"raa228246", raa_dmpvr2_2rail_nontc},
+	{"raa228942", raa_dmpvr2_2rail_nontc},
+	{"raa228943", raa_dmpvr2_2rail_nontc},
 	{"raa229001", raa_dmpvr2_2rail},
 	{"raa229004", raa_dmpvr2_2rail},
 	{"raa229141", raa_dmpvr2_2rail_pmbus},
@@ -483,6 +485,8 @@ static const struct of_device_id isl68137_of_match[] = {
 	{ .compatible = "renesas,raa228228", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228244", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa228246", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228942", .data = (void *)raa_dmpvr2_2rail_nontc },
+	{ .compatible = "renesas,raa228943", .data = (void *)raa_dmpvr2_2rail_nontc },
 	{ .compatible = "renesas,raa229001", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229004", .data = (void *)raa_dmpvr2_2rail },
 	{ .compatible = "renesas,raa229621", .data = (void *)raa_dmpvr2_2rail },
-- 
2.34.1
Re: [PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943
Posted by Guenter Roeck 2 weeks, 5 days ago
On 3/17/26 19:19, Dawei Liu wrote:
> Both RAA228942 and RAA228943 are digital dual-output 16-Phase
> (X+Y <= 16) PWM controllers. They are PMBus command compatible
> with the RAA228228/RAA228244/RAA228246 family and use the same
> 2-rail non-TC driver configuration.
> 
> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>

For my reference:

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

Note that technically the devicetree patch should come first,
and I can not apply this and the next patch because you dropped
Krzysztof's Acked-by: tag from that patch.

Guenter
Re: [PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943
Posted by Krzysztof Kozlowski 2 weeks, 5 days ago
On Tue, Mar 17, 2026 at 10:23:57PM -0700, Guenter Roeck wrote:
> On 3/17/26 19:19, Dawei Liu wrote:
> > Both RAA228942 and RAA228943 are digital dual-output 16-Phase
> > (X+Y <= 16) PWM controllers. They are PMBus command compatible
> > with the RAA228228/RAA228244/RAA228246 family and use the same
> > 2-rail non-TC driver configuration.
> > 
> > Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
> 
> For my reference:
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> Note that technically the devicetree patch should come first,
> and I can not apply this and the next patch because you dropped
> Krzysztof's Acked-by: tag from that patch.

Was there an Ack? I see only one reply from me, but maybe something is
lost because entire posting is completely mixed up (v2 being part of v1)
so it all appears mixed in my inbox.

Best regards,
Krzysztof
Re: [PATCH v2 2/3] hwmon: (pmbus/isl68137) Add support for Renesas RAA228942 and RAA228943
Posted by Guenter Roeck 2 weeks, 5 days ago
On 3/18/26 01:25, Krzysztof Kozlowski wrote:
> On Tue, Mar 17, 2026 at 10:23:57PM -0700, Guenter Roeck wrote:
>> On 3/17/26 19:19, Dawei Liu wrote:
>>> Both RAA228942 and RAA228943 are digital dual-output 16-Phase
>>> (X+Y <= 16) PWM controllers. They are PMBus command compatible
>>> with the RAA228228/RAA228244/RAA228246 family and use the same
>>> 2-rail non-TC driver configuration.
>>>
>>> Signed-off-by: Dawei Liu <dawei.liu.jy@renesas.com>
>>
>> For my reference:
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Note that technically the devicetree patch should come first,
>> and I can not apply this and the next patch because you dropped
>> Krzysztof's Acked-by: tag from that patch.
> 
> Was there an Ack? I see only one reply from me, but maybe something is
> lost because entire posting is completely mixed up (v2 being part of v1)
> so it all appears mixed in my inbox.
> 

My sincere apologies. No, there wasn't. Not a good excuse, but I got confused
with another submission.

Sorry for that.

Guenter