[PATCH net-next v4 00/13] macb usrio/tsu patches

Conor Dooley posted 13 patches 2 weeks, 4 days ago
There is a newer version of this series
.../devicetree/bindings/net/cdns,macb.yaml    |  71 +++++-
drivers/net/ethernet/cadence/macb.h           |   8 +
drivers/net/ethernet/cadence/macb_main.c      | 202 ++++++++++++------
3 files changed, 211 insertions(+), 70 deletions(-)
[PATCH net-next v4 00/13] macb usrio/tsu patches
Posted by Conor Dooley 2 weeks, 4 days ago
From: Conor Dooley <conor.dooley@microchip.com>

Hey folks,

At the very least, it'd be good of the soc vendor folks could check
their platforms and see if their usrio stuff actually lines up with what
the driver currently calls "macb_default_usrio". Ours didn't and it was
a nasty surprise.

Ryan and I figured out that the sama7g5 stuff is not actually using the
same usrio bits as earlier devices, so there's now more patches in this
series to split them apart. I've not tested the split or the new
property due to lack of hardware, but Ryan has.

Marking this stuff net-next, because although they're fixes I don't see
any particular urgency, and it avoids creating some dependencies between
cleanup items and the fixes.

Cheers,
Conor.

v4:
- deprecate instead of remove existing devicetree property
- pick up Theo's patches

v3:
- reorder patches
- fix smatch issue reported by Simon
- add patches reworking usrio handling of clken/refclk (and remove the
  issue the llm reported in the process)
- add a new devicetree property for refclk selection, replacing the
  existing one.
- drop the dts patch

CC: Valentina.FernandezAlanis@microchip.com
CC: Andrew Lunn <andrew+netdev@lunn.ch>
CC: David S. Miller <davem@davemloft.net>
CC: Eric Dumazet <edumazet@google.com>
CC: Jakub Kicinski <kuba@kernel.org>
CC: Paolo Abeni <pabeni@redhat.com>
CC: Rob Herring <robh@kernel.org>
CC: Krzysztof Kozlowski <krzk+dt@kernel.org>
CC: Conor Dooley <conor+dt@kernel.org>
CC: Daire McNamara <daire.mcnamara@microchip.com>
CC: Paul Walmsley <pjw@kernel.org>
CC: Palmer Dabbelt <palmer@dabbelt.com>
CC: Albert Ou <aou@eecs.berkeley.edu>
CC: Alexandre Ghiti <alex@ghiti.fr>
CC: Nicolas Ferre <nicolas.ferre@microchip.com>
CC: Claudiu Beznea <claudiu.beznea@tuxon.dev>
CC: Richard Cochran <richardcochran@gmail.com>
CC: Samuel Holland <samuel.holland@sifive.com>
CC: netdev@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: linux-riscv@lists.infradead.org
CC: Dave Stevenson <dave.stevenson@raspberrypi.com>
CC: Sean Anderson <sean.anderson@linux.dev>
CC: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
CC: Abin Joseph <abin.joseph@amd.com>
CC: Théo Lebrun <theo.lebrun@bootlin.com>
CC: Ryan.Wanner@microchip.com

Conor Dooley (10):
  net: macb: rename macb_default_usrio to at91_default_usrio as not all
    platforms have mii mode control in usrio
  net: macb: split USRIO_HAS_CLKEN capability in two
  dt-bindings: net: cdns,macb: replace cdns,refclk-ext with
    cdns,refclk-source
  net: macb: rework usrio refclk selection code
  net: macb: np4 doesn't need a usrio pointer
  net: macb: add mpfs specific usrio configuration
  net: macb: warn on pclk use as a tsu_clk fallback
  net: macb: clean up tsu clk rate acquisition
  dt-bindings: net: macb: add property indicating timer adjust mode
  net: macb: timer adjust mode is not supported

Théo Lebrun (3):
  net: macb: runtime detect MACB_CAPS_USRIO_DISABLED
  net: macb: set MACB_CAPS_USRIO_DISABLED if no usrio config is provided
  net: macb: drop usrio pointer on EyeQ5 config

 .../devicetree/bindings/net/cdns,macb.yaml    |  71 +++++-
 drivers/net/ethernet/cadence/macb.h           |   8 +
 drivers/net/ethernet/cadence/macb_main.c      | 202 ++++++++++++------
 3 files changed, 211 insertions(+), 70 deletions(-)

-- 
2.51.0

Re: [PATCH net-next v4 00/13] macb usrio/tsu patches
Posted by Simon Horman 2 weeks, 3 days ago
On Wed, Mar 18, 2026 at 04:37:31PM +0000, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Hey folks,
> 
> At the very least, it'd be good of the soc vendor folks could check
> their platforms and see if their usrio stuff actually lines up with what
> the driver currently calls "macb_default_usrio". Ours didn't and it was
> a nasty surprise.
> 
> Ryan and I figured out that the sama7g5 stuff is not actually using the
> same usrio bits as earlier devices, so there's now more patches in this
> series to split them apart. I've not tested the split or the new
> property due to lack of hardware, but Ryan has.
> 
> Marking this stuff net-next, because although they're fixes I don't see
> any particular urgency, and it avoids creating some dependencies between
> cleanup items and the fixes.
> 
> Cheers,
> Conor.
> 
> v4:
> - deprecate instead of remove existing devicetree property
> - pick up Theo's patches
> 
> v3:
> - reorder patches
> - fix smatch issue reported by Simon
> - add patches reworking usrio handling of clken/refclk (and remove the
>   issue the llm reported in the process)
> - add a new devicetree property for refclk selection, replacing the
>   existing one.
> - drop the dts patch

Hi Conor,

Unfortunately this does not apply cleanly to net-next, which breaks our CI.

Please rebase and repost.

Thanks!

-- 
pw-bot: changes-requested