1. Patchew
  2. linux
  3. [PATCH v2 0/6] Enable new features for flipkart-rimob
  4. View patch

[PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI

Cristian Cozzolino via B4 Relay posted 6 patches 2 weeks, 4 days ago
There is a newer version of this series
[PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Posted by Cristian Cozzolino via B4 Relay 2 weeks, 4 days ago 
From: Cristian Cozzolino <cristian_ci@protonmail.com>

Document Novatek NT35532-based DSI display panel.

Signed-off-by: Cristian Cozzolino <cristian_ci@protonmail.com>
---
 .../bindings/display/panel/novatek,nt35532.yaml    | 80 ++++++++++++++++++++++
 MAINTAINERS                                        |  5 ++
 2 files changed, 85 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt35532.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt35532.yaml
new file mode 100644
index 000000000000..c7491a93b5cd
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt35532.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/novatek,nt35532.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Novatek NT35532-based DSI display panels
+
+maintainers:
+  - Cristian Cozzolino <cristian_ci@protonmail.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: novatek,nt35532
+
+  reg:
+    maxItems: 1
+
+  backlight: true
+  reset-gpios: true
+
+  avdd-supply:
+    description: positive boost supply regulator
+
+  avee-supply:
+    description: negative boost supply regulator
+
+  vci-supply:
+    description: regulator that supplies the analog voltage
+
+  vddam-supply:
+    description: power supply for MIPI interface
+
+  vddi-supply:
+    description: regulator that supplies the I/O voltage
+
+  port: true
+
+required:
+  - compatible
+  - reg
+  - reset-gpios
+  - avdd-supply
+  - avee-supply
+  - vci-supply
+  - vddi-supply
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        panel@0 {
+            compatible = "novatek,nt35532";
+            reg = <0>;
+
+            backlight = <&pmi8950_wled>;
+            reset-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
+            avdd-supply = <&lab>;
+            avee-supply = <&ibb>;
+            vci-supply = <&pm8953_l17>;
+            vddi-supply = <&pm8953_l6>;
+
+            port {
+                panel_in: endpoint {
+                    remote-endpoint = <&dsi0_out>;
+                };
+            };
+        };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 8d768ddae117..8afb94532a89 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8168,6 +8168,11 @@ T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	Documentation/devicetree/bindings/display/panel/novatek,nt35510.yaml
 F:	drivers/gpu/drm/panel/panel-novatek-nt35510.c
 
+DRM DRIVER FOR NOVATEK NT35532 PANELS
+M:	Cristian Cozzolino <cristian_ci@protonmail.com>
+S:	Maintained
+F:	Documentation/devicetree/bindings/display/panel/novatek,nt35532.yaml
+
 DRM DRIVER FOR NOVATEK NT35560 PANELS
 M:	Linus Walleij <linusw@kernel.org>
 S:	Maintained

-- 
2.53.0
Re: [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Posted by Krzysztof Kozlowski 2 weeks, 4 days ago 
On Wed, Mar 18, 2026 at 11:28:09PM +0100, Cristian Cozzolino wrote:
> +  avdd-supply:
> +    description: positive boost supply regulator
> +
> +  avee-supply:
> +    description: negative boost supply regulator
> +
> +  vci-supply:
> +    description: regulator that supplies the analog voltage
> +
> +  vddam-supply:
> +    description: power supply for MIPI interface
> +
> +  vddi-supply:
> +    description: regulator that supplies the I/O voltage
> +
> +  port: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - avdd-supply
> +  - avee-supply
> +  - vci-supply

Only VDDI is required according to datasheet (see page 11 and page 16).
Others are needed only in specific configurations, which I would ignore
for the simplicity of the binding. Drop these three.

Previous discussion point was about this - write bindings based on
datasheet, since it is available.


> +  - vddi-supply
> +  - port
> +
> +additionalProperties: false

Best regards,
Krzysztof
Re: [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Posted by cristian_ci 2 weeks, 2 days ago 
On Thursday, March 19th, 2026 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Wed, Mar 18, 2026 at 11:28:09PM +0100, Cristian Cozzolino wrote:
> > +  avdd-supply:
> > +    description: positive boost supply regulator
> > +
> > +  avee-supply:
> > +    description: negative boost supply regulator
> > +
> > +  vci-supply:
> > +    description: regulator that supplies the analog voltage
> > +
> > +  vddam-supply:
> > +    description: power supply for MIPI interface
> > +
> > +  vddi-supply:
> > +    description: regulator that supplies the I/O voltage
> > +
> > +  port: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reset-gpios
> > +  - avdd-supply
> > +  - avee-supply
> > +  - vci-supply
> 
> Only VDDI is required according to datasheet (see page 11 and page 16).

Just to be sure, are you mentioning the part saying there are multiple 
power modes (2-1PWR, 2-2PWR, 3éWR and 4PWR) related to NT35532? 

> Others are needed only in specific configurations, which I would ignore
> for the simplicity of the binding. Drop these three.
> 
> Previous discussion point was about this - write bindings based on
> datasheet, since it is available.

I've removed avdd, avee and vci supplies from 'required' properties 
and I've also tested the new bindings (just for completeness). Now, 
I'm going to reintroduce again the issue already raised previously 
(for which I received no replies in v1): should I submit a v3 
series including my new changes or I've to stick with v2 here, in 
order to address review concerns about binding, first?

> > +  - vddi-supply
> > +  - port
> > +
> > +additionalProperties: false
> 
> Best regards,
> Krzysztof
> 
>
Re: [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Posted by Krzysztof Kozlowski 2 weeks, 2 days ago 
On 20/03/2026 23:32, cristian_ci wrote:
> On Thursday, March 19th, 2026 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> 
>> On Wed, Mar 18, 2026 at 11:28:09PM +0100, Cristian Cozzolino wrote:
>>> +  avdd-supply:
>>> +    description: positive boost supply regulator
>>> +
>>> +  avee-supply:
>>> +    description: negative boost supply regulator
>>> +
>>> +  vci-supply:
>>> +    description: regulator that supplies the analog voltage
>>> +
>>> +  vddam-supply:
>>> +    description: power supply for MIPI interface
>>> +
>>> +  vddi-supply:
>>> +    description: regulator that supplies the I/O voltage
>>> +
>>> +  port: true
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - reset-gpios
>>> +  - avdd-supply
>>> +  - avee-supply
>>> +  - vci-supply
>>
>> Only VDDI is required according to datasheet (see page 11 and page 16).
> 
> Just to be sure, are you mentioning the part saying there are multiple 
> power modes (2-1PWR, 2-2PWR, 3éWR and 4PWR) related to NT35532? 
> 
>> Others are needed only in specific configurations, which I would ignore
>> for the simplicity of the binding. Drop these three.
>>
>> Previous discussion point was about this - write bindings based on
>> datasheet, since it is available.
> 
> I've removed avdd, avee and vci supplies from 'required' properties 
> and I've also tested the new bindings (just for completeness). Now, 
> I'm going to reintroduce again the issue already raised previously 
> (for which I received no replies in v1): should I submit a v3 
> series including my new changes or I've to stick with v2 here, in 
> order to address review concerns about binding, first?
> 

I don't understand the question. This is v2, right? So I asked to make
changes to it, thus you should submit v3 after receiving some more
review for example.

Best regards,
Krzysztof
Re: [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Posted by cristian_ci 2 weeks, 1 day ago 
On Saturday, March 21st, 2026 at 10:56, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On 20/03/2026 23:32, cristian_ci wrote:
> > On Thursday, March 19th, 2026 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> >> On Wed, Mar 18, 2026 at 11:28:09PM +0100, Cristian Cozzolino wrote:
> >>> +  avdd-supply:
> >>> +    description: positive boost supply regulator
> >>> +
> >>> +  avee-supply:
> >>> +    description: negative boost supply regulator
> >>> +
> >>> +  vci-supply:
> >>> +    description: regulator that supplies the analog voltage
> >>> +
> >>> +  vddam-supply:
> >>> +    description: power supply for MIPI interface
> >>> +
> >>> +  vddi-supply:
> >>> +    description: regulator that supplies the I/O voltage
> >>> +
> >>> +  port: true
> >>> +
> >>> +required:
> >>> +  - compatible
> >>> +  - reg
> >>> +  - reset-gpios
> >>> +  - avdd-supply
> >>> +  - avee-supply
> >>> +  - vci-supply
> >>
> >> Only VDDI is required according to datasheet (see page 11 and page 16).
> >
> > Just to be sure, are you mentioning the part saying there are multiple
> > power modes (2-1PWR, 2-2PWR, 3éWR and 4PWR) related to NT35532?
> >
> >> Others are needed only in specific configurations, which I would ignore
> >> for the simplicity of the binding. Drop these three.
> >>
> >> Previous discussion point was about this - write bindings based on
> >> datasheet, since it is available.
> >
> > I've removed avdd, avee and vci supplies from 'required' properties
> > and I've also tested the new bindings (just for completeness). Now,
> > I'm going to reintroduce again the issue already raised previously
> > (for which I received no replies in v1): should I submit a v3
> > series including my new changes or I've to stick with v2 here, in
> > order to address review concerns about binding, first?
> >
> 
> I don't understand the question. This is v2, right? So I asked to make
> changes to it, thus you should submit v3 after receiving some more
> review for example.

I've submitted v3 of patch series considering that, apart dt-bindings, I 
think I've addressed reviews for the rest of patches, during these last 
days.

> Best regards,
> Krzysztof
>

Patchew 2.1-devel-ea86937

© 2016 - 2026 Red Hat, Inc.