[PATCH 8/8] mm/vmscan: remove sc->file_taken

Kairui Song via B4 Relay posted 8 patches 2 weeks, 6 days ago
There is a newer version of this series
[PATCH 8/8] mm/vmscan: remove sc->file_taken
Posted by Kairui Song via B4 Relay 2 weeks, 6 days ago
From: Kairui Song <kasong@tencent.com>

No one is using it now, just remove it.

Signed-off-by: Kairui Song <kasong@tencent.com>
---
 mm/vmscan.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index e11d0f1a8b68..b95c9fc17edf 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -174,7 +174,6 @@ struct scan_control {
 		unsigned int congested;
 		unsigned int writeback;
 		unsigned int immediate;
-		unsigned int file_taken;
 		unsigned int taken;
 	} nr;
 
@@ -2041,8 +2040,6 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan,
 	sc->nr.writeback += stat.nr_writeback;
 	sc->nr.immediate += stat.nr_immediate;
 	sc->nr.taken += nr_taken;
-	if (file)
-		sc->nr.file_taken += nr_taken;
 
 	trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id,
 			nr_scanned, nr_reclaimed, &stat, sc->priority, file);

-- 
2.53.0
Re: [PATCH 8/8] mm/vmscan: remove sc->file_taken
Posted by Axel Rasmussen 2 weeks, 3 days ago
On Tue, Mar 17, 2026 at 12:11 PM Kairui Song via B4 Relay
<devnull+kasong.tencent.com@kernel.org> wrote:
>
> From: Kairui Song <kasong@tencent.com>
>
> No one is using it now, just remove it.
>
> Signed-off-by: Kairui Song <kasong@tencent.com>

Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>

> ---
>  mm/vmscan.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index e11d0f1a8b68..b95c9fc17edf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -174,7 +174,6 @@ struct scan_control {
>                 unsigned int congested;
>                 unsigned int writeback;
>                 unsigned int immediate;
> -               unsigned int file_taken;
>                 unsigned int taken;
>         } nr;
>
> @@ -2041,8 +2040,6 @@ static unsigned long shrink_inactive_list(unsigned long nr_to_scan,
>         sc->nr.writeback += stat.nr_writeback;
>         sc->nr.immediate += stat.nr_immediate;
>         sc->nr.taken += nr_taken;
> -       if (file)
> -               sc->nr.file_taken += nr_taken;
>
>         trace_mm_vmscan_lru_shrink_inactive(pgdat->node_id,
>                         nr_scanned, nr_reclaimed, &stat, sc->priority, file);
>
> --
> 2.53.0
>
>