staging: rtl8723bs: collapse duplicate goto exit conditions

[PATCH] staging: rtl8723bs: collapse duplicate goto exit conditions

Posted by Marco Antonio Solis Segura 2 weeks, 6 days ago

Combine _FAIL and RTW_RX_HANDLED cases into a single conditional,
removing redundant branches and simplifying control flow.
No functional changes intended.

Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 337671b1211f..20f5f8760ba0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1339,12 +1339,8 @@ static signed int validate_recv_data_frame(struct adapter *adapter, union recv_f
 
 	}
 
-	if (ret == _FAIL) {
+	if (ret == _FAIL || ret == RTW_RX_HANDLED)
 		goto exit;
-	} else if (ret == RTW_RX_HANDLED) {
-		goto exit;
-	}
-
 
 	if (!psta) {
 		ret = _FAIL;
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: collapse duplicate goto exit conditions

Posted by Greg KH 2 weeks, 5 days ago

On Tue, Mar 17, 2026 at 07:55:48AM -0600, Marco Antonio Solis Segura wrote:
> Combine _FAIL and RTW_RX_HANDLED cases into a single conditional,
> removing redundant branches and simplifying control flow.
> No functional changes intended.
> 
> Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 337671b1211f..20f5f8760ba0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1339,12 +1339,8 @@ static signed int validate_recv_data_frame(struct adapter *adapter, union recv_f
>  
>  	}
>  
> -	if (ret == _FAIL) {
> +	if (ret == _FAIL || ret == RTW_RX_HANDLED)
>  		goto exit;
> -	} else if (ret == RTW_RX_HANDLED) {
> -		goto exit;
> -	}
> -
>  
>  	if (!psta) {
>  		ret = _FAIL;
> -- 
> 2.53.0
> 
> 

Someone sent this _right_ before you did:
	https://lore.kernel.org/r/20260317100723.72476-1-giacomodiclerico@gmail.com

Are you all working on this together?  What project is asking you to
send patches for this driver?

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: collapse duplicate goto exit conditions

Posted by Marco Solis 2 weeks, 4 days ago

On Wed, Mar 18, 2026 at 9:54 AM Greg KH <gregkh@linuxfoundation.org> wrote:

> Someone sent this _right_ before you did:
>         https://lore.kernel.org/r/20260317100723.72476-1-giacomodiclerico@gmail.com
>
> Are you all working on this together?  What project is asking you to
> send patches for this driver?
>
> thanks,
>
> greg k-h

Hi Greg,

No, I am not working with Giacomo or part of any organized project.
I'm an independent developer working on my own to improve my systems
engineering skills and contribute to the kernel.

Since Giacomo's patch was sent first, please feel free to drop mine.
I'll focus on fixing some checkpatch.pl false positives as Dan
Carpenter suggested in another thread.

Thanks for your time,

Marco Solis