The Arm Live Firmware Activation spec describes an asynchronous
notification mechanism, where the platform can notify the host OS about
newly pending image updates.
In the absence of the ACPI notification mechanism also a simple
devicetree node can describe an interrupt.
Add code to find the respective DT node and register the specified
interrupt, to trigger the activation if needed.
Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
drivers/firmware/smccc/lfa_fw.c | 45 +++++++++++++++++++++++++++++++++
1 file changed, 45 insertions(+)
diff --git a/drivers/firmware/smccc/lfa_fw.c b/drivers/firmware/smccc/lfa_fw.c
index 5dc531e462eb..ecd056901b8d 100644
--- a/drivers/firmware/smccc/lfa_fw.c
+++ b/drivers/firmware/smccc/lfa_fw.c
@@ -16,6 +16,8 @@
#include <linux/list.h>
#include <linux/module.h>
#include <linux/nmi.h>
+#include <linux/of.h>
+#include <linux/of_irq.h>
#include <linux/psci.h>
#include <linux/stop_machine.h>
#include <linux/string.h>
@@ -841,6 +843,43 @@ static void lfa_remove_acpi(struct device *dev)
}
#endif
+static irqreturn_t lfa_irq_handler(int irq, void *dev_id)
+{
+ return IRQ_WAKE_THREAD;
+}
+
+static irqreturn_t lfa_irq_handler_thread(int irq, void *dev_id)
+{
+ int ret;
+
+ while (!(ret = activate_pending_image()))
+ ;
+
+ if (ret != -ENOENT)
+ pr_warn("notified image activation failed: %d\n", ret);
+
+ return IRQ_HANDLED;
+}
+
+static int lfa_register_dt(struct device *dev)
+{
+ struct device_node *np;
+ unsigned int irq;
+
+ np = of_find_compatible_node(NULL, NULL, "arm,lfa");
+ if (!np)
+ return -ENODEV;
+
+ irq = irq_of_parse_and_map(np, 0);
+ of_node_put(np);
+ if (!irq)
+ return -ENODEV;
+
+ return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
+ lfa_irq_handler_thread,
+ IRQF_COND_ONESHOT, NULL, NULL);
+}
+
static int lfa_faux_probe(struct faux_device *fdev)
{
int ret;
@@ -854,6 +893,12 @@ static int lfa_faux_probe(struct faux_device *fdev)
}
}
+ ret = lfa_register_dt(&fdev->dev);
+ if (!ret)
+ pr_info("registered LFA DT notification interrupt\n");
+ if (ret != -ENODEV)
+ return ret;
+
return 0;
}
--
2.43.0Hi Andre,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next rockchip/for-next shawnguo/for-next soc/for-next linus/master nferre-at91/at91-next v7.0-rc4 next-20260317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andre-Przywara/dt-bindings-arm-Add-Live-Firmware-Activation-binding/20260318-082717
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20260317103336.1273582-8-andre.przywara%40arm.com
patch subject: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt
config: arm64-randconfig-003-20260318 (https://download.01.org/0day-ci/archive/20260318/202603182205.TOBMcP5F-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 4abb927bacf37f18f6359a41639a6d1b3bffffb5)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603182205.TOBMcP5F-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603182205.TOBMcP5F-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/firmware/smccc/lfa_fw.c:878:9: error: call to undeclared function 'devm_request_threaded_irq'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
878 | return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
| ^
>> drivers/firmware/smccc/lfa_fw.c:880:7: error: use of undeclared identifier 'IRQF_COND_ONESHOT'
880 | IRQF_COND_ONESHOT, NULL, NULL);
| ^~~~~~~~~~~~~~~~~
2 errors generated.
vim +/devm_request_threaded_irq +878 drivers/firmware/smccc/lfa_fw.c
863
864 static int lfa_register_dt(struct device *dev)
865 {
866 struct device_node *np;
867 unsigned int irq;
868
869 np = of_find_compatible_node(NULL, NULL, "arm,lfa");
870 if (!np)
871 return -ENODEV;
872
873 irq = irq_of_parse_and_map(np, 0);
874 of_node_put(np);
875 if (!irq)
876 return -ENODEV;
877
> 878 return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
879 lfa_irq_handler_thread,
> 880 IRQF_COND_ONESHOT, NULL, NULL);
881 }
882
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi Andre,
kernel test robot noticed the following build errors:
[auto build test ERROR on robh/for-next]
[also build test ERROR on arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next rockchip/for-next shawnguo/for-next soc/for-next linus/master nferre-at91/at91-next v7.0-rc4 next-20260317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andre-Przywara/dt-bindings-arm-Add-Live-Firmware-Activation-binding/20260318-082717
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20260317103336.1273582-8-andre.przywara%40arm.com
patch subject: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt
config: arm64-randconfig-004-20260318 (https://download.01.org/0day-ci/archive/20260318/202603182202.gpyCz2RF-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603182202.gpyCz2RF-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603182202.gpyCz2RF-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/firmware/smccc/lfa_fw.c: In function 'lfa_register_dt':
>> drivers/firmware/smccc/lfa_fw.c:878:16: error: implicit declaration of function 'devm_request_threaded_irq'; did you mean 'devm_request_region'? [-Werror=implicit-function-declaration]
878 | return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| devm_request_region
>> drivers/firmware/smccc/lfa_fw.c:880:42: error: 'IRQF_COND_ONESHOT' undeclared (first use in this function)
880 | IRQF_COND_ONESHOT, NULL, NULL);
| ^~~~~~~~~~~~~~~~~
drivers/firmware/smccc/lfa_fw.c:880:42: note: each undeclared identifier is reported only once for each function it appears in
drivers/firmware/smccc/lfa_fw.c:881:1: warning: control reaches end of non-void function [-Wreturn-type]
881 | }
| ^
cc1: some warnings being treated as errors
vim +878 drivers/firmware/smccc/lfa_fw.c
863
864 static int lfa_register_dt(struct device *dev)
865 {
866 struct device_node *np;
867 unsigned int irq;
868
869 np = of_find_compatible_node(NULL, NULL, "arm,lfa");
870 if (!np)
871 return -ENODEV;
872
873 irq = irq_of_parse_and_map(np, 0);
874 of_node_put(np);
875 if (!irq)
876 return -ENODEV;
877
> 878 return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
879 lfa_irq_handler_thread,
> 880 IRQF_COND_ONESHOT, NULL, NULL);
881 }
882
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Hi,
On 3/18/26 15:21, kernel test robot wrote:
> Hi Andre,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next rockchip/for-next shawnguo/for-next soc/for-next linus/master nferre-at91/at91-next v7.0-rc4 next-20260317]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Andre-Przywara/dt-bindings-arm-Add-Live-Firmware-Activation-binding/20260318-082717
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> patch link: https://lore.kernel.org/r/20260317103336.1273582-8-andre.przywara%40arm.com
> patch subject: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt
> config: arm64-randconfig-004-20260318 (https://download.01.org/0day-ci/archive/20260318/202603182202.gpyCz2RF-lkp@intel.com/config)
> compiler: aarch64-linux-gcc (GCC) 12.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603182202.gpyCz2RF-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202603182202.gpyCz2RF-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> drivers/firmware/smccc/lfa_fw.c: In function 'lfa_register_dt':
>>> drivers/firmware/smccc/lfa_fw.c:878:16: error: implicit declaration of function 'devm_request_threaded_irq'; did you mean 'devm_request_region'? [-Werror=implicit-function-declaration]
> 878 | return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
> | ^~~~~~~~~~~~~~~~~~~~~~~~~
> | devm_request_region
>>> drivers/firmware/smccc/lfa_fw.c:880:42: error: 'IRQF_COND_ONESHOT' undeclared (first use in this function)
> 880 | IRQF_COND_ONESHOT, NULL, NULL);
> | ^~~~~~~~~~~~~~~~~
> drivers/firmware/smccc/lfa_fw.c:880:42: note: each undeclared identifier is reported only once for each function it appears in
> drivers/firmware/smccc/lfa_fw.c:881:1: warning: control reaches end of non-void function [-Wreturn-type]
> 881 | }
> | ^
> cc1: some warnings being treated as errors
For the records: including <linux/interrupt.h> fixes this issue.
Thanks for the heads up, will add this in a follow-up post.
Cheers,
Andre
>
>
> vim +878 drivers/firmware/smccc/lfa_fw.c
>
> 863
> 864 static int lfa_register_dt(struct device *dev)
> 865 {
> 866 struct device_node *np;
> 867 unsigned int irq;
> 868
> 869 np = of_find_compatible_node(NULL, NULL, "arm,lfa");
> 870 if (!np)
> 871 return -ENODEV;
> 872
> 873 irq = irq_of_parse_and_map(np, 0);
> 874 of_node_put(np);
> 875 if (!irq)
> 876 return -ENODEV;
> 877
> > 878 return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
> 879 lfa_irq_handler_thread,
> > 880 IRQF_COND_ONESHOT, NULL, NULL);
> 881 }
> 882
>
Hi Andre,
kernel test robot noticed the following build warnings:
[auto build test WARNING on robh/for-next]
[also build test WARNING on arm/for-next arm/fixes arm64/for-next/core clk/clk-next kvmarm/next rockchip/for-next shawnguo/for-next soc/for-next linus/master nferre-at91/at91-next v7.0-rc4 next-20260317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andre-Przywara/dt-bindings-arm-Add-Live-Firmware-Activation-binding/20260318-082717
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20260317103336.1273582-8-andre.przywara%40arm.com
patch subject: [PATCH v2 7/8] firmware: smccc: lfa: Register DT interrupt
config: arm64-randconfig-004-20260318 (https://download.01.org/0day-ci/archive/20260318/202603181913.NFRwBsN4-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260318/202603181913.NFRwBsN4-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603181913.NFRwBsN4-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/firmware/smccc/lfa_fw.c: In function 'lfa_register_dt':
drivers/firmware/smccc/lfa_fw.c:878:16: error: implicit declaration of function 'devm_request_threaded_irq'; did you mean 'devm_request_region'? [-Werror=implicit-function-declaration]
878 | return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| devm_request_region
drivers/firmware/smccc/lfa_fw.c:880:42: error: 'IRQF_COND_ONESHOT' undeclared (first use in this function)
880 | IRQF_COND_ONESHOT, NULL, NULL);
| ^~~~~~~~~~~~~~~~~
drivers/firmware/smccc/lfa_fw.c:880:42: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/firmware/smccc/lfa_fw.c:881:1: warning: control reaches end of non-void function [-Wreturn-type]
881 | }
| ^
cc1: some warnings being treated as errors
vim +881 drivers/firmware/smccc/lfa_fw.c
863
864 static int lfa_register_dt(struct device *dev)
865 {
866 struct device_node *np;
867 unsigned int irq;
868
869 np = of_find_compatible_node(NULL, NULL, "arm,lfa");
870 if (!np)
871 return -ENODEV;
872
873 irq = irq_of_parse_and_map(np, 0);
874 of_node_put(np);
875 if (!irq)
876 return -ENODEV;
877
878 return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
879 lfa_irq_handler_thread,
880 IRQF_COND_ONESHOT, NULL, NULL);
> 881 }
882
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
On Tue, Mar 17, 2026 at 11:33:33AM +0100, Andre Przywara wrote:
> + return devm_request_threaded_irq(dev, irq, lfa_irq_handler,
> + lfa_irq_handler_thread,
> + IRQF_COND_ONESHOT, NULL, NULL);
> +}
> +
> static int lfa_faux_probe(struct faux_device *fdev)
> {
> int ret;
> @@ -854,6 +893,12 @@ static int lfa_faux_probe(struct faux_device *fdev)
> }
> }
>
> + ret = lfa_register_dt(&fdev->dev);
> + if (!ret)
> + pr_info("registered LFA DT notification interrupt\n");
Drop. Drivers must be silent on success (mentioned more than once in
coding docs).
Starting FW update would deserve a comment, but probing a device or its
resource is completely irrelevant for the user.
> + if (ret != -ENODEV)
> + return ret;
> +
> return 0;
> }
>
> --
> 2.43.0
>
© 2016 - 2026 Red Hat, Inc.