[PATCH] staging: vme_user: fix missing blank line after declarations

Marco Antonio Solis Segura posted 1 patch 2 weeks, 6 days ago
drivers/staging/vme_user/vme_fake.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] staging: vme_user: fix missing blank line after declarations
Posted by Marco Antonio Solis Segura 2 weeks, 6 days ago
Add a missing blank line after declarations in struct fake_driver
to satisfy checkpatch.pl warning.

Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
---
 drivers/staging/vme_user/vme_fake.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
index be4ad47ed..eb918a857 100644
--- a/drivers/staging/vme_user/vme_fake.c
+++ b/drivers/staging/vme_user/vme_fake.c
@@ -67,6 +67,7 @@ struct fake_driver {
 	unsigned long long lm_base;
 	u32 lm_aspace;
 	u32 lm_cycle;
+
 	void (*lm_callback[4])(void *);
 	void *lm_data[4];
 	struct tasklet_struct int_tasklet;
-- 
2.53.0
Re: [PATCH] staging: vme_user: fix missing blank line after declarations
Posted by Dan Carpenter 2 weeks, 6 days ago
On Tue, Mar 17, 2026 at 03:54:53AM -0600, Marco Antonio Solis Segura wrote:
> Add a missing blank line after declarations in struct fake_driver
> to satisfy checkpatch.pl warning.
> 
> Signed-off-by: Marco Antonio Solis Segura <mshdevv@gmail.com>
> ---
>  drivers/staging/vme_user/vme_fake.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_fake.c b/drivers/staging/vme_user/vme_fake.c
> index be4ad47ed..eb918a857 100644
> --- a/drivers/staging/vme_user/vme_fake.c
> +++ b/drivers/staging/vme_user/vme_fake.c
> @@ -67,6 +67,7 @@ struct fake_driver {
>  	unsigned long long lm_base;
>  	u32 lm_aspace;
>  	u32 lm_cycle;
> +
>  	void (*lm_callback[4])(void *);

This is also a declaration so checkpatch is just wrong.  (Ignore
checkpatch mistakes or maybe try your hand at fixing checkpatch.pl).

regards,
dan carpenter

>  	void *lm_data[4];
>  	struct tasklet_struct int_tasklet;