i3c: fix missing newline in dev_err messages

[PATCH] i3c: fix missing newline in dev_err messages

Posted by Haoyu Lu 2 weeks, 6 days ago

From: "haoyu.lu" <hechushiguitu666@gmail.com>

Add missing newline to dev_err messages in:
- drivers/i3c/master.c
- drivers/i3c/master/svc-i3c-master.c

Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
---
 drivers/i3c/master.c                | 2 +-
 drivers/i3c/master/svc-i3c-master.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 9e6be49bebb2..27e93fcf2eba 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2396,7 +2396,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
 	 * DEFSLVS command.
 	 */
 	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
-		dev_err(dev, "I2C device with 10 bit address not supported.");
+		dev_err(dev, "I2C device with 10 bit address not supported.\n");
 		return -EOPNOTSUPP;
 	}
 
diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index b84b324e4111..e09a6218bf34 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1268,7 +1268,7 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
 	/* Configure IBI auto-rules */
 	ret = svc_i3c_update_ibirules(master);
 	if (ret)
-		dev_err(master->dev, "Cannot handle such a list of devices");
+		dev_err(master->dev, "Cannot handle such a list of devices\n");
 
 rpm_out:
 	pm_runtime_put_autosuspend(master->dev);
-- 
2.53.0.windows.1

Re: [PATCH] i3c: fix missing newline in dev_err messages

Posted by Alexandre Belloni 2 weeks, 5 days ago

On Tue, 17 Mar 2026 11:40:15 +0800, Haoyu Lu wrote:
> Add missing newline to dev_err messages in:
> - drivers/i3c/master.c
> - drivers/i3c/master/svc-i3c-master.c

Applied, thanks!

[1/1] i3c: fix missing newline in dev_err messages
      https://git.kernel.org/i3c/c/7ea9bfee2ee0

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] i3c: fix missing newline in dev_err messages

Posted by Frank Li 2 weeks, 5 days ago

On Tue, Mar 17, 2026 at 11:40:15AM +0800, Haoyu Lu wrote:
> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> Add missing newline to dev_err messages in:
> - drivers/i3c/master.c
> - drivers/i3c/master/svc-i3c-master.c
>
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>  drivers/i3c/master.c                | 2 +-
>  drivers/i3c/master/svc-i3c-master.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> index 9e6be49bebb2..27e93fcf2eba 100644
> --- a/drivers/i3c/master.c
> +++ b/drivers/i3c/master.c
> @@ -2396,7 +2396,7 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
>  	 * DEFSLVS command.
>  	 */
>  	if (boardinfo->base.flags & I2C_CLIENT_TEN) {
> -		dev_err(dev, "I2C device with 10 bit address not supported.");
> +		dev_err(dev, "I2C device with 10 bit address not supported.\n");
>  		return -EOPNOTSUPP;
>  	}
>
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index b84b324e4111..e09a6218bf34 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -1268,7 +1268,7 @@ static int svc_i3c_master_do_daa(struct i3c_master_controller *m)
>  	/* Configure IBI auto-rules */
>  	ret = svc_i3c_update_ibirules(master);
>  	if (ret)
> -		dev_err(master->dev, "Cannot handle such a list of devices");
> +		dev_err(master->dev, "Cannot handle such a list of devices\n");
>
>  rpm_out:
>  	pm_runtime_put_autosuspend(master->dev);
> --
> 2.53.0.windows.1
>

Re: [PATCH] i3c: fix missing newline in dev_err messages

Posted by Miquel Raynal 2 weeks, 6 days ago

On 17/03/2026 at 11:40:15 +08, Haoyu Lu <hechushiguitu666@gmail.com> wrote:

> From: "haoyu.lu" <hechushiguitu666@gmail.com>
>
> Add missing newline to dev_err messages in:
> - drivers/i3c/master.c
> - drivers/i3c/master/svc-i3c-master.c
>
> Signed-off-by: haoyu.lu <hechushiguitu666@gmail.com>
> ---

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>