[v1] Enable lt8713sx bridge with displayport for monaco-evk

[PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Vishnu Saini 2 weeks, 6 days ago

Monaco-evk has LT8713sx which act as DP to 3 DP output
converter. Edp PHY from monaco soc is connected to lt8713sx
as input and output of lt8713sx is connected to 3 mini DP ports.

Two ports are available in mainboard and one port
is available on Mezz board.

lt8713sx is connected to soc over i2c0 and with reset gpio
connected to pin6 of ioexpander5.

Enable the edp nodes from monaco and enable lontium lt8713sx
bridge node.

Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/monaco.dtsi    |  6 +++
 2 files changed, 95 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
index 0b26cc334a69..0ca5615c996d 100644
--- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
@@ -52,6 +52,30 @@ dmic: audio-codec-0 {
 		num-channels = <1>;
 	};
 
+	dp-connector0 {
+		compatible = "dp-connector";
+		label = "DP";
+		type = "mini";
+
+		port {
+			dp0_connector_in: endpoint {
+				remote-endpoint = <&lt8713sx_dp0_out>;
+			};
+		};
+	};
+
+	dp-connector1 {
+		compatible = "dp-connector";
+		label = "DP";
+		type = "mini";
+
+		port {
+			dp1_connector_in: endpoint {
+				remote-endpoint = <&lt8713sx_dp1_out>;
+			};
+		};
+	};
+
 	max98357a: audio-codec-1 {
 		compatible = "maxim,max98357a";
 		#sound-dai-cells = <0>;
@@ -355,6 +379,42 @@ &gpu_zap_shader {
 	firmware-name = "qcom/qcs8300/a623_zap.mbn";
 };
 
+&i2c0 {
+	status = "okay";
+
+	bridge@4f {
+		compatible = "lontium,lt8713sx";
+		reg = <0x4f>;
+		reset-gpios = <&expander5 6 GPIO_ACTIVE_LOW>;
+
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				lt8713sx_dp_in: endpoint {
+					remote-endpoint = <&mdss_dp0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				lt8713sx_dp0_out: endpoint {
+					remote-endpoint = <&dp0_connector_in>;
+				};
+			};
+
+			port@2 {
+				reg = <2>;
+				lt8713sx_dp1_out: endpoint {
+					remote-endpoint = <&dp1_connector_in>;
+				};
+			};
+		};
+	};
+};
+
 &i2c1 {
 	pinctrl-0 = <&qup_i2c1_default>;
 	pinctrl-names = "default";
@@ -483,6 +543,30 @@ &iris {
 	status = "okay";
 };
 
+&mdss {
+	status = "okay";
+};
+
+&mdss_dp0 {
+	pinctrl-0 = <&dp_hot_plug_det>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
+
+&mdss_dp0_out {
+	data-lanes = <0 1 2 3>;
+	link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+	remote-endpoint = <&lt8713sx_dp_in>;
+};
+
+&mdss_dp0_phy {
+	vdda-phy-supply = <&vreg_l5a>;
+	vdda-pll-supply = <&vreg_l4a>;
+
+	status = "okay";
+};
+
 &pcie0 {
 	pinctrl-0 = <&pcie0_default_state>;
 	pinctrl-names = "default";
@@ -531,6 +615,11 @@ usb2_id: usb2-id-state {
 	};
 };
 
+&qup_i2c0_data_clk {
+	drive-strength = <2>;
+	bias-pull-up;
+};
+
 &qupv3_id_0 {
 	firmware-name = "qcom/qcs8300/qupv3fw.elf";
 	status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi
index f92fdb1cefa0..5741cdbde3f5 100644
--- a/arch/arm64/boot/dts/qcom/monaco.dtsi
+++ b/arch/arm64/boot/dts/qcom/monaco.dtsi
@@ -5893,6 +5893,12 @@ tlmm: pinctrl@f100000 {
 			#interrupt-cells = <2>;
 			wakeup-parent = <&pdc>;
 
+			dp_hot_plug_det: dp-hot-plug-det-state {
+				pins = "gpio94";
+				function = "edp0_hot";
+				bias-disable;
+			};
+
 			hs0_mi2s_active: hs0-mi2s-active-state {
 				pins = "gpio106", "gpio107", "gpio108", "gpio109";
 				function = "hs0_mi2s";

-- 
2.34.1

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Krzysztof Kozlowski 2 weeks, 6 days ago

On 17/03/2026 07:03, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
> 
> Two ports are available in mainboard and one port
> is available on Mezz board.
> 
> lt8713sx is connected to soc over i2c0 and with reset gpio
> connected to pin6 of ioexpander5.
> 
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
> 
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

How v1 could be reviewed already? v1 is the first posting.


> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
>  arch/arm64/boot/dts/qcom/monaco.dtsi    |  6 +++
>  2 files changed, 95 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 0b26cc334a69..0ca5615c996d 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
>  		num-channels = <1>;
>  	};
>  
> +	dp-connector0 {

dp-connector-0

> +		compatible = "dp-connector";
> +		label = "DP";
> +		type = "mini";
> +
> +		port {
> +			dp0_connector_in: endpoint {
> +				remote-endpoint = <&lt8713sx_dp0_out>;
> +			};
> +		};
> +	};
> +
> +	dp-connector1 {


dp-connector-1

> +		compatible = "dp-connector";
> +		label = "DP";
> +		type = "mini";
> +
> +		port {
> +			dp1_connector_in: endpoint {
> +				remote-endpoint = <&lt8713sx_dp1_out>;
> +			};
> +		};
> +	};
> +
>  	max98357a: audio-codec-1 {

And here you have example. Write code consistent with the rest.


Best regards,
Krzysztof

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Vishnu Saini 2 weeks, 6 days ago

On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
> On 17/03/2026 07:03, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> > 
> > Two ports are available in mainboard and one port
> > is available on Mezz board.
> > 
> > lt8713sx is connected to soc over i2c0 and with reset gpio
> > connected to pin6 of ioexpander5.
> > 
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> > 
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> 
> How v1 could be reviewed already? v1 is the first posting.
This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
Maintainer asked to submit a new series once dependent patches are merged.
> 
> > ---
> >  arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
> >  arch/arm64/boot/dts/qcom/monaco.dtsi    |  6 +++
> >  2 files changed, 95 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > index 0b26cc334a69..0ca5615c996d 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
> >  		num-channels = <1>;
> >  	};
> >  
> > +	dp-connector0 {
> 
> dp-connector-0
> 
> > +		compatible = "dp-connector";
> > +		label = "DP";
> > +		type = "mini";
> > +
> > +		port {
> > +			dp0_connector_in: endpoint {
> > +				remote-endpoint = <&lt8713sx_dp0_out>;
> > +			};
> > +		};
> > +	};
> > +
> > +	dp-connector1 {
> 
> 
> dp-connector-1
> 
> > +		compatible = "dp-connector";
> > +		label = "DP";
> > +		type = "mini";
> > +
> > +		port {
> > +			dp1_connector_in: endpoint {
> > +				remote-endpoint = <&lt8713sx_dp1_out>;
> > +			};
> > +		};
> > +	};
> > +
> >  	max98357a: audio-codec-1 {
> 
> And here you have example. Write code consistent with the rest.
>
> 
> Best regards,
> Krzysztof

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Krzysztof Kozlowski 2 weeks, 6 days ago

On 17/03/2026 15:10, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
>> On 17/03/2026 07:03, Vishnu Saini wrote:
>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>>
>>> Two ports are available in mainboard and one port
>>> is available on Mezz board.
>>>
>>> lt8713sx is connected to soc over i2c0 and with reset gpio
>>> connected to pin6 of ioexpander5.
>>>
>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>> bridge node.
>>>
>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>
>> How v1 could be reviewed already? v1 is the first posting.
> This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
> Maintainer asked to submit a new series once dependent patches are merged.\

Not a v1 in such case. Please keep versioning, changelog and previous
references/lore links.


Best regards,
Krzysztof

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Dmitry Baryshkov 2 weeks, 6 days ago

On Tue, Mar 17, 2026 at 07:40:09PM +0530, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
> > On 17/03/2026 07:03, Vishnu Saini wrote:
> > > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > > converter. Edp PHY from monaco soc is connected to lt8713sx
> > > as input and output of lt8713sx is connected to 3 mini DP ports.
> > > 
> > > Two ports are available in mainboard and one port
> > > is available on Mezz board.
> > > 
> > > lt8713sx is connected to soc over i2c0 and with reset gpio
> > > connected to pin6 of ioexpander5.
> > > 
> > > Enable the edp nodes from monaco and enable lontium lt8713sx
> > > bridge node.
> > > 
> > > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > 
> > How v1 could be reviewed already? v1 is the first posting.
> This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
> Maintainer asked to submit a new series once dependent patches are merged.

The patches were already sent, so this should be v4 at least.


-- 
With best wishes
Dmitry

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Vishnu Saini 2 weeks, 6 days ago

On Tue, Mar 17, 2026 at 04:40:51PM +0200, Dmitry Baryshkov wrote:
> On Tue, Mar 17, 2026 at 07:40:09PM +0530, Vishnu Saini wrote:
> > On Tue, Mar 17, 2026 at 12:42:24PM +0100, Krzysztof Kozlowski wrote:
> > > On 17/03/2026 07:03, Vishnu Saini wrote:
> > > > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > > > converter. Edp PHY from monaco soc is connected to lt8713sx
> > > > as input and output of lt8713sx is connected to 3 mini DP ports.
> > > > 
> > > > Two ports are available in mainboard and one port
> > > > is available on Mezz board.
> > > > 
> > > > lt8713sx is connected to soc over i2c0 and with reset gpio
> > > > connected to pin6 of ioexpander5.
> > > > 
> > > > Enable the edp nodes from monaco and enable lontium lt8713sx
> > > > bridge node.
> > > > 
> > > > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > > > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > > 
> > > How v1 could be reviewed already? v1 is the first posting.
> > This series was reviewed previously, https://lore.kernel.org/all/20251228-lt8713sx-bridge-linux-for-next-v3-0-3f77ad84d7d1@oss.qualcomm.com/
> > Maintainer asked to submit a new series once dependent patches are merged.
> 
> The patches were already sent, so this should be v4 at least.
Sorry for the misunderstanding, i will rebase and submit v4 to previous series.
I will address review comments from this series in v4. 
> 
> -- 
> With best wishes
> Dmitry

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Konrad Dybcio 2 weeks, 6 days ago

On 3/17/26 7:03 AM, Vishnu Saini wrote:
> Monaco-evk has LT8713sx which act as DP to 3 DP output
> converter. Edp PHY from monaco soc is connected to lt8713sx
> as input and output of lt8713sx is connected to 3 mini DP ports.
> 
> Two ports are available in mainboard and one port
> is available on Mezz board.
> 
> lt8713sx is connected to soc over i2c0 and with reset gpio
> connected to pin6 of ioexpander5.
> 
> Enable the edp nodes from monaco and enable lontium lt8713sx
> bridge node.
> 
> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++

Subject: "s/monaco:/monaco-evk:"

>  arch/arm64/boot/dts/qcom/monaco.dtsi    |  6 +++
>  2 files changed, 95 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> index 0b26cc334a69..0ca5615c996d 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
>  		num-channels = <1>;
>  	};
>  
> +	dp-connector0 {
> +		compatible = "dp-connector";
> +		label = "DP";

The labels should be unique, is there any silkscreen or similar that would
be a good candidate?

Konrad

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Vishnu Saini 2 weeks, 6 days ago

On Tue, Mar 17, 2026 at 10:22:04AM +0100, Konrad Dybcio wrote:
> On 3/17/26 7:03 AM, Vishnu Saini wrote:
> > Monaco-evk has LT8713sx which act as DP to 3 DP output
> > converter. Edp PHY from monaco soc is connected to lt8713sx
> > as input and output of lt8713sx is connected to 3 mini DP ports.
> > 
> > Two ports are available in mainboard and one port
> > is available on Mezz board.
> > 
> > lt8713sx is connected to soc over i2c0 and with reset gpio
> > connected to pin6 of ioexpander5.
> > 
> > Enable the edp nodes from monaco and enable lontium lt8713sx
> > bridge node.
> > 
> > Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
> > Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
> >  arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
> 
> Subject: "s/monaco:/monaco-evk:"
Will fix this in next revision.
 
> >  arch/arm64/boot/dts/qcom/monaco.dtsi    |  6 +++
> >  2 files changed, 95 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > index 0b26cc334a69..0ca5615c996d 100644
> > --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
> > @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
> >  		num-channels = <1>;
> >  	};
> >  
> > +	dp-connector0 {
> > +		compatible = "dp-connector";
> > +		label = "DP";
> 
> The labels should be unique, is there any silkscreen or similar that would
> be a good candidate?
yes, the connectors are marked as JEDP0 and JEDP1 on the board silkscreen.
I will update labels accordingly in next revision.

> Konrad

Re: [PATCH 1/2] arm64: dts: qcom: monaco: add lt8713sx bridge with displayport

Posted by Konrad Dybcio 2 weeks, 6 days ago

On 3/17/26 2:53 PM, Vishnu Saini wrote:
> On Tue, Mar 17, 2026 at 10:22:04AM +0100, Konrad Dybcio wrote:
>> On 3/17/26 7:03 AM, Vishnu Saini wrote:
>>> Monaco-evk has LT8713sx which act as DP to 3 DP output
>>> converter. Edp PHY from monaco soc is connected to lt8713sx
>>> as input and output of lt8713sx is connected to 3 mini DP ports.
>>>
>>> Two ports are available in mainboard and one port
>>> is available on Mezz board.
>>>
>>> lt8713sx is connected to soc over i2c0 and with reset gpio
>>> connected to pin6 of ioexpander5.
>>>
>>> Enable the edp nodes from monaco and enable lontium lt8713sx
>>> bridge node.
>>>
>>> Co-developed-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Prahlad Valluru <vvalluru@qti.qualcomm.com>
>>> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/monaco-evk.dts | 89 +++++++++++++++++++++++++++++++++
>>
>> Subject: "s/monaco:/monaco-evk:"
> Will fix this in next revision.
>  
>>>  arch/arm64/boot/dts/qcom/monaco.dtsi    |  6 +++
>>>  2 files changed, 95 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/monaco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> index 0b26cc334a69..0ca5615c996d 100644
>>> --- a/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> +++ b/arch/arm64/boot/dts/qcom/monaco-evk.dts
>>> @@ -52,6 +52,30 @@ dmic: audio-codec-0 {
>>>  		num-channels = <1>;
>>>  	};
>>>  
>>> +	dp-connector0 {
>>> +		compatible = "dp-connector";
>>> +		label = "DP";
>>
>> The labels should be unique, is there any silkscreen or similar that would
>> be a good candidate?
> yes, the connectors are marked as JEDP0 and JEDP1 on the board silkscreen.
> I will update labels accordingly in next revision.

"DP0" and "DP1" are fine too, and probably more obvious

Konrad