[PATCH v2 1/2] dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver bindings

Aaron Kling via B4 Relay posted 2 patches 2 weeks, 6 days ago
There is a newer version of this series
[PATCH v2 1/2] dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver bindings
Posted by Aaron Kling via B4 Relay 2 weeks, 6 days ago
From: Aaron Kling <webgeek1234@gmail.com>

The Chip Wealth Technology CH13726A display driver is a single chip
solution for AMOLED using MIPI-DSI. This is used for the AYN Thor bottom
panel.

Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
---
 .../display/panel/chipwealth,ch13726a.yaml         | 66 ++++++++++++++++++++++
 1 file changed, 66 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..b490c6757bb98c0752ded78b8fea3aaec853c7b2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
@@ -0,0 +1,66 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/chipwealth,ch13726a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Chip Wealth Technology CH13726A display driver
+
+maintainers:
+  - Neil Armstrong <neil.armstrong@linaro.org>
+
+description:
+  Chip Wealth Technology CH13726A is a single-chip solution
+  for AMOLED connected using a MIPI-DSI video interface.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: ayntec,thor-panel-bottom
+
+  port: true
+  reg:
+    maxItems: 1
+    description: DSI virtual channel
+
+  vdd-supply: true
+  vddio-supply: true
+  vdd1v2-supply: true
+  avdd-supply: true
+
+  reset-gpios: true
+
+  rotation: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+  - vddio-supply
+  - vdd1v2-supply
+  - avdd-supply
+  - reset-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel@0 {
+            compatible = "ayntec,thor-panel-bottom";
+            reg = <0>;
+            vdd1v2-supply = <&vreg_l11b_1p2>;
+            vddio-supply = <&vdd_disp_1v8>;
+            vdd-supply = <&vreg_l13b_3p0>;
+            avdd-supply = <&vdd_disp2_2v8>;
+            reset-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
+        };
+    };
+
+...

-- 
2.53.0
Re: [PATCH v2 1/2] dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver bindings
Posted by Krzysztof Kozlowski 2 weeks, 6 days ago
On Tue, Mar 17, 2026 at 12:23:07AM -0500, Aaron Kling wrote:
> The Chip Wealth Technology CH13726A display driver is a single chip
> solution for AMOLED using MIPI-DSI. This is used for the AYN Thor bottom
> panel.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Also drop all references to "display driver", even if you meant hardware
thing.  Driver in hardware is suitable only to motors, haptics and LEDs,
but not to displays. AMOLED driver is fine, display driver too confusing.


> 
> Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> ---
>  .../display/panel/chipwealth,ch13726a.yaml         | 66 ++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..b490c6757bb98c0752ded78b8fea3aaec853c7b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/chipwealth,ch13726a.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chip Wealth Technology CH13726A display driver
> +
> +maintainers:
> +  - Neil Armstrong <neil.armstrong@linaro.org>
> +
> +description:
> +  Chip Wealth Technology CH13726A is a single-chip solution
> +  for AMOLED connected using a MIPI-DSI video interface.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: ayntec,thor-panel-bottom

Why compatible is completely different than commit msg, description and
title are saying?

> +
> +  port: true

This goes before reset-gpios

> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  vdd-supply: true
> +  vddio-supply: true
> +  vdd1v2-supply: true
> +  avdd-supply: true
> +
> +  reset-gpios: true
> +

Drop blank line here (it is port+reset-gpios+rotation in three lines).


> +  rotation: true
> +

Best regards,
Krzysztof
Re: [PATCH v2 1/2] dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver bindings
Posted by Aaron Kling 2 weeks, 6 days ago
On Tue, Mar 17, 2026 at 2:33 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Tue, Mar 17, 2026 at 12:23:07AM -0500, Aaron Kling wrote:
> > The Chip Wealth Technology CH13726A display driver is a single chip
> > solution for AMOLED using MIPI-DSI. This is used for the AYN Thor bottom
> > panel.
>
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Ack

> Also drop all references to "display driver", even if you meant hardware
> thing.  Driver in hardware is suitable only to motors, haptics and LEDs,
> but not to displays. AMOLED driver is fine, display driver too confusing.

Per the data sheet [0], my understanding is that the ch13726 is a
ddic, a display driver integrated circuit, which is a class of generic
chip that gets bundled with multiple panels. This data sheet doesn't
use the specific term ddic, but others I'm working on do and the term
crept across for consistency. I can change the description to avoid
confusion, Is 'AMOLED driver' enough to imply that this is a common
chip supporting multiple panels?

> >
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
> >  .../display/panel/chipwealth,ch13726a.yaml         | 66 ++++++++++++++++++++++
> >  1 file changed, 66 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..b490c6757bb98c0752ded78b8fea3aaec853c7b2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> > @@ -0,0 +1,66 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/display/panel/chipwealth,ch13726a.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Chip Wealth Technology CH13726A display driver
> > +
> > +maintainers:
> > +  - Neil Armstrong <neil.armstrong@linaro.org>
> > +
> > +description:
> > +  Chip Wealth Technology CH13726A is a single-chip solution
> > +  for AMOLED connected using a MIPI-DSI video interface.
> > +
> > +allOf:
> > +  - $ref: panel-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: ayntec,thor-panel-bottom
>
> Why compatible is completely different than commit msg, description and
> title are saying?

See above for the general explanation. I don't know what the panel
part number for this is, the only thing the odm described was the
ddic. So I'm describing where the panel is used. There is precedence
for this, for example rocktech,jh057n00900 containing
gameforce,chi-panel. The downstream driver code I based on also
supports displays from retroidpocket, so I'm also trying to leave a
simple path for those to be added, should someone care to.

> > +
> > +  port: true
>
> This goes before reset-gpios

Ack

> > +  reg:
> > +    maxItems: 1
> > +    description: DSI virtual channel
> > +
> > +  vdd-supply: true
> > +  vddio-supply: true
> > +  vdd1v2-supply: true
> > +  avdd-supply: true
> > +
> > +  reset-gpios: true
> > +
>
> Drop blank line here (it is port+reset-gpios+rotation in three lines).

Ack

>
> > +  rotation: true
> > +
>
> Best regards,
> Krzysztof
>
Aaron
Re: [PATCH v2 1/2] dt-bindings: display: panel: Add ChipWealth CH13726A AMOLED driver bindings
Posted by Aaron Kling 2 weeks, 6 days ago
On Tue, Mar 17, 2026 at 12:59 PM Aaron Kling <webgeek1234@gmail.com> wrote:
>
> On Tue, Mar 17, 2026 at 2:33 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Tue, Mar 17, 2026 at 12:23:07AM -0500, Aaron Kling wrote:
> > > The Chip Wealth Technology CH13726A display driver is a single chip
> > > solution for AMOLED using MIPI-DSI. This is used for the AYN Thor bottom
> > > panel.
> >
> > A nit, subject: drop second/last, redundant "bindings". The
> > "dt-bindings" prefix is already stating that these are bindings.
> > See also:
> > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
>
> Ack
>
> > Also drop all references to "display driver", even if you meant hardware
> > thing.  Driver in hardware is suitable only to motors, haptics and LEDs,
> > but not to displays. AMOLED driver is fine, display driver too confusing.
>
> Per the data sheet [0], my understanding is that the ch13726 is a
> ddic, a display driver integrated circuit, which is a class of generic
> chip that gets bundled with multiple panels. This data sheet doesn't
> use the specific term ddic, but others I'm working on do and the term
> crept across for consistency. I can change the description to avoid
> confusion, Is 'AMOLED driver' enough to imply that this is a common
> chip supporting multiple panels?

Sorry, forgot to actually paste the link [0] in my last reply. Adding now.

> > >
> > > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > > ---
> > >  .../display/panel/chipwealth,ch13726a.yaml         | 66 ++++++++++++++++++++++
> > >  1 file changed, 66 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> > > new file mode 100644
> > > index 0000000000000000000000000000000000000000..b490c6757bb98c0752ded78b8fea3aaec853c7b2
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/display/panel/chipwealth,ch13726a.yaml
> > > @@ -0,0 +1,66 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/panel/chipwealth,ch13726a.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Chip Wealth Technology CH13726A display driver
> > > +
> > > +maintainers:
> > > +  - Neil Armstrong <neil.armstrong@linaro.org>
> > > +
> > > +description:
> > > +  Chip Wealth Technology CH13726A is a single-chip solution
> > > +  for AMOLED connected using a MIPI-DSI video interface.
> > > +
> > > +allOf:
> > > +  - $ref: panel-common.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: ayntec,thor-panel-bottom
> >
> > Why compatible is completely different than commit msg, description and
> > title are saying?
>
> See above for the general explanation. I don't know what the panel
> part number for this is, the only thing the odm described was the
> ddic. So I'm describing where the panel is used. There is precedence
> for this, for example rocktech,jh057n00900 containing
> gameforce,chi-panel. The downstream driver code I based on also
> supports displays from retroidpocket, so I'm also trying to leave a
> simple path for those to be added, should someone care to.
>
> > > +
> > > +  port: true
> >
> > This goes before reset-gpios
>
> Ack
>
> > > +  reg:
> > > +    maxItems: 1
> > > +    description: DSI virtual channel
> > > +
> > > +  vdd-supply: true
> > > +  vddio-supply: true
> > > +  vdd1v2-supply: true
> > > +  avdd-supply: true
> > > +
> > > +  reset-gpios: true
> > > +
> >
> > Drop blank line here (it is port+reset-gpios+rotation in three lines).
>
> Ack
>
> >
> > > +  rotation: true
> > > +
> >
> > Best regards,
> > Krzysztof
> >
Aaron

[0] https://www.scribd.com/document/910879274/CH13726A-SPEC-V0-0