[PATCH 7/9] arm64: defconfig: remove incorrect assignment to IPQ_APSS_5018

Vincent Mailhol (Arm) posted 9 patches 2 weeks, 6 days ago
[PATCH 7/9] arm64: defconfig: remove incorrect assignment to IPQ_APSS_5018
Posted by Vincent Mailhol (Arm) 2 weeks, 6 days ago
CONFIG_IPQ_APSS_5018 does not exist and never existed. Remove it.

Fixes: 7f0c87348fb5 ("arm64: defconfig: Enable IPQ5018 SoC base configs")
Signed-off-by: Vincent Mailhol (Arm) <mailhol@kernel.org>
---
 arch/arm64/configs/defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 0b307e2ab384..1fda77bca432 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1456,7 +1456,6 @@ CONFIG_QCOM_CLK_APCC_MSM8996=y
 CONFIG_QCOM_CLK_SMD_RPM=y
 CONFIG_QCOM_CLK_RPMH=y
 CONFIG_IPQ_APSS_6018=y
-CONFIG_IPQ_APSS_5018=y
 CONFIG_IPQ_CMN_PLL=m
 CONFIG_IPQ_GCC_5018=y
 CONFIG_IPQ_GCC_5332=y

-- 
2.43.0
Re: [PATCH 7/9] arm64: defconfig: remove incorrect assignment to IPQ_APSS_5018
Posted by Krzysztof Kozlowski 2 weeks, 6 days ago
On 17/03/2026 10:13, Vincent Mailhol (Arm) wrote:
> CONFIG_IPQ_APSS_5018 does not exist and never existed. Remove it.
> 
> Fixes: 7f0c87348fb5 ("arm64: defconfig: Enable IPQ5018 SoC base configs")
> Signed-off-by: Vincent Mailhol (Arm) <mailhol@kernel.org>
> ---

Just like try one year ago:
https://lore.kernel.org/all/20240104133241.2030193-1-ross.burton@arm.com/

No one will apply it if you do not send the patch to right people.
multi_vx and arm64 defconfig fall outside of get_maintainers thus policy
from maintainer soc profile applies.

This one should be send to platform maintainers, so to qcom.

Other ones: please send all arm and arm64 defconfig changes in one
patchset to soc folks. Here, at least provide credits with Reported-by
to Ross.


Best regards,
Krzysztof
Re: [PATCH 7/9] arm64: defconfig: remove incorrect assignment to IPQ_APSS_5018
Posted by Vincent Mailhol (Arm) 1 week, 5 days ago
+CC: soc@lists.linux.dev
+CC: Bjorn Andersson <andersson@kernel.org>
+CC: Konrad Dybcio <konradybcio@kernel.org>

On 3/17/26 12:31, Krzysztof Kozlowski wrote:
> On 17/03/2026 10:13, Vincent Mailhol (Arm) wrote:
>> CONFIG_IPQ_APSS_5018 does not exist and never existed. Remove it.
>>
>> Fixes: 7f0c87348fb5 ("arm64: defconfig: Enable IPQ5018 SoC base configs")
>> Signed-off-by: Vincent Mailhol (Arm) <mailhol@kernel.org>
>> ---
> 
> Just like try one year ago:
> https://lore.kernel.org/all/20240104133241.2030193-1-ross.burton@arm.com/
> 
> No one will apply it if you do not send the patch to right people.
> multi_vx and arm64 defconfig fall outside of get_maintainers thus policy
> from maintainer soc profile applies.

As you guessed, I used get_maintainers.pl to generate the recipient
list. I am just surprised to hear that the defconfigs fall out of the
usual process. This is a pit fall as shown by the fact that both Ross
and me failed to send it to the right people.

As you pointed in another answer, I saw that the documentation was
updated. I will follow this from now on. Thanks for that!

> This one should be send to platform maintainers, so to qcom.

I will add linux-arm-msm@vger.kernel.org, Bjorn Andersson, Konrad Dybcio.

I don't think this should be split though. My series does one thing:
address the warnings from scripts/kconfig/merge_config.sh. When a series
have a clear scope which spans other several trees, it is more common to
collect Acked-by tags from the maintainers of the other domains rather
than splitting.

> Other ones: please send all arm and arm64 defconfig changes in one
> patchset to soc folks. Here, at least provide credits with Reported-by
> to Ross.
OK. Although this was re-discovered independently on my side, will add
the Reported-by tag to give proper credit.


Yours sincerely,
Vincent Mailhol