[PATCH] dmaengine: xilinx: xilinx_dma: Fix dma_device directions

Marek Vasut posted 1 patch 3 weeks ago
drivers/dma/xilinx/xilinx_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] dmaengine: xilinx: xilinx_dma: Fix dma_device directions
Posted by Marek Vasut 3 weeks ago
Unlike chan->direction , struct dma_device .directions field is a
bitfield. Turn chan->direction into a bitfield to make it compatible
with struct dma_device .directions .

Fixes: 7e01511443c3 ("dmaengine: xilinx_dma: Set dma_device directions")
Signed-off-by: Marek Vasut <marex@nabladev.com>
---
Cc: Michal Simek <michal.simek@amd.com>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Cc: Rahul Navale <rahul.navale@ifm.com>
Cc: Sasha Levin <sashal@kernel.org>
Cc: Suraj Gupta <suraj.gupta2@amd.com>
Cc: Thomas Gessler <thomas.gessler@brueckmann-gmbh.de>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 drivers/dma/xilinx/xilinx_dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index 7f240fdfe8bb1..6e8e348973a9e 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -3045,7 +3045,7 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
 		return -EINVAL;
 	}
 
-	xdev->common.directions |= chan->direction;
+	xdev->common.directions |= BIT(chan->direction);
 
 	/* Request the interrupt */
 	chan->irq = of_irq_get(node, chan->tdest);
-- 
2.51.0
Re: [PATCH] dmaengine: xilinx: xilinx_dma: Fix dma_device directions
Posted by Vinod Koul 2 weeks, 6 days ago
On Mon, 16 Mar 2026 23:16:54 +0100, Marek Vasut wrote:
> Unlike chan->direction , struct dma_device .directions field is a
> bitfield. Turn chan->direction into a bitfield to make it compatible
> with struct dma_device .directions .
> 
> 

Applied, thanks!

[1/1] dmaengine: xilinx: xilinx_dma: Fix dma_device directions
      commit: e9cc95397bb7da13fe8a5b53a2f23cfaf9018ade

Best regards,
-- 
~Vinod