[PATCH v2] ASoC: dt-bindings: adi,ssm2305: Convert to DT schema

Piyush Patle posted 1 patch 3 weeks ago
There is a newer version of this series
.../devicetree/bindings/sound/adi,ssm2305.txt | 14 ------
.../bindings/sound/adi,ssm2305.yaml           | 46 +++++++++++++++++++
2 files changed, 46 insertions(+), 14 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
[PATCH v2] ASoC: dt-bindings: adi,ssm2305: Convert to DT schema
Posted by Piyush Patle 3 weeks ago
Convert the SSM2305 speaker amplifier binding from text format to
YAML schema to enable dtbs_check validation.

---

Changes in v2:
- Fix subject prefix to ASoC: dt-bindings:

Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
---
 .../devicetree/bindings/sound/adi,ssm2305.txt | 14 ------
 .../bindings/sound/adi,ssm2305.yaml           | 46 +++++++++++++++++++
 2 files changed, 46 insertions(+), 14 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
 create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml

diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt b/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
deleted file mode 100644
index a9c9d83c8a30..000000000000
--- a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
+++ /dev/null
@@ -1,14 +0,0 @@
-Analog Devices SSM2305 Speaker Amplifier
-========================================
-
-Required properties:
-  - compatible : "adi,ssm2305"
-  - shutdown-gpios : The gpio connected to the shutdown pin.
-                     The gpio signal is ACTIVE_LOW.
-
-Example:
-
-ssm2305: analog-amplifier {
-	compatible = "adi,ssm2305";
-	shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
-};
diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
new file mode 100644
index 000000000000..b841da2dc284
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/adi,ssm2305.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices SSM2305 Class-D Speaker Amplifier
+
+maintainers:
+  - Lars-Peter Clausen <lars@metafoo.de>
+
+description:
+  The SSM2305 is a filterless, high efficiency, mono 2.8 W Class-D
+  audio amplifier with a micropower shutdown mode controlled via a
+  dedicated active-low GPIO pin.
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: adi,ssm2305
+
+  shutdown-gpios:
+    maxItems: 1
+    description:
+      GPIO connected to the shutdown pin (SD) of the SSM2305.
+      The pin is active-low; asserting it puts the device into
+      micropower shutdown mode.
+
+required:
+  - compatible
+  - shutdown-gpios
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    analog-amplifier {
+        compatible = "adi,ssm2305";
+        shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
+    };
+
+...
-- 
2.34.1
Re: [PATCH v2] ASoC: dt-bindings: adi,ssm2305: Convert to DT schema
Posted by Krzysztof Kozlowski 2 weeks, 6 days ago
On Tue, Mar 17, 2026 at 02:43:48AM +0530, Piyush Patle wrote:
> Convert the SSM2305 speaker amplifier binding from text format to
> YAML schema to enable dtbs_check validation.
> 

Missing DCO. Apply your patch and check yourself.

Also, you ignored my review, without explanation. But since you will
have to send new version, then s/YAML/DT/. There is no such thing as
YAML schema.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions of patchset, under or above your Signed-off-by tag, unless
patch changed significantly (e.g. new properties added to the DT
bindings). Tag is "received", when provided in a message replied to you
on the mailing list. Tools like b4 can help here. However, there's no
need to repost patches *only* to add the tags. The upstream maintainer
will do that for tags received on the version they apply.

Please read:
https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.
</form letter>

Best regards,
Krzysztof
Re: [PATCH v2] ASoC: dt-bindings: adi,ssm2305: Convert to DT schema
Posted by Mark Brown 2 weeks, 6 days ago
On Tue, Mar 17, 2026 at 08:28:12AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Mar 17, 2026 at 02:43:48AM +0530, Piyush Patle wrote:
> > Convert the SSM2305 speaker amplifier binding from text format to
> > YAML schema to enable dtbs_check validation.

> Missing DCO. Apply your patch and check yourself.

Specifically the issue here is that your signoff needs to go before the
--- since everything in the changelog after that gets deleted.
Re: [PATCH v2] ASoC: dt-bindings: adi,ssm2305: Convert to DT schema
Posted by Piyush Patle 2 weeks, 5 days ago
On Tue, Mar 17, 2026 at 6:23 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Mar 17, 2026 at 08:28:12AM +0100, Krzysztof Kozlowski wrote:
> > On Tue, Mar 17, 2026 at 02:43:48AM +0530, Piyush Patle wrote:
> > > Convert the SSM2305 speaker amplifier binding from text format to
> > > YAML schema to enable dtbs_check validation.
>
> > Missing DCO. Apply your patch and check yourself.
>
> Specifically the issue here is that your signoff needs to go before the
> --- since everything in the changelog after that gets deleted.

Thank you for the feedback. I have fixed the issues and will send v3
shortly with:
- Signed-off-by and Reviewed-by placed correctly before ---
- "YAML schema" replaced with "DT schema" in commit body