fs/unicode/utf8-norm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The file contains a spelling error in a source comment (succes).
Typos in comments reduce readability and make text searches less reliable
for developers and maintainers.
Replace 'succes' with 'success' in the affected comment. This is a
comment-only cleanup and does not change behavior.
Fixes: 44594c2fbf42 ("unicode: introduce code for UTF-8 normalization")
Cc: stable@vger.kernel.org
Signed-off-by: Joseph Salisbury <joseph.salisbury@oracle.com>
---
fs/unicode/utf8-norm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
index 7b998c99c88d..41e884569dbe 100644
--- a/fs/unicode/utf8-norm.c
+++ b/fs/unicode/utf8-norm.c
@@ -444,7 +444,7 @@ int utf8ncursor(struct utf8cursor *u8c, const struct unicode_map *um,
/*
* Get one byte from the normalized form of the string described by u8c.
*
- * Returns the byte cast to an unsigned char on succes, and -1 on failure.
+ * Returns the byte cast to an unsigned char on success, and -1 on failure.
*
* The cursor keeps track of the location in the string in u8c->s.
* When a character is decomposed, the current location is stored in
--
2.47.3
Joseph Salisbury <joseph.salisbury@oracle.com> writes:
> The file contains a spelling error in a source comment (succes).
>
> Typos in comments reduce readability and make text searches less reliable
> for developers and maintainers.
>
> Replace 'succes' with 'success' in the affected comment. This is a
> comment-only cleanup and does not change behavior.
These typo-only fixes are way more of an annoyance when backporting real
fixes than adding any real value. Somehow I doubt fixing a single typo
makes the code more readable.
But at least, can you make this a single patch with all the fixes to
fs/unicode/ instead of one patch per typo?
> Fixes: 44594c2fbf42 ("unicode: introduce code for UTF-8 normalization")
> Cc: stable@vger.kernel.org
Please remove this.
> Signed-off-by: Joseph Salisbury <joseph.salisbury@oracle.com>
> ---
> fs/unicode/utf8-norm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
> index 7b998c99c88d..41e884569dbe 100644
> --- a/fs/unicode/utf8-norm.c
> +++ b/fs/unicode/utf8-norm.c
> @@ -444,7 +444,7 @@ int utf8ncursor(struct utf8cursor *u8c, const struct unicode_map *um,
> /*
> * Get one byte from the normalized form of the string described by u8c.
> *
> - * Returns the byte cast to an unsigned char on succes, and -1 on failure.
> + * Returns the byte cast to an unsigned char on success, and -1 on failure.
> *
> * The cursor keeps track of the location in the string in u8c->s.
> * When a character is decomposed, the current location is stored in
--
Gabriel Krisman Bertazi
On 3/16/26 2:49 PM, Joseph Salisbury wrote:
> The file contains a spelling error in a source comment (succes).
>
> Typos in comments reduce readability and make text searches less reliable
> for developers and maintainers.
>
> Replace 'succes' with 'success' in the affected comment. This is a
> comment-only cleanup and does not change behavior.
>
> Fixes: 44594c2fbf42 ("unicode: introduce code for UTF-8 normalization")
> Cc: stable@vger.kernel.org
> Signed-off-by: Joseph Salisbury <joseph.salisbury@oracle.com>
> ---
> fs/unicode/utf8-norm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/unicode/utf8-norm.c b/fs/unicode/utf8-norm.c
> index 7b998c99c88d..41e884569dbe 100644
> --- a/fs/unicode/utf8-norm.c
> +++ b/fs/unicode/utf8-norm.c
> @@ -444,7 +444,7 @@ int utf8ncursor(struct utf8cursor *u8c, const struct unicode_map *um,
> /*
> * Get one byte from the normalized form of the string described by u8c.
> *
> - * Returns the byte cast to an unsigned char on succes, and -1 on failure.
> + * Returns the byte cast to an unsigned char on success, and -1 on failure.
> *
> * The cursor keeps track of the location in the string in u8c->s.
> * When a character is decomposed, the current location is stored in
I inadvertently added Fixes: and Cc: stable tags. If possible, please
remove them as they are not appropriate for fixes to misspellings in
code comments. If it's not possible to remove them, I can send a v2.
© 2016 - 2026 Red Hat, Inc.