[PATCH v5 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI

Oleksij Rempel posted 7 patches 3 weeks ago
There is a newer version of this series
.../bindings/pinctrl/nxp,mc33978.yaml         | 153 +++
drivers/gpio/gpiolib.c                        |  19 +-
drivers/hwmon/Kconfig                         |  10 +
drivers/hwmon/Makefile                        |   1 +
drivers/hwmon/mc33978-hwmon.c                 | 430 +++++++++
drivers/mfd/Kconfig                           |  15 +
drivers/mfd/Makefile                          |   2 +
drivers/mfd/mc33978.c                         | 870 ++++++++++++++++++
drivers/mux/Kconfig                           |  14 +
drivers/mux/Makefile                          |   2 +
drivers/mux/mc33978-mux.c                     | 119 +++
drivers/pinctrl/Kconfig                       |  14 +
drivers/pinctrl/Makefile                      |   1 +
drivers/pinctrl/core.c                        |  25 +-
drivers/pinctrl/pinconf.c                     |  18 +-
drivers/pinctrl/pinctrl-mc33978.c             | 747 +++++++++++++++
include/linux/mfd/mc33978.h                   |  86 ++
17 files changed, 2506 insertions(+), 20 deletions(-)
create mode 100644 Documentation/devicetree/bindings/pinctrl/nxp,mc33978.yaml
create mode 100644 drivers/hwmon/mc33978-hwmon.c
create mode 100644 drivers/mfd/mc33978.c
create mode 100644 drivers/mux/mc33978-mux.c
create mode 100644 drivers/pinctrl/pinctrl-mc33978.c
create mode 100644 include/linux/mfd/mc33978.h
[PATCH v5 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI
Posted by Oleksij Rempel 3 weeks ago
This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
Interface (MSDI) via the MFD framework.

Architecture overview:
* mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
  linear irq_domain. Harvests status bits from SPI MISO MSB.
* pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
  the MFD domain.
* hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
  fault alarms.
* mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
  temperature, VBATP) to an external ADC.

Initial pinctrl implementation by David Jander, reworked into this MFD
architecture.

Best regards,
Oleksij

David Jander (1):
  pinctrl: add NXP MC33978/MC34978 pinctrl driver

Oleksij Rempel (6):
  dt-bindings: pinctrl: add NXP MC33978/MC34978 MSDI
  mfd: add NXP MC33978/MC34978 core driver
  pinctrl: core: Make pin group callbacks optional
  gpio: gpiolib: fix allocation order in hierarchical IRQ domains
  hwmon: add NXP MC33978/MC34978 driver
  mux: add NXP MC33978/MC34978 AMUX driver

 .../bindings/pinctrl/nxp,mc33978.yaml         | 153 +++
 drivers/gpio/gpiolib.c                        |  19 +-
 drivers/hwmon/Kconfig                         |  10 +
 drivers/hwmon/Makefile                        |   1 +
 drivers/hwmon/mc33978-hwmon.c                 | 430 +++++++++
 drivers/mfd/Kconfig                           |  15 +
 drivers/mfd/Makefile                          |   2 +
 drivers/mfd/mc33978.c                         | 870 ++++++++++++++++++
 drivers/mux/Kconfig                           |  14 +
 drivers/mux/Makefile                          |   2 +
 drivers/mux/mc33978-mux.c                     | 119 +++
 drivers/pinctrl/Kconfig                       |  14 +
 drivers/pinctrl/Makefile                      |   1 +
 drivers/pinctrl/core.c                        |  25 +-
 drivers/pinctrl/pinconf.c                     |  18 +-
 drivers/pinctrl/pinctrl-mc33978.c             | 747 +++++++++++++++
 include/linux/mfd/mc33978.h                   |  86 ++
 17 files changed, 2506 insertions(+), 20 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/nxp,mc33978.yaml
 create mode 100644 drivers/hwmon/mc33978-hwmon.c
 create mode 100644 drivers/mfd/mc33978.c
 create mode 100644 drivers/mux/mc33978-mux.c
 create mode 100644 drivers/pinctrl/pinctrl-mc33978.c
 create mode 100644 include/linux/mfd/mc33978.h

--
2.47.3
Re: [PATCH v5 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI
Posted by Guenter Roeck 2 weeks, 6 days ago
Hi,

On 3/16/26 07:05, Oleksij Rempel wrote:
> This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
> Interface (MSDI) via the MFD framework.
> 
> Architecture overview:
> * mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
>    linear irq_domain. Harvests status bits from SPI MISO MSB.
> * pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
>    the MFD domain.
> * hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
>    fault alarms.
> * mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
>    temperature, VBATP) to an external ADC.
> 
> Initial pinctrl implementation by David Jander, reworked into this MFD
> architecture.
> 

Please have a look at the AI review feedback at
https://sashiko.dev/#/patchset/20260316140514.1406588-1-o.rempel%40pengutronix.de

It didn't run on all patches of the series, and I don't know how accurate
the feedback for the non-hwmon patches is, but at least for the hwmon
patch I agree with its findings.

Thanks,
Guenter
Re: [PATCH v5 0/7] mfd: Add support for NXP MC33978/MC34978 MSDI
Posted by Oleksij Rempel 2 weeks, 5 days ago
On Tue, Mar 17, 2026 at 03:12:11PM -0700, Guenter Roeck wrote:
> Hi,
> 
> On 3/16/26 07:05, Oleksij Rempel wrote:
> > This series adds support for the NXP MC33978/MC34978 Multiple Switch Detection
> > Interface (MSDI) via the MFD framework.
> > 
> > Architecture overview:
> > * mfd: Core driver handling 2-frame pipelined SPI, regulator sequencing, and
> >    linear irq_domain. Harvests status bits from SPI MISO MSB.
> > * pinctrl: Exposes 22 physical switch inputs as standard GPIOs. Proxies IRQs to
> >    the MFD domain.
> > * hwmon: Exposes thermal limits, VBATP/VDDQ voltage boundaries, and dynamic
> >    fault alarms.
> > * mux: Controls the 24-to-1 AMUX routing analog signals (switch voltages,
> >    temperature, VBATP) to an external ADC.
> > 
> > Initial pinctrl implementation by David Jander, reworked into this MFD
> > architecture.
> > 
> 
> Please have a look at the AI review feedback at
> https://sashiko.dev/#/patchset/20260316140514.1406588-1-o.rempel%40pengutronix.de
> 
> It didn't run on all patches of the series, and I don't know how accurate
> the feedback for the non-hwmon patches is, but at least for the hwmon
> patch I agree with its findings.


There are valid findings. I'll address them. Thx!

Best Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |