.../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml | 7 +++++++ 1 file changed, 7 insertions(+)
From: bui duc phuc <phucduc.bui@gmail.com>
Document the "wakeup-source" property for the ti,tsc2005 touchscreen
controllers to allow the device to wake the system from suspend.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
.../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
index 7187c390b2f5..c0aae044d7d4 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml
@@ -55,6 +55,9 @@ properties:
touchscreen-size-x: true
touchscreen-size-y: true
+ wakeup-source:
+ type: boolean
+
allOf:
- $ref: touchscreen.yaml#
- if:
@@ -97,6 +100,8 @@ examples:
ti,x-plate-ohms = <280>;
ti,esd-recovery-timeout-ms = <8000>;
+
+ wakeup-source;
};
};
- |
@@ -124,5 +129,7 @@ examples:
ti,x-plate-ohms = <280>;
ti,esd-recovery-timeout-ms = <8000>;
+
+ wakeup-source;
};
};
--
2.43.0On Mon, Mar 16, 2026 at 10:46:06AM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc <phucduc.bui@gmail.com> > > Document the "wakeup-source" property for the ti,tsc2005 touchscreen > controllers to allow the device to wake the system from suspend. > > Signed-off-by: bui duc phuc <phucduc.bui@gmail.com> > --- > .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > index 7187c390b2f5..c0aae044d7d4 100644 > --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > @@ -55,6 +55,9 @@ properties: > touchscreen-size-x: true > touchscreen-size-y: true > > + wakeup-source: > + type: boolean wakeup-source: true > + > allOf: > - $ref: touchscreen.yaml# > - if: > @@ -97,6 +100,8 @@ examples: > > ti,x-plate-ohms = <280>; > ti,esd-recovery-timeout-ms = <8000>; > + Remove the blank line please. pw-bot: changes-requested Thanks, Conor. > + wakeup-source; > }; > }; > - | > @@ -124,5 +129,7 @@ examples: > > ti,x-plate-ohms = <280>; > ti,esd-recovery-timeout-ms = <8000>; > + > + wakeup-source; > }; > }; > -- > 2.43.0 >
On 16/03/2026 12:13, Conor Dooley wrote: > On Mon, Mar 16, 2026 at 10:46:06AM +0700, phucduc.bui@gmail.com wrote: >> From: bui duc phuc <phucduc.bui@gmail.com> >> >> Document the "wakeup-source" property for the ti,tsc2005 touchscreen >> controllers to allow the device to wake the system from suspend. >> >> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com> >> --- >> .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml >> index 7187c390b2f5..c0aae044d7d4 100644 >> --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml >> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml >> @@ -55,6 +55,9 @@ properties: >> touchscreen-size-x: true >> touchscreen-size-y: true >> >> + wakeup-source: >> + type: boolean > > wakeup-source: true I am not so sure. The property is multi-type, so we want to choose one - bool, IMO, because device cannot wakeup the specific system idle states. Or am I misinterpreting the phandles behind wakeup-source and every device can be differently routed in such system? Best regards, Krzysztof
On Mon, Mar 16, 2026 at 06:10:23PM +0100, Krzysztof Kozlowski wrote: > On 16/03/2026 12:13, Conor Dooley wrote: > > On Mon, Mar 16, 2026 at 10:46:06AM +0700, phucduc.bui@gmail.com wrote: > >> From: bui duc phuc <phucduc.bui@gmail.com> > >> > >> Document the "wakeup-source" property for the ti,tsc2005 touchscreen > >> controllers to allow the device to wake the system from suspend. > >> > >> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com> > >> --- > >> .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > >> index 7187c390b2f5..c0aae044d7d4 100644 > >> --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > >> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > >> @@ -55,6 +55,9 @@ properties: > >> touchscreen-size-x: true > >> touchscreen-size-y: true > >> > >> + wakeup-source: > >> + type: boolean > > > > wakeup-source: true > > I am not so sure. > > The property is multi-type, so we want to choose one - bool, IMO, > because device cannot wakeup the specific system idle states. Or am I > misinterpreting the phandles behind wakeup-source and every device can > be differently routed in such system? I checked before my original comment, and there there's a bout a 2:1 ratio of defined v true. I suppose my comment can be ignored, I am just used to this always being true.
Hi Conor, Krzysztof, Thanks for the review. I will remove the extra blank line in the next version. As for the wakeup-source property, I'll keep it as a boolean as per the current patch. Best Regards, Phuc On Tue, Mar 17, 2026 at 7:14 PM Conor Dooley <conor@kernel.org> wrote: > > On Mon, Mar 16, 2026 at 06:10:23PM +0100, Krzysztof Kozlowski wrote: > > On 16/03/2026 12:13, Conor Dooley wrote: > > > On Mon, Mar 16, 2026 at 10:46:06AM +0700, phucduc.bui@gmail.com wrote: > > >> From: bui duc phuc <phucduc.bui@gmail.com> > > >> > > >> Document the "wakeup-source" property for the ti,tsc2005 touchscreen > > >> controllers to allow the device to wake the system from suspend. > > >> > > >> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com> > > >> --- > > >> .../devicetree/bindings/input/touchscreen/ti,tsc2005.yaml | 7 +++++++ > > >> 1 file changed, 7 insertions(+) > > >> > > >> diff --git a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > > >> index 7187c390b2f5..c0aae044d7d4 100644 > > >> --- a/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > > >> +++ b/Documentation/devicetree/bindings/input/touchscreen/ti,tsc2005.yaml > > >> @@ -55,6 +55,9 @@ properties: > > >> touchscreen-size-x: true > > >> touchscreen-size-y: true > > >> > > >> + wakeup-source: > > >> + type: boolean > > > > > > wakeup-source: true > > > > I am not so sure. > > > > The property is multi-type, so we want to choose one - bool, IMO, > > because device cannot wakeup the specific system idle states. Or am I > > misinterpreting the phandles behind wakeup-source and every device can > > be differently routed in such system? > > I checked before my original comment, and there there's a bout a 2:1 > ratio of defined v true. I suppose my comment can be ignored, I am just > used to this always being true.
© 2016 - 2026 Red Hat, Inc.