Add optional PHY handle definitions. This will allow for supporting both
legacy PHY definitions as well as supporting the optional new handle based
approach.
Drop the legacy high-level 0p8 and 1p2 supplies as required, each PHY has
its own individual rails. The old binding is still valid but with
individual nodes we define the rails in the CSIPHY sub-nodes.
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
.../bindings/media/qcom,x1e80100-camss.yaml | 33 ++++++++++++++++++++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
index b5654ef71bd89..5442f981baebc 100644
--- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
@@ -43,6 +43,14 @@ properties:
- const: vfe_lite0
- const: vfe_lite1
+ '#address-cells':
+ const: 2
+
+ '#size-cells':
+ const: 2
+
+ ranges: true
+
clocks:
maxItems: 29
@@ -130,6 +138,16 @@ properties:
description:
1.2V supply to a PHY.
+ phys:
+ maxItems: 4
+
+ phy-names:
+ items:
+ - const: csiphy0
+ - const: csiphy1
+ - const: csiphy2
+ - const: csiphy4
+
ports:
$ref: /schemas/graph.yaml#/properties/ports
@@ -162,6 +180,14 @@ properties:
required:
- data-lanes
+patternProperties:
+ "^phy@[0-9a-f]+$":
+ $ref: /schemas/phy/qcom,x1e80100-csi2-phy.yaml
+ unevaluatedProperties: false
+
+ "^opp-table(-.*)?$":
+ type: object
+
required:
- compatible
- reg
@@ -175,8 +201,6 @@ required:
- iommus
- power-domains
- power-domain-names
- - vdd-csiphy-0p8-supply
- - vdd-csiphy-1p2-supply
- ports
additionalProperties: false
@@ -188,6 +212,7 @@ examples:
#include <dt-bindings/clock/qcom,x1e80100-camcc.h>
#include <dt-bindings/interconnect/qcom,icc.h>
#include <dt-bindings/interconnect/qcom,x1e80100-rpmh.h>
+ #include <dt-bindings/phy/phy.h>
#include <dt-bindings/power/qcom-rpmpd.h>
soc {
@@ -233,6 +258,10 @@ examples:
"vfe_lite0",
"vfe_lite1";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
clocks = <&camcc CAM_CC_CAMNOC_AXI_NRT_CLK>,
<&camcc CAM_CC_CAMNOC_AXI_RT_CLK>,
<&camcc CAM_CC_CORE_AHB_CLK>,
--
2.52.0On Mon, Mar 16, 2026 at 01:02:02AM +0000, Bryan O'Donoghue wrote:
> Add optional PHY handle definitions. This will allow for supporting both
> legacy PHY definitions as well as supporting the optional new handle based
> approach.
>
> Drop the legacy high-level 0p8 and 1p2 supplies as required, each PHY has
> its own individual rails. The old binding is still valid but with
> individual nodes we define the rails in the CSIPHY sub-nodes.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/media/qcom,x1e80100-camss.yaml | 33 ++++++++++++++++++++--
> 1 file changed, 31 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> index b5654ef71bd89..5442f981baebc 100644
> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> @@ -43,6 +43,14 @@ properties:
> - const: vfe_lite0
> - const: vfe_lite1
>
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
> +
> + ranges: true
> +
> clocks:
> maxItems: 29
>
> @@ -130,6 +138,16 @@ properties:
> description:
> 1.2V supply to a PHY.
>
> + phys:
> + maxItems: 4
> +
> + phy-names:
> + items:
> + - const: csiphy0
> + - const: csiphy1
> + - const: csiphy2
> + - const: csiphy4
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -162,6 +180,14 @@ properties:
> required:
> - data-lanes
>
> +patternProperties:
> + "^phy@[0-9a-f]+$":
> + $ref: /schemas/phy/qcom,x1e80100-csi2-phy.yaml
> + unevaluatedProperties: false
> +
> + "^opp-table(-.*)?$":
Why do you expect multiple opp-tables?
And where are operating-points phandle? Please look how other bindings
do it.
> + type: object
> +
> required:
> - compatible
> - reg
> @@ -175,8 +201,6 @@ required:
> - iommus
> - power-domains
> - power-domain-names
> - - vdd-csiphy-0p8-supply
> - - vdd-csiphy-1p2-supply
> - ports
>
> additionalProperties: false
> @@ -188,6 +212,7 @@ examples:
> #include <dt-bindings/clock/qcom,x1e80100-camcc.h>
> #include <dt-bindings/interconnect/qcom,icc.h>
> #include <dt-bindings/interconnect/qcom,x1e80100-rpmh.h>
> + #include <dt-bindings/phy/phy.h>
> #include <dt-bindings/power/qcom-rpmpd.h>
>
> soc {
> @@ -233,6 +258,10 @@ examples:
> "vfe_lite0",
> "vfe_lite1";
>
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
Again, incomplete example. Where the the phy?
> +
> clocks = <&camcc CAM_CC_CAMNOC_AXI_NRT_CLK>,
> <&camcc CAM_CC_CAMNOC_AXI_RT_CLK>,
> <&camcc CAM_CC_CORE_AHB_CLK>,
>
> --
> 2.52.0
>
On 16/03/2026 07:31, Krzysztof Kozlowski wrote:
>> +patternProperties:
>> + "^phy@[0-9a-f]+$":
>> + $ref: /schemas/phy/qcom,x1e80100-csi2-phy.yaml
>> + unevaluatedProperties: false
>> +
>> + "^opp-table(-.*)?$":
> Why do you expect multiple opp-tables?
>
> And where are operating-points phandle? Please look how other bindings
> do it.
>
>> + type: object
>> +
>> required:
>> - compatible
>> - reg
>> @@ -175,8 +201,6 @@ required:
>> - iommus
>> - power-domains
>> - power-domain-names
>> - - vdd-csiphy-0p8-supply
>> - - vdd-csiphy-1p2-supply
>> - ports
>>
>> additionalProperties: false
>> @@ -188,6 +212,7 @@ examples:
>> #include <dt-bindings/clock/qcom,x1e80100-camcc.h>
>> #include <dt-bindings/interconnect/qcom,icc.h>
>> #include <dt-bindings/interconnect/qcom,x1e80100-rpmh.h>
>> + #include <dt-bindings/phy/phy.h>
>> #include <dt-bindings/power/qcom-rpmpd.h>
>>
>> soc {
>> @@ -233,6 +258,10 @@ examples:
>> "vfe_lite0",
>> "vfe_lite1";
>>
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges;
> Again, incomplete example. Where the the phy?
Both of these q's can be answered by adding a phys to the example, which
I will do.
---
bod
On Mon, 16 Mar 2026 01:02:02 +0000, Bryan O'Donoghue wrote: > Add optional PHY handle definitions. This will allow for supporting both > legacy PHY definitions as well as supporting the optional new handle based > approach. > > Drop the legacy high-level 0p8 and 1p2 supplies as required, each PHY has > its own individual rails. The old binding is still valid but with > individual nodes we define the rails in the CSIPHY sub-nodes. > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/media/qcom,x1e80100-camss.yaml | 33 ++++++++++++++++++++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml: Unresolvable reference: /schemas/phy/qcom,x1e80100-csi2-phy.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260316-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v10-2-fdfe984fe941@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 3/16/26 03:02, Bryan O'Donoghue wrote:
> Add optional PHY handle definitions. This will allow for supporting both
> legacy PHY definitions as well as supporting the optional new handle based
> approach.
>
> Drop the legacy high-level 0p8 and 1p2 supplies as required, each PHY has
> its own individual rails. The old binding is still valid but with
> individual nodes we define the rails in the CSIPHY sub-nodes.
The new proposed CSIPHY device tree nodes should be outside of CAMSS
device tree node.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/media/qcom,x1e80100-camss.yaml | 33 ++++++++++++++++++++--
> 1 file changed, 31 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> index b5654ef71bd89..5442f981baebc 100644
> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml
> @@ -43,6 +43,14 @@ properties:
> - const: vfe_lite0
> - const: vfe_lite1
>
> + '#address-cells':
> + const: 2
> +
> + '#size-cells':
> + const: 2
> +
> + ranges: true
> +
> clocks:
> maxItems: 29
>
> @@ -130,6 +138,16 @@ properties:
> description:
> 1.2V supply to a PHY.
>
> + phys:
> + maxItems: 4
> +
> + phy-names:
> + items:
> + - const: csiphy0
> + - const: csiphy1
> + - const: csiphy2
> + - const: csiphy4
> +
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
>
> @@ -162,6 +180,14 @@ properties:
> required:
> - data-lanes
>
> +patternProperties:
> + "^phy@[0-9a-f]+$":
CSIPHY device tree nodes shall be put outside of CAMSS device tree node.
> + $ref: /schemas/phy/qcom,x1e80100-csi2-phy.yaml
> + unevaluatedProperties: false
> +
> + "^opp-table(-.*)?$":
> + type: object
> +
> required:
> - compatible
> - reg
> @@ -175,8 +201,6 @@ required:
> - iommus
> - power-domains
> - power-domain-names
> - - vdd-csiphy-0p8-supply
> - - vdd-csiphy-1p2-supply
> - ports
>
> additionalProperties: false
> @@ -188,6 +212,7 @@ examples:
> #include <dt-bindings/clock/qcom,x1e80100-camcc.h>
> #include <dt-bindings/interconnect/qcom,icc.h>
> #include <dt-bindings/interconnect/qcom,x1e80100-rpmh.h>
> + #include <dt-bindings/phy/phy.h>
> #include <dt-bindings/power/qcom-rpmpd.h>
>
> soc {
> @@ -233,6 +258,10 @@ examples:
> "vfe_lite0",
> "vfe_lite1";
>
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
Here 'ranges' machnery is unexpected, the new proposed CSIPHY devices shall
be described outside of CAMSS device tree node, as it's stated above.
CAMSS is supposed to become a consumer of CSIPHYs, see phy-bindings.txt
for 'phys' property.
> +
> clocks = <&camcc CAM_CC_CAMNOC_AXI_NRT_CLK>,
> <&camcc CAM_CC_CAMNOC_AXI_RT_CLK>,
> <&camcc CAM_CC_CORE_AHB_CLK>,
>
--
Best wishes,
Vladimir
On Mon, Mar 16, 2026 at 04:07:43AM +0200, Vladimir Zapolskiy wrote: > On 3/16/26 03:02, Bryan O'Donoghue wrote: > > Add optional PHY handle definitions. This will allow for supporting both > > legacy PHY definitions as well as supporting the optional new handle based > > approach. > > > > Drop the legacy high-level 0p8 and 1p2 supplies as required, each PHY has > > its own individual rails. The old binding is still valid but with > > individual nodes we define the rails in the CSIPHY sub-nodes. > > The new proposed CSIPHY device tree nodes should be outside of CAMSS > device tree node. Why? > > > > > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > > --- > > .../bindings/media/qcom,x1e80100-camss.yaml | 33 ++++++++++++++++++++-- > > 1 file changed, 31 insertions(+), 2 deletions(-) > > -- With best wishes Dmitry
© 2016 - 2026 Red Hat, Inc.