.../devicetree/bindings/sound/adi,ssm2305.txt | 14 ------ .../bindings/sound/adi,ssm2305.yaml | 46 +++++++++++++++++++ 2 files changed, 46 insertions(+), 14 deletions(-) delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
Convert the SSM2305 speaker amplifier binding from text format to
YAML schema to enable dtbs_check validation.
Remove the legacy text binding.
Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
---
.../devicetree/bindings/sound/adi,ssm2305.txt | 14 ------
.../bindings/sound/adi,ssm2305.yaml | 46 +++++++++++++++++++
2 files changed, 46 insertions(+), 14 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt b/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
deleted file mode 100644
index a9c9d83c8a30..000000000000
--- a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
+++ /dev/null
@@ -1,14 +0,0 @@
-Analog Devices SSM2305 Speaker Amplifier
-========================================
-
-Required properties:
- - compatible : "adi,ssm2305"
- - shutdown-gpios : The gpio connected to the shutdown pin.
- The gpio signal is ACTIVE_LOW.
-
-Example:
-
-ssm2305: analog-amplifier {
- compatible = "adi,ssm2305";
- shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
-};
diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
new file mode 100644
index 000000000000..b841da2dc284
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/adi,ssm2305.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices SSM2305 Class-D Speaker Amplifier
+
+maintainers:
+ - Lars-Peter Clausen <lars@metafoo.de>
+
+description:
+ The SSM2305 is a filterless, high efficiency, mono 2.8 W Class-D
+ audio amplifier with a micropower shutdown mode controlled via a
+ dedicated active-low GPIO pin.
+
+allOf:
+ - $ref: dai-common.yaml#
+
+properties:
+ compatible:
+ const: adi,ssm2305
+
+ shutdown-gpios:
+ maxItems: 1
+ description:
+ GPIO connected to the shutdown pin (SD) of the SSM2305.
+ The pin is active-low; asserting it puts the device into
+ micropower shutdown mode.
+
+required:
+ - compatible
+ - shutdown-gpios
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ analog-amplifier {
+ compatible = "adi,ssm2305";
+ shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
+ };
+
+...
--
2.34.1
On Mon, Mar 16, 2026 at 03:24:47AM +0530, Piyush Patle wrote: > Convert the SSM2305 speaker amplifier binding from text format to > YAML schema to enable dtbs_check validation. > > Remove the legacy text binding. Drop, irrelevant. "Convert" means that already. Please use subject prefixes matching the subsystem. You can get them for example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters With these fixed: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof
> Please use subject prefixes matching the subsystem. You can get them for
> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> With these fixed:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Thank you for the review!
I checked the subject prefix using 'git log --oneline --
Documentation/devicetree/bindings/sound/' and found that the correct
prefix should be:
ASoC: dt-bindings: adi,ssm2305: Convert to DT schema
Should I send a v2 with this fix, or can the maintainer apply v1 with
the subject corrected?
Best regards,
Piyush
On 16/03/2026 20:54, Piyush Patle wrote: >> Please use subject prefixes matching the subsystem. You can get them for >> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory >> your patch is touching. For bindings, the preferred subjects are >> explained here: >> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters >> >> With these fixed: >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > > Thank you for the review! > > I checked the subject prefix using 'git log --oneline -- > Documentation/devicetree/bindings/sound/' and found that the correct > prefix should be: > > ASoC: dt-bindings: adi,ssm2305: Convert to DT schema Yes > > Should I send a v2 with this fix, or can the maintainer apply v1 with > the subject corrected? Please send v2, unless you got message that it was already applied. Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.