HX83121A is a driver IC used to drive MIPI-DSI panels. It is found
in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels.
Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
v3:
- remove '|' from description (Krzysztof)
- drop description for reset-gpios (Krzysztof)
---
.../display/panel/himax,hx83121a.yaml | 86 +++++++++++++++++++
1 file changed, 86 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml
new file mode 100644
index 0000000000..603e3ad85b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml
@@ -0,0 +1,86 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/himax,hx83121a.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Himax HX83121A based DSI display Panels
+
+maintainers:
+ - Pengyu Luo <mitltlatltl@gmail.com>
+
+description:
+ The Himax HX83121A is a generic DSI Panel IC used to drive dsi
+ panels. Support video mode panels from China Star Optoelectronics
+ Technology (CSOT) and BOE Technology.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - boe,ppc357db1-4
+ - csot,ppc357db1-4
+ - const: himax,hx83121a
+
+ reg:
+ maxItems: 1
+
+ reset-gpios:
+ maxItems: 1
+
+ avdd-supply:
+ description: analog positive supply for IC
+
+ avee-supply:
+ description: analog negative supply for IC
+
+ vddi-supply:
+ description: power supply for IC
+
+ backlight: true
+
+required:
+ - compatible
+ - reg
+ - vddi-supply
+ - reset-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "csot,ppc357db1-4", "himax,hx83121a";
+ reg = <0>;
+
+ vddi-supply = <&vreg_l2b>;
+ reset-gpios = <&tlmm 38 GPIO_ACTIVE_LOW>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ panel_in_0: endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
+ };
+
+ port@1{
+ reg = <1>;
+ panel_in_1: endpoint {
+ remote-endpoint = <&dsi1_out>;
+ };
+ };
+ };
+ };
+ };
+
+...
--
2.53.0On Sun, Mar 15, 2026 at 10:45:35PM +0800, Pengyu Luo wrote: > HX83121A is a driver IC used to drive MIPI-DSI panels. It is found > in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels. > > Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > --- > v3: > - remove '|' from description (Krzysztof) > - drop description for reset-gpios (Krzysztof) And all other changes? Why aren't you testing this code? NAK, drop the tag and request re-review. Best regards, Krzysztof
On Mon, Mar 16, 2026 at 3:44 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Sun, Mar 15, 2026 at 10:45:35PM +0800, Pengyu Luo wrote: > > HX83121A is a driver IC used to drive MIPI-DSI panels. It is found > > in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels. > > > > Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > > --- > > v3: > > - remove '|' from description (Krzysztof) > > - drop description for reset-gpios (Krzysztof) > > And all other changes? > > Why aren't you testing this code? > > NAK, drop the tag and request re-review. > I see. I will send a new version later. I made changes to v1 binding by mistake. Best wishes, Pengyu
On 16/03/2026 09:02, Pengyu Luo wrote: > On Mon, Mar 16, 2026 at 3:44 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >> >> On Sun, Mar 15, 2026 at 10:45:35PM +0800, Pengyu Luo wrote: >>> HX83121A is a driver IC used to drive MIPI-DSI panels. It is found >>> in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels. >>> >>> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> >>> --- >>> v3: >>> - remove '|' from description (Krzysztof) >>> - drop description for reset-gpios (Krzysztof) >> >> And all other changes? >> >> Why aren't you testing this code? >> >> NAK, drop the tag and request re-review. >> > > I see. I will send a new version later. I made changes to v1 binding by mistake. And EVERY patch you sent must be build tested, which would tell you that you made mistakes. Why do you think build testing your code is our task? Best regards, Krzysztof
On Mon, Mar 16, 2026 at 4:15 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 16/03/2026 09:02, Pengyu Luo wrote: > > On Mon, Mar 16, 2026 at 3:44 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> > >> On Sun, Mar 15, 2026 at 10:45:35PM +0800, Pengyu Luo wrote: > >>> HX83121A is a driver IC used to drive MIPI-DSI panels. It is found > >>> in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels. > >>> > >>> Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > >>> --- > >>> v3: > >>> - remove '|' from description (Krzysztof) > >>> - drop description for reset-gpios (Krzysztof) > >> > >> And all other changes? > >> > >> Why aren't you testing this code? > >> > >> NAK, drop the tag and request re-review. > >> > > > > I see. I will send a new version later. I made changes to v1 binding by mistake. > > And EVERY patch you sent must be build tested, which would tell you that > you made mistakes. Why do you think build testing your code is our task? > Thanks for your suggestion. I will remember that. I thought removing the descriptions would not break things since I tested the binding in v2, until I found I was using the wrong base. Best wishes, Pengyu
On Sun, 15 Mar 2026 22:45:35 +0800, Pengyu Luo wrote: > HX83121A is a driver IC used to drive MIPI-DSI panels. It is found > in HUAWEI Matebook E Go series (Gaokun2/3) with BOE or CSOT panels. > > Signed-off-by: Pengyu Luo <mitltlatltl@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> > --- > v3: > - remove '|' from description (Krzysztof) > - drop description for reset-gpios (Krzysztof) > --- > .../display/panel/himax,hx83121a.yaml | 86 +++++++++++++++++++ > 1 file changed, 86 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx83121a.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/panel/himax,hx83121a.example.dtb: panel@0 (csot,ppc357db1-4): 'ports' does not match any of the regexes: '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/display/panel/himax,hx83121a.yaml doc reference errors (make refcheckdocs): See https://patchwork.kernel.org/project/devicetree/patch/20260315144536.515032-2-mitltlatltl@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
© 2016 - 2026 Red Hat, Inc.