[PATCH] staging: vme_user: fix missing blank line after declaration

Giacomo Di Clerico posted 1 patch 3 weeks, 2 days ago
drivers/staging/vme_user/vme_tsi148.h | 1 +
1 file changed, 1 insertion(+)
[PATCH] staging: vme_user: fix missing blank line after declaration
Posted by Giacomo Di Clerico 3 weeks, 2 days ago
Add a blank line between the last variable declaration and the
function pointer declaration in struct tsi148_driver, as required
by the kernel coding style.

Signed-off-by: Giacomo Di Clerico <giacomodiclerico@gmail.com>
---
 drivers/staging/vme_user/vme_tsi148.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
index f73ac92320bb..3102b94a0a86 100644
--- a/drivers/staging/vme_user/vme_tsi148.h
+++ b/drivers/staging/vme_user/vme_tsi148.h
@@ -34,6 +34,7 @@ struct tsi148_driver {
 	void __iomem *base;	/* Base Address of device registers */
 	wait_queue_head_t dma_queue[2];
 	wait_queue_head_t iack_queue;
+
 	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
 	void *lm_data[4];
 	void *crcsr_kernel;
-- 
2.53.0
Re: [PATCH] staging: vme_user: fix missing blank line after declaration
Posted by Greg KH 3 weeks, 1 day ago
On Sat, Mar 14, 2026 at 11:05:03PM +0100, Giacomo Di Clerico wrote:
> Add a blank line between the last variable declaration and the
> function pointer declaration in struct tsi148_driver, as required
> by the kernel coding style.
> 
> Signed-off-by: Giacomo Di Clerico <giacomodiclerico@gmail.com>
> ---
>  drivers/staging/vme_user/vme_tsi148.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index f73ac92320bb..3102b94a0a86 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
>  	void __iomem *base;	/* Base Address of device registers */
>  	wait_queue_head_t dma_queue[2];
>  	wait_queue_head_t iack_queue;
> +
>  	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
>  	void *lm_data[4];
>  	void *crcsr_kernel;

This is all a list of variables, no need for an extra line here.

thanks,

greg k-h