staging: rtl8723bs: rename 'status' variable to 'ret' for consistency

[PATCH] staging: rtl8723bs: rename 'status' variable to 'ret' for consistency

Posted by Omer El Idrissi 3 weeks, 2 days ago

The kernel commonly uses 'ret', 'retval', 'err' etc. for return value
tracking. No functional change intended beyond style and error handling
improvement.

Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e254912c..dbcde683789d 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -345,7 +345,7 @@ static int rtw_drv_init(
 	struct sdio_func *func,
 	const struct sdio_device_id *id)
 {
-	int status = _FAIL;
+	int ret = _FAIL;
 	struct adapter *if1 = NULL;
 	struct dvobj_priv *dvobj;
 
@@ -358,25 +358,25 @@ static int rtw_drv_init(
 		goto free_dvobj;
 
 	/* dev_alloc_name && register_netdev */
-	status = rtw_drv_register_netdev(if1);
-	if (status != _SUCCESS)
+	ret = rtw_drv_register_netdev(if1);
+	if (ret != _SUCCESS)
 		goto free_if1;
 
-	status = sdio_alloc_irq(dvobj);
-	if (status != _SUCCESS)
+	ret = sdio_alloc_irq(dvobj);
+	if (ret != _SUCCESS)
 		goto free_if1;
 
-	status = _SUCCESS;
+	ret = _SUCCESS;
 
 free_if1:
-	if (status != _SUCCESS && if1)
+	if (ret != _SUCCESS && if1)
 		rtw_sdio_if1_deinit(if1);
 
 free_dvobj:
-	if (status != _SUCCESS)
+	if (ret != _SUCCESS)
 		sdio_dvobj_deinit(func);
 exit:
-	return status == _SUCCESS ? 0 : -ENODEV;
+	return ret == _SUCCESS ? 0 : -ENODEV;
 }
 
 static void rtw_dev_remove(struct sdio_func *func)
-- 
2.51.0

Re: [PATCH] staging: rtl8723bs: rename 'status' variable to 'ret' for consistency

Posted by Dan Carpenter 3 weeks ago

On Sat, Mar 14, 2026 at 05:56:00PM +0100, Omer El Idrissi wrote:
> The kernel commonly uses 'ret', 'retval', 'err' etc. for return value
> tracking. No functional change intended beyond style and error handling
> improvement.
> 
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---
>  drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..dbcde683789d 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -345,7 +345,7 @@ static int rtw_drv_init(
>  	struct sdio_func *func,
>  	const struct sdio_device_id *id)
>  {
> -	int status = _FAIL;
> +	int ret = _FAIL;

status is actually better because these are non-standard error codes.
First fix that, then rename the variables to ret.

regards,
dan carpenter

Re: [PATCH] staging: rtl8723bs: rename 'status' variable to 'ret' for consistency

Posted by Ethan Tidmore 3 weeks, 2 days ago

On Sat Mar 14, 2026 at 11:56 AM CDT, Omer El Idrissi wrote:
> The kernel commonly uses 'ret', 'retval', 'err' etc. for return value
> tracking. No functional change intended beyond style and error handling
> improvement.
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---

I think the code is fine as is.

Thanks,

ET