media: cx25821-alsa: replace BUG_ON() with WARN_ON()

[PATCH] media: cx25821-alsa: replace BUG_ON() with WARN_ON()

Posted by Atharv Dubey 3 weeks, 3 days ago

media: cx25821-alsa: replace BUG_ON() with WARN_ON()

Avoid crashing the kernel for a recoverable condition
by replacing BUG_ON() with WARN_ON().

Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
---
 drivers/media/pci/cx25821/cx25821-alsa.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/pci/cx25821/cx25821-alsa.c b/drivers/media/pci/cx25821/cx25821-alsa.c
index 3f73391f9098..4fdc59aaed8e 100644
--- a/drivers/media/pci/cx25821/cx25821-alsa.c
+++ b/drivers/media/pci/cx25821/cx25821-alsa.c
@@ -397,7 +397,7 @@ static int dsp_buffer_free(struct cx25821_audio_dev *chip)
 {
 	struct cx25821_riscmem *risc = &chip->buf->risc;
 
-	BUG_ON(!chip->dma_size);
+	WARN_ON(!chip->dma_size);
 
 	dprintk(2, "Freeing buffer\n");
 	cx25821_alsa_dma_unmap(chip);
@@ -509,8 +509,8 @@ static int snd_cx25821_hw_params(struct snd_pcm_substream *substream,
 	chip->num_periods = params_periods(hw_params);
 	chip->dma_size = chip->period_size * params_periods(hw_params);
 
-	BUG_ON(!chip->dma_size);
-	BUG_ON(chip->num_periods & (chip->num_periods - 1));
+	WARN_ON(!chip->dma_size);
+	WARN_ON(chip->num_periods & (chip->num_periods - 1));
 
 	buf = kzalloc_obj(*buf);
 	if (NULL == buf)

---
base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a
change-id: 20260314-media-52caee1b1f7f

Best regards,
-- 
Atharv Dubey <atharvd440@gmail.com>

Re: [PATCH] media: cx25821-alsa: replace BUG_ON() with WARN_ON()

Posted by Atharv Dubey 2 weeks, 4 days ago

A Gentle Reminder for reviewing the patch.

Thanks,
Atharv

On 3/14/26 02:02, Atharv Dubey wrote:
> media: cx25821-alsa: replace BUG_ON() with WARN_ON()
>
> Avoid crashing the kernel for a recoverable condition
> by replacing BUG_ON() with WARN_ON().
>
> Signed-off-by: Atharv Dubey <atharvd440@gmail.com>
> ---
>   drivers/media/pci/cx25821/cx25821-alsa.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/pci/cx25821/cx25821-alsa.c b/drivers/media/pci/cx25821/cx25821-alsa.c
> index 3f73391f9098..4fdc59aaed8e 100644
> --- a/drivers/media/pci/cx25821/cx25821-alsa.c
> +++ b/drivers/media/pci/cx25821/cx25821-alsa.c
> @@ -397,7 +397,7 @@ static int dsp_buffer_free(struct cx25821_audio_dev *chip)
>   {
>   	struct cx25821_riscmem *risc = &chip->buf->risc;
>   
> -	BUG_ON(!chip->dma_size);
> +	WARN_ON(!chip->dma_size);
>   
>   	dprintk(2, "Freeing buffer\n");
>   	cx25821_alsa_dma_unmap(chip);
> @@ -509,8 +509,8 @@ static int snd_cx25821_hw_params(struct snd_pcm_substream *substream,
>   	chip->num_periods = params_periods(hw_params);
>   	chip->dma_size = chip->period_size * params_periods(hw_params);
>   
> -	BUG_ON(!chip->dma_size);
> -	BUG_ON(chip->num_periods & (chip->num_periods - 1));
> +	WARN_ON(!chip->dma_size);
> +	WARN_ON(chip->num_periods & (chip->num_periods - 1));
>   
>   	buf = kzalloc_obj(*buf);
>   	if (NULL == buf)
>
> ---
> base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a
> change-id: 20260314-media-52caee1b1f7f
>
> Best regards,