The FP9931 requires a vin power supply to operate, so mark vin-supply as
a required property in the binding.

Fixes: 80bbdefdfb417 ("dt-bindings: regulator: Add Fitipower FP9931/JD9930")
Signed-off-by: Robby Cai <robby.cai@nxp.com>
---
 .../devicetree/bindings/regulator/fitipower,fp9931.yaml          | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/regulator/fitipower,fp9931.yaml b/Documentation/devicetree/bindings/regulator/fitipower,fp9931.yaml
index c6585e3bacbec..00d66b9230475 100644
--- a/Documentation/devicetree/bindings/regulator/fitipower,fp9931.yaml
+++ b/Documentation/devicetree/bindings/regulator/fitipower,fp9931.yaml
@@ -66,6 +66,7 @@ properties:
 required:
   - compatible
   - reg
+  - vin-supply
   - pg-gpios
   - enable-gpios
 
-- 
2.37.1

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

On Fri, Mar 13, 2026 at 09:31:01PM +0800, Robby Cai wrote:
> The FP9931 requires a vin power supply to operate, so mark vin-supply as
> a required property in the binding.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

On Fri, 13 Mar 2026 13:33:36 +0000
Mark Brown <broonie@kernel.org> wrote:

> On Fri, Mar 13, 2026 at 09:31:01PM +0800, Robby Cai wrote:
> > The FP9931 requires a vin power supply to operate, so mark vin-supply as
> > a required property in the binding.  
> 
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.
> Look at what existing commits in the area you're changing are doing and
> make sure your subject lines visually resemble what they're doing.
> There's no need to resubmit to fix this alone.

in short words (but manually typed, so time-consuming):
s/dt-bindings: regulator:/regulator: dt-bindings:/

Since I once have misunderstood that text block myself:
- this sounds like you are talking about the subject line as a whole
  and not only the prefix.

- Looking at common practice:
   git log  --pretty=format:%s  -- Documentation/devicetree/bindings/regulator/ | sed 's/^\([^:]*\):\([^:]*\):.*/\1:\2/'  | grep binding | head -n 100 | sort | uniq -c
   shows (besides random other stuff) around 70% "regulator: dt-bindings" and 30% "dt-bindings: regulator"
   so chances are that people might see a bunch of "dt-bindings: regulator" (happened to me once)
   if they do not invest time in doing proper statistic, I hove once thought: my prefix is right,
   so lets try to adjust the wording.

- for an unbiased reader, reading
  Documentation/devicetree/bindings/submitting-patches.rst helps

Maybe that helps to reduce some unnecessary churn in the future

Regards,
Andreas

On Fri, Mar 13, 2026 at 03:16:43PM +0100, Andreas Kemnade wrote:
> Mark Brown <broonie@kernel.org> wrote:

> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.

> Since I once have misunderstood that text block myself:
> - this sounds like you are talking about the subject line as a whole
>   and not only the prefix.

It *might* be the rest of the subject line as well, very much less often
but it does happen (excessively long lines for example).