The FP9931 regulator requires a valid "vin" supply to operate correctly.
Therefore, the driver should treat "vin" as a mandatory supply.

This patchset updates the binding documentation to mark vin-supply as a
required property, and modifies the driver accordingly. As suggested in
the reviews from Andreas and Mark, v2 switches to using
devm_regulator_get() since the supply is mandatory.

Changes in v2:
  - Addressed feedback from Andreas and Mark by replacing
    devm_regulator_get_optional() with devm_regulator_get()
    because VIN is required.
  - Added a new patch updating the binding documentation to make
    vin-supply a required property.

v1: https://patchwork.kernel.org/project/imx/patch/20260312040148.GA4007088@shlinux88/

Robby Cai (2):
  dt-bindings: regulator: fitipower,fp9931: Make vin-supply property as
    required
  regulator: fp9931: Fix handling of mandatory "vin" supply

 .../devicetree/bindings/regulator/fitipower,fp9931.yaml         | 1 +
 drivers/regulator/fp9931.c                                      | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.37.1

On Fri, 13 Mar 2026 21:31:00 +0800, Robby Cai wrote:
> regulator: fp9931: Make vin-supply mandatory
> 
> The FP9931 regulator requires a valid "vin" supply to operate correctly.
> Therefore, the driver should treat "vin" as a mandatory supply.
> 
> This patchset updates the binding documentation to mark vin-supply as a
> required property, and modifies the driver accordingly. As suggested in
> the reviews from Andreas and Mark, v2 switches to using
> devm_regulator_get() since the supply is mandatory.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-7.1

Thanks!

[1/2] dt-bindings: regulator: fp9931: Make vin-supply property as required
      https://git.kernel.org/broonie/regulator/c/d342f5e355aa
[2/2] regulator: fp9931: Fix handling of mandatory "vin" supply
      https://git.kernel.org/broonie/regulator/c/58068932402c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

On Fri, 13 Mar 2026 21:31:00 +0800, Robby Cai wrote:
> The FP9931 regulator requires a valid "vin" supply to operate correctly.
> Therefore, the driver should treat "vin" as a mandatory supply.
> 
> This patchset updates the binding documentation to mark vin-supply as a
> required property, and modifies the driver accordingly. As suggested in
> the reviews from Andreas and Mark, v2 switches to using
> devm_regulator_get() since the supply is mandatory.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] dt-bindings: regulator: fp9931: Make vin-supply property as required
      https://git.kernel.org/broonie/misc/c/d342f5e355aa
[2/2] regulator: fp9931: Fix handling of mandatory "vin" supply
      https://git.kernel.org/broonie/misc/c/58068932402c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

On Fri, Mar 13, 2026 at 09:31:00PM +0800, Robby Cai wrote:
> The FP9931 regulator requires a valid "vin" supply to operate correctly.
> Therefore, the driver should treat "vin" as a mandatory supply.
> 
> This patchset updates the binding documentation to mark vin-supply as a
> required property, and modifies the driver accordingly. As suggested in
> the reviews from Andreas and Mark, v2 switches to using
> devm_regulator_get() since the supply is mandatory.

Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code.  Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.

On Fri, Mar 13, 2026 at 01:31:23PM +0000, Mark Brown wrote:
> On Fri, Mar 13, 2026 at 09:31:00PM +0800, Robby Cai wrote:
> > The FP9931 regulator requires a valid "vin" supply to operate correctly.
> > Therefore, the driver should treat "vin" as a mandatory supply.

> > This patchset updates the binding documentation to mark vin-supply as a
> > required property, and modifies the driver accordingly. As suggested in
> > the reviews from Andreas and Mark, v2 switches to using
> > devm_regulator_get() since the supply is mandatory.

> Please do not submit new versions of already applied patches, please
> submit incremental updates to the existing code.  Modifying existing
> commits creates problems for other users building on top of those
> commits so it's best practice to only change pubished git commits if
> absolutely essential.

Your v1 was at the tip of the branch so I did actually just drop it, but
please don't do this.

On Fri, Mar 13, 2026 at 04:27:21PM +0000, Mark Brown wrote:
> On Fri, Mar 13, 2026 at 01:31:23PM +0000, Mark Brown wrote:
> > On Fri, Mar 13, 2026 at 09:31:00PM +0800, Robby Cai wrote:
> > > The FP9931 regulator requires a valid "vin" supply to operate correctly.
> > > Therefore, the driver should treat "vin" as a mandatory supply.
> 
> > > This patchset updates the binding documentation to mark vin-supply as a
> > > required property, and modifies the driver accordingly. As suggested in
> > > the reviews from Andreas and Mark, v2 switches to using
> > > devm_regulator_get() since the supply is mandatory.
> 
> > Please do not submit new versions of already applied patches, please
> > submit incremental updates to the existing code.  Modifying existing
> > commits creates problems for other users building on top of those
> > commits so it's best practice to only change pubished git commits if
> > absolutely essential.
> 
> Your v1 was at the tip of the branch so I did actually just drop it, but
> please don't do this.

Thanks for the clarification.

Just to confirm: since you already dropped the v1 from your tree,
does that mean I should wait and only send an incremental patch
when there is a further change needed?

Regards,
Robby

On Mon, Mar 16, 2026 at 03:31:25PM +0800, Robby Cai wrote:
> On Fri, Mar 13, 2026 at 04:27:21PM +0000, Mark Brown wrote:

> > Your v1 was at the tip of the branch so I did actually just drop it, but
> > please don't do this.

> Thanks for the clarification.

> Just to confirm: since you already dropped the v1 from your tree,
> does that mean I should wait and only send an incremental patch
> when there is a further change needed?

Yes, exactly.