[PATCH net-next] net: enetc: remove stray semicolon

Wei Fang posted 1 patch 3 weeks, 3 days ago
drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH net-next] net: enetc: remove stray semicolon
Posted by Wei Fang 3 weeks, 3 days ago
Remove stray semicolon from ntmp_table_name().

Signed-off-by: Wei Fang <wei.fang@nxp.com>
---
 drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/ntmp.c b/drivers/net/ethernet/freescale/enetc/ntmp.c
index 0c1d343253bf..703752995e93 100644
--- a/drivers/net/ethernet/freescale/enetc/ntmp.c
+++ b/drivers/net/ethernet/freescale/enetc/ntmp.c
@@ -227,7 +227,7 @@ static const char *ntmp_table_name(int tbl_id)
 		return "RSS Table";
 	default:
 		return "Unknown Table";
-	};
+	}
 }
 
 static int ntmp_delete_entry_by_id(struct ntmp_user *user, int tbl_id,
-- 
2.34.1
Re: [PATCH net-next] net: enetc: remove stray semicolon
Posted by Joe Damato 3 weeks, 3 days ago
On Fri, Mar 13, 2026 at 07:24:54PM +0800, Wei Fang wrote:
> Remove stray semicolon from ntmp_table_name().
> 
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
>  drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Hm, I'm not sure, but I suspect this might be rejected due to the note about
cleanup in the docs, which generally seems to discourage this sort of thing:

https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
Re: [PATCH net-next] net: enetc: remove stray semicolon
Posted by Vladimir Oltean 3 weeks, 3 days ago
On Fri, Mar 13, 2026 at 05:09:46PM -0700, Joe Damato wrote:
> On Fri, Mar 13, 2026 at 07:24:54PM +0800, Wei Fang wrote:
> > Remove stray semicolon from ntmp_table_name().
> >
> > Signed-off-by: Wei Fang <wei.fang@nxp.com>
> > ---
> >  drivers/net/ethernet/freescale/enetc/ntmp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> 
> Hm, I'm not sure, but I suspect this might be rejected due to the note about
> cleanup in the docs, which generally seems to discourage this sort of thing:
> 
> https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches

"simple clean-ups, which are not in the context of other work"

The ENETC NTMP code is under active development, and Wei is developing it.
The semicolon was added in May last year and was found as part of other
review touching that area.