Fix redundant hyphen in "amlogic,t7-gp1--pll" string.
Fixes: 5437753728ac ("dt-bindings: clock: add Amlogic T7 PLL clock controller")
Signed-off-by: Jian Hu <jian.hu@amlogic.com>
Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
---
.../devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
index 49c61f65deff..b488d92b7984 100644
--- a/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
+++ b/Documentation/devicetree/bindings/clock/amlogic,t7-pll-clkc.yaml
@@ -72,7 +72,7 @@ allOf:
contains:
enum:
- amlogic,t7-gp0-pll
- - amlogic,t7-gp1--pll
+ - amlogic,t7-gp1-pll
- amlogic,t7-hifi-pll
- amlogic,t7-pcie-pll
- amlogic,t7-mpll
--
2.47.1
On Fri, Mar 13, 2026 at 03:00:20PM +0800, Jian Hu wrote:
> Fix redundant hyphen in "amlogic,t7-gp1--pll" string.
>
> Fixes: 5437753728ac ("dt-bindings: clock: add Amlogic T7 PLL clock controller")
> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
Incorrect DCO chain. I don't understand what Ronald's SoB is doing here.
Please read submitting patches document to understand how various tags
are used in Linux kernel.
Best regards,
Krzysztof
On 3/14/2026 5:53 PM, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On Fri, Mar 13, 2026 at 03:00:20PM +0800, Jian Hu wrote:
>> Fix redundant hyphen in "amlogic,t7-gp1--pll" string.
>>
>> Fixes: 5437753728ac ("dt-bindings: clock: add Amlogic T7 PLL clock controller")
>> Signed-off-by: Jian Hu <jian.hu@amlogic.com>
>> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> Incorrect DCO chain. I don't understand what Ronald's SoB is doing here.
> Please read submitting patches document to understand how various tags
> are used in Linux kernel.
Thanks for the your review, my apologies for not clarifying Ronald's
contribution clearly in the cover letter.
Ronald's "Add EMMC for T7 khadas VIM4" serial patches found it and
reported it.[1]
His patches intended to enable EMMC DT, but it depends on the T7 Clock
controller.
It includes the fixed clocks, sys clocks dt-bindings and drivers, But
these SCMI clock driver are done in the SCP firmware.[2]
The Amlogic T7 clocks controller DT should be enabled then he can enable
his work.
I sorted his clock fixing typo patch,submitted together with the fixing
missing mpll3 patch and T7 clock
controller DT which I have confirmed with him. The third patch depends
on the second patch.
So I submitted them separately.
His patch also submited some T7 clock controller DT nodes, I added his
SoB in the third patch, too.
So Could I add his SoB here or other tags like Co-developed-by for patch
1 and patch 3?
Also I will document the history in next cover letter.
[1]
https://patchwork.kernel.org/project/linux-amlogic/patch/20260218101904.35541-1-linux-kernel-dev@aliel.fr/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/dt-bindings/clock/amlogic,t7-scmi.h
>
>
> Best regards,
> Krzysztof
>
© 2016 - 2026 Red Hat, Inc.