After the commit 37c4e72b0651 ("scsi: Fix sas_user_scan() to handle
wildcard and multi-channel scans"), if the device supports multiple
channels (0 to shost->max_channel), user_scan() invokes updated
sas_user_scan() to perform the scan behavior for a specific transfer.
However, when the user specifies shost->max_channel, it will return
-EINVAL, which is not expected.

Fix and support specifying the scan shost->max_channel for scanning.

Fixes: 37c4e72b0651 ("scsi: Fix sas_user_scan() to handle wildcard and multi-channel scans")
Signed-off-by: Yihang Li <liyihang9@huawei.com>
---
 drivers/scsi/scsi_transport_sas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_transport_sas.c b/drivers/scsi/scsi_transport_sas.c
index 12124f9d5ccd..13412702188e 100644
--- a/drivers/scsi/scsi_transport_sas.c
+++ b/drivers/scsi/scsi_transport_sas.c
@@ -1734,7 +1734,7 @@ static int sas_user_scan(struct Scsi_Host *shost, uint channel,
 		break;
 
 	default:
-		if (channel < shost->max_channel) {
+		if (channel <= shost->max_channel) {
 			res = scsi_scan_host_selected(shost, channel, id, lun,
 						      SCSI_SCAN_MANUAL);
 		} else {
-- 
2.33.0

On 3/12/26 7:30 PM, Yihang Li wrote:
> Fix and support specifying the scan shost->max_channel for scanning.

A more specific prefix than "scsi:" should be used for SAS patches. In
the kernel log I found the following examples:
* scsi: transport: sas:
* scsi: scsi_transport_sas:

I'm not sure what prefix is preferred.

Thanks,

Bart.

Hi, Bart

On 2026/3/17 1:22, Bart Van Assche wrote:
> On 3/12/26 7:30 PM, Yihang Li wrote:
>> Fix and support specifying the scan shost->max_channel for scanning.
> 
> A more specific prefix than "scsi:" should be used for SAS patches. In
> the kernel log I found the following examples:
> * scsi: transport: sas:
> * scsi: scsi_transport_sas:
> 
> I'm not sure what prefix is preferred.

Thank you for your reply. I will carefully consider this suggestion.

Thanks,
Yihang