From: Maya Matuszczyk <maccraft123mc@gmail.com>
Add bindings for the EC firmware running on Hamoa/Purwa and Glymur
reference devices.
Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Co-developed-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>
---
.../embedded-controller/qcom,hamoa-ec.yaml | 56 ++++++++++++++++++++++
1 file changed, 56 insertions(+)
diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
new file mode 100644
index 000000000000..baa95f06644a
--- /dev/null
+++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Hamoa Embedded Controller
+
+maintainers:
+ - Sibi Sankar <sibi.sankar@oss.qualcomm.com>
+ - Anvesh Jain P <anvesh.p@oss.qualcomm.com>
+
+description:
+ Qualcomm Snapdragon based Hamoa/Purwa and Glymur reference devices have an
+ EC running on different MCU chips. The EC handles things like fan control,
+ temperature sensors, access to EC internal state changes.
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - qcom,glymur-crd-ec
+ - qcom,hamoa-iot-evk-ec
+ - const: qcom,hamoa-crd-ec
+ - enum:
+ - qcom,hamoa-crd-ec
+
+ reg:
+ const: 0x76
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ embedded-controller@76 {
+ compatible = "qcom,hamoa-crd-ec";
+ reg = <0x76>;
+
+ interrupts-extended = <&tlmm 66 IRQ_TYPE_LEVEL_HIGH>;
+ };
+ };
+...
--
2.34.1On 13/03/2026 11:29, Anvesh Jain P wrote: > From: Maya Matuszczyk <maccraft123mc@gmail.com> > > Add bindings for the EC firmware running on Hamoa/Purwa and Glymur > reference devices. > > Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com> > Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com> > Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com> > Co-developed-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com> > Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com> A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 > --- > .../embedded-controller/qcom,hamoa-ec.yaml | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > > diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml > new file mode 100644 > index 000000000000..baa95f06644a > --- /dev/null > +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml# Filename must match compatible. This is a standard review comment already documented in kernel and your internal guideline, no? Best regards, Krzysztof
On 3/14/2026 12:31 AM, Krzysztof Kozlowski wrote: > On 13/03/2026 11:29, Anvesh Jain P wrote: >> From: Maya Matuszczyk <maccraft123mc@gmail.com> >> >> Add bindings for the EC firmware running on Hamoa/Purwa and Glymur >> reference devices. >> >> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com> >> Co-developed-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com> >> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com> >> Co-developed-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com> >> Signed-off-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com> > > A nit, subject: drop second/last, redundant "bindings for". The > "dt-bindings" prefix is already stating that these are bindings. > See also: > https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Noted, will fix the subject in v5. > >> --- >> .../embedded-controller/qcom,hamoa-ec.yaml | 56 ++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml >> new file mode 100644 >> index 000000000000..baa95f06644a >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-ec.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/embedded-controller/qcom,hamoa-ec.yaml# > > Filename must match compatible. > > This is a standard review comment already documented in kernel and your > internal guideline, no? > You're right. The filename qcom,hamoa-ec.yaml does not match the base compatible qcom,hamoa-crd-ec. Will rename the file to qcom,hamoa-crd-ec.yaml and update the $id accordingly in v5. Thanks for the review! -- Best Regards, Anvesh
© 2016 - 2026 Red Hat, Inc.